Fix: fetch the count instead of fetching all the receipts

Author: maximopalopoli

aggregation_mode/batcher/src/config.rs

@@ -8,7 +8,7 @@ pub struct Config {
     pub db_connection_url: String,
     pub eth_rpc_url: String,
     pub payment_service_address: String,
-    pub max_proofs_per_day: usize,
+    pub max_proofs_per_day: i64,
 }
 
 impl Config {

aggregation_mode/batcher/src/db.rs

@@ -96,18 +96,15 @@ impl Db {
         .await
     }
 
-    pub async fn get_daily_tasks_by_address(
-        &self,
-        address: &str,
-    ) -> Result<Vec<Receipt>, sqlx::Error> {
-        sqlx::query_as::<_, Receipt>(
-            "SELECT status,merkle_path,nonce,address
+    pub async fn get_daily_tasks_by_address(&self, address: &str) -> Result<i64, sqlx::Error> {
+        sqlx::query_scalar::<_, i64>(
+            "SELECT COUNT(*)
             FROM tasks
             WHERE address = $1
             AND inserted_at::date = CURRENT_DATE",
         )
         .bind(address.to_lowercase())
-        .fetch_all(&self.pool)
+        .fetch_one(&self.pool)
         .await
     }
 

aggregation_mode/batcher/src/server/http.rs

@@ -102,16 +102,13 @@ impl BatcherServer {
         let state = state.get_ref();
 
         // Checking if this address has submited more proofs than the ones allowed per day
-        let daily_tasks_by_address = match state
+        let Ok(daily_tasks_by_address) = state
             .db
             .get_daily_tasks_by_address(&recovered_address)
             .await
-        {
-            Ok(receipts) => receipts.len(),
-            Err(_) => {
-                return HttpResponse::InternalServerError()
-                    .json(AppResponse::new_unsucessfull("Internal server error", 500))
-            }
+        else {
+            return HttpResponse::InternalServerError()
+                .json(AppResponse::new_unsucessfull("Internal server error", 500));
         };
 
         if daily_tasks_by_address >= state.config.max_proofs_per_day {