Move the immutable devmode flag from the initialize to the constructor

Author: maximopalopoli

contracts/script/deploy/AlignedProofAggregationServiceDeployer.s.sol

@@ -23,19 +23,18 @@ contract AlignedProofAggregationServiceDeployer is Script {
 
         vm.startBroadcast();
 
-        AlignedProofAggregationService alignedProofAggregationService = new AlignedProofAggregationService();
+        AlignedProofAggregationService alignedProofAggregationService = new AlignedProofAggregationService(devMode);
 
         ERC1967Proxy proxy = new ERC1967Proxy(
             address(alignedProofAggregationService),
             abi.encodeWithSignature(
-                "initialize(address,address,address,address,bytes32,bytes32,bool)",
+                "initialize(address,address,address,address,bytes32,bytes32)",
                 ownerAddress,
                 alignedAggregatorAddress,
                 sp1VerifierAddress,
                 risc0VerifierAddress,
                 risc0AggregationProgramImageId,
-                sp1AggregationProgramVKHash,
-                devMode
+                sp1AggregationProgramVKHash
             )
         );
 

contracts/script/upgrade/ProofAggregatorServiceUpgrader.s.sol

@@ -7,16 +7,19 @@ import "forge-std/Script.sol";
 import "forge-std/StdJson.sol";
 
 contract AlignedProofAggregationServiceUpgrader is Script {
-    function run(string memory alignedLayerDeploymentFilePath) external returns (address, address) {
+    function run(string memory alignedLayerDeploymentFilePath, string memory proofAggregatorConfigFilePath) external returns (address, address) {
         string memory aligned_deployment_file = vm.readFile(alignedLayerDeploymentFilePath);
+        string memory config_data = vm.readFile(proofAggregatorConfigFilePath);
 
         vm.startBroadcast();
 
         AlignedProofAggregationService proofAggregationServiceProxy = AlignedProofAggregationService(
             payable(stdJson.readAddress(aligned_deployment_file, ".addresses.alignedProofAggregationService"))
         );
 
-        AlignedProofAggregationService newProofAggregatorServiceImplementation = new AlignedProofAggregationService();
+        bool devMode = stdJson.readBool(config_data, ".devMode");
+
+        AlignedProofAggregationService newProofAggregatorServiceImplementation = new AlignedProofAggregationService(devMode);
 
         // Not link the new implementation to the proxy
         // Because this must be executed in the multisig

contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json

@@ -36,7 +36,7 @@ contract AlignedProofAggregationService is
     /// @notice whether we are in dev mode or not
     /// if true, verification checks are skipped (only for test deployments)
     /// This flag is set only at initialization and cannot be changed afterwards.
-    bool public devMode;
+    bool public immutable devMode;
 
     /// The unique identifier (image ID) of the RISC Zero aggregator program.
     /// This ensures that only proofs generated by a trusted Risc0 program can be verified.
@@ -46,7 +46,8 @@ contract AlignedProofAggregationService is
     /// This ensures that only proofs generated by a trusted SP1 program can be verified.
     bytes32 public sp1AggregatorProgramVKHash;
 
-    constructor() {
+    constructor(bool _devMode) {
+        devMode = _devMode;
         _disableInitializers();
     }
 
@@ -56,8 +57,7 @@ contract AlignedProofAggregationService is
         address _sp1VerifierAddress,
         address _risc0VerifierAddress,
         bytes32 _risc0AggregatorProgramImageId,
-        bytes32 _sp1AggregatorProgramVKHash,
-        bool _devMode
+        bytes32 _sp1AggregatorProgramVKHash
     ) public initializer {
         __Ownable_init();
         __UUPSUpgradeable_init();
@@ -67,7 +67,6 @@ contract AlignedProofAggregationService is
         risc0VerifierAddress = _risc0VerifierAddress;
         risc0AggregatorProgramImageId = _risc0AggregatorProgramImageId;
         sp1AggregatorProgramVKHash = _sp1AggregatorProgramVKHash;
-        devMode = _devMode;
     }
 
     function verifySP1(bytes32 blobVersionedHash, bytes calldata sp1PublicValues, bytes calldata sp1ProofBytes)