Make the disabled verifiers to be a provingSystemId instead of Strings

Author: maximopalopoli

crates/batcher/src/config/mod.rs

@@ -1,3 +1,4 @@
+use aligned_sdk::common::types::ProvingSystemId;
 use ethers::{core::k256::ecdsa::SigningKey, signers::Wallet, types::Address};
 use serde::Deserialize;
 
@@ -54,7 +55,7 @@ pub struct BatcherConfigFromYaml {
     pub amount_of_proofs_for_min_max_fee: usize,
     pub min_bump_percentage: u64,
     pub balance_unlock_polling_interval_seconds: u64,
-    pub disabled_verifiers: Vec<String>,
+    pub disabled_verifiers: Vec<ProvingSystemId>,
 }
 
 #[derive(Debug, Deserialize)]

crates/batcher/src/lib.rs

@@ -136,7 +136,7 @@ pub struct Batcher {
 
     // The list of disabled verifiers from the config file. Note that this is separate from the
     // contract's disabled verifiers, and is updated only when the batcher is restarted.
-    config_disabled_verifiers: Vec<String>,
+    config_disabled_verifiers: Vec<ProvingSystemId>,
 
     // Observability and monitoring
     pub metrics: metrics::BatcherMetrics,
@@ -1492,10 +1492,7 @@ impl Batcher {
 
     async fn is_verifier_disabled(&self, verifier: ProvingSystemId) -> bool {
         // Check if the verifier is disabled in the configuration first
-        if self
-            .config_disabled_verifiers
-            .contains(&verifier.to_string())
-        {
+        if self.config_disabled_verifiers.contains(&verifier) {
             return true;
         }
         let disabled_verifiers = self.disabled_verifiers.lock().await;

crates/sdk/src/common/types.rs

@@ -70,6 +70,24 @@ impl Display for ProvingSystemId {
     }
 }
 
+impl FromStr for ProvingSystemId {
+    type Err = String;
+
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        match s {
+            "GnarkPlonkBls12_381" => Ok(ProvingSystemId::GnarkPlonkBls12_381),
+            "GnarkPlonkBn254" => Ok(ProvingSystemId::GnarkPlonkBn254),
+            "GnarkGroth16Bn254" => Ok(ProvingSystemId::GnarkGroth16Bn254),
+            "SP1" => Ok(ProvingSystemId::SP1),
+            "Risc0" => Ok(ProvingSystemId::Risc0),
+            "CircomGroth16Bn256" => Ok(ProvingSystemId::CircomGroth16Bn256),
+            "Mina" => Ok(ProvingSystemId::Mina),
+            "MinaAccount" => Ok(ProvingSystemId::MinaAccount),
+            _ => Err(format!("Invalid ProvingSystemId: {}", s)),
+        }
+    }
+}
+
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct VerificationData {
     pub proving_system: ProvingSystemId,