feat: new gas price algorithm for respondtotask

Author: MarcosNicolau

core/chainio/avs_writer.go

@@ -21,7 +21,7 @@ import (
 )
 
 const (
-	gasBumpPercentage int = 10
+	gasBumpPercentage int = 20
 )
 
 type AvsWriter struct {
@@ -79,6 +79,7 @@ func NewAvsWriterFromConfig(baseConfig *config.BaseConfig, ecdsaConfig *config.E
 // Sends AggregatedResponse and waits for the receipt for three blocks, if not received
 // it will try again bumping the last tx gas price based on `CalculateGasPriceBump`
 // This process happens indefinitely until the transaction is included.
+// Note: If the rpc endpoints fail, the retry will stop, as it will infinitely try
 func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMerkleRoot [32]byte, senderAddress [20]byte, nonSignerStakesAndSignature servicemanager.IBLSSignatureCheckerNonSignerStakesAndSignature, onRetry func()) (*types.Receipt, error) {
 	txOpts := *w.Signer.GetTxOpts()
 	txOpts.NoSend = true // simulate the transaction
@@ -102,17 +103,23 @@ func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMe
 	txOpts.NoSend = false
 	txOpts.Nonce = txNonce
 
-	lastTxGasPrice := tx.GasPrice()
 	i := 0
 	sendTransaction := func() (*types.Receipt, error) {
 		if i > 0 {
 			onRetry()
 		}
 		i++
 
-		bumpedGasPrice := utils.CalculateGasPriceBump(lastTxGasPrice, gasBumpPercentage)
-		lastTxGasPrice = bumpedGasPrice
-		txOpts.GasPrice = bumpedGasPrice
+		// get gas price
+		gasPrice, err := w.Client.SuggestGasPrice(context.Background())
+		if err != nil {
+			// Retry with fallback
+			gasPrice, err = w.ClientFallback.SuggestGasPrice(context.Background())
+			if err != nil {
+				return nil, fmt.Errorf("transaction simulation failed: %v", err)
+			}
+		}
+		txOpts.GasPrice = utils.CalculateGasPriceBumpBasedOnRetry(gasPrice, gasBumpPercentage, i)
 
 		w.logger.Infof("Sending ResponseToTask transaction with a gas price of %v", txOpts.GasPrice)
 		err = w.checkRespondToTaskFeeLimit(tx, txOpts, batchIdentifierHash, senderAddress)

core/utils/eth_client_utils.go

@@ -48,10 +48,11 @@ func BytesToQuorumThresholdPercentages(quorumThresholdPercentagesBytes []byte) e
 	return quorumThresholdPercentages
 }
 
-// Very basic algorithm to calculate the gasPrice bump based on the currentGasPrice and percentage.
-// It adds a the percentage to the current gas price.
-func CalculateGasPriceBump(currentGasPrice *big.Int, percentage int) *big.Int {
-	percentageBump := big.NewInt(int64(percentage))
+// Very basic algorithm to calculate the gasPrice bump based on the currentGasPrice a constant percentage and the retry number.
+// It adds a the percentage to the current gas price and a 5% * i, where i is the iteration number. That is:
+func CalculateGasPriceBumpBasedOnRetry(currentGasPrice *big.Int, percentage int, i int) *big.Int {
+	retryPercentage := new(big.Int).Mul(big.NewInt(5), big.NewInt(int64(i)))
+	percentageBump := new(big.Int).Add(big.NewInt(int64(percentage)), retryPercentage)
 	bumpAmount := new(big.Int).Mul(currentGasPrice, percentageBump)
 	bumpAmount = new(big.Int).Div(bumpAmount, big.NewInt(100))
 	bumpedGasPrice := new(big.Int).Add(currentGasPrice, bumpAmount)