chore: address more clippy warnings

Author: MarcosNicolau

aggregation_mode/batcher/src/payments.rs

@@ -69,7 +69,7 @@ impl PaymentsPoller {
         Self {
             db,
             proof_aggregation_service,
-            rpc_provider: rpc_provider,
+            rpc_provider,
         }
     }
 
@@ -109,7 +109,7 @@ impl PaymentsPoller {
                     tracing::warn!("Skipping payment event for {address}: missing tx hash");
                     continue;
                 };
-                let tx_hash = format!("{:#x}", tx_hash);
+                let tx_hash = format!("{tx_hash:#x}");
 
                 let Ok(amount) = BigDecimal::from_str(&payment_event.amount.to_string()) else {
                     continue;

aggregation_mode/batcher/src/server/http.rs

@@ -219,10 +219,8 @@ impl BatcherServer {
                     "merkle_path": merkle_path
                 })))
             }
-            Err(_) => {
-                return HttpResponse::InternalServerError()
-                    .json(AppResponse::new_unsucessfull("Internal server error", 500))
-            }
+            Err(_) => HttpResponse::InternalServerError()
+                .json(AppResponse::new_unsucessfull("Internal server error", 500)),
         }
     }
 }

aggregation_mode/proof_aggregator/aggregation_programs/risc0/src/chunk_aggregator_main.rs

@@ -8,8 +8,8 @@ risc0_zkvm::guest::entry!(main);
 
 // Generated with `make proof_aggregator_write_program_ids` and copied from program_ids.json
 pub const USER_PROOFS_AGGREGATOR_PROGRAM_IMAGE_ID: [u8; 32] = [
-    253, 36, 51, 43, 163, 223, 190, 136, 60, 123, 233, 240, 170, 213, 170, 76, 117, 219, 15, 0, 47,
-    81, 218, 228, 232, 218, 86, 42, 145, 190, 144, 161,
+    86, 146, 102, 198, 206, 75, 142, 66, 123, 251, 236, 150, 2, 205, 75, 142, 237, 255, 93, 54, 2,
+    16, 190, 188, 246, 3, 188, 241, 235, 64, 220, 228,
 ];
 
 fn main() {
@@ -33,8 +33,7 @@ fn main() {
             .try_into()
             .expect("Public input to be the chunk merkle root");
 
-        let leaves_commitment: Vec<Hash32> =
-            leaves_commitment.into_iter().map(|el| Hash32(el)).collect();
+        let leaves_commitment: Vec<Hash32> = leaves_commitment.into_iter().map(Hash32).collect();
         let merkle_tree = MerkleTree::<Hash32>::build(&leaves_commitment).unwrap();
         assert!(merkle_root == merkle_tree.root);
 

aggregation_mode/proof_aggregator/aggregation_programs/risc0/src/user_proofs_aggregator_main.rs

@@ -10,8 +10,7 @@ fn main() {
     let input = env::read::<UserProofsAggregatorInput>();
 
     for proof in &input.proofs_image_id_and_pub_inputs {
-        env::verify(proof.image_id.clone(), &proof.public_inputs)
-            .expect("proof to be verified correctly");
+        env::verify(proof.image_id, &proof.public_inputs).expect("proof to be verified correctly");
     }
 
     let merkle_tree =

aggregation_mode/proof_aggregator/aggregation_programs/sp1/src/chunk_aggregator_main.rs

@@ -33,8 +33,7 @@ pub fn main() {
             .expect("Public input to be the hash of the chunk tree");
 
         // Reconstruct the merkle tree and verify that the roots match
-        let leaves_commitment: Vec<Hash32> =
-            leaves_commitment.into_iter().map(|el| Hash32(el)).collect();
+        let leaves_commitment: Vec<Hash32> = leaves_commitment.into_iter().map(Hash32).collect();
         let merkle_tree: MerkleTree<Hash32> = MerkleTree::build(&leaves_commitment).unwrap();
         assert!(merkle_tree.root == merkle_root);
 

aggregation_mode/proof_aggregator/programs_ids.json

@@ -1,8 +1,8 @@
 {
-  "risc0_chunk_aggregator_image_id": "0xd8cfdd5410c70395c0a1af1842a0148428cc46e353355faccfba694dd4862dbf",
-  "risc0_user_proofs_aggregator_image_id": "0xfd24332ba3dfbe883c7be9f0aad5aa4c75db0f002f51dae4e8da562a91be90a1",
-  "risc0_user_proofs_aggregator_image_id_bytes": "[253, 36, 51, 43, 163, 223, 190, 136, 60, 123, 233, 240, 170, 213, 170, 76, 117, 219, 15, 0, 47, 81, 218, 228, 232, 218, 86, 42, 145, 190, 144, 161]",
-  "sp1_chunk_aggregator_vk_hash": "0x007df9874549bf8d4c135c40eae4a1b182677356699e528ba0305b3dcc774090",
+  "risc0_chunk_aggregator_image_id": "0x8908f01022827e80a5de71908c16ee44f4a467236df20f62e7c994491629d74c",
+  "risc0_user_proofs_aggregator_image_id": "0x569266c6ce4b8e427bfbec9602cd4b8eedff5d360210bebcf603bcf1eb40dce4",
+  "risc0_user_proofs_aggregator_image_id_bytes": "[86, 146, 102, 198, 206, 75, 142, 66, 123, 251, 236, 150, 2, 205, 75, 142, 237, 255, 93, 54, 2, 16, 190, 188, 246, 3, 188, 241, 235, 64, 220, 228]",
+  "sp1_chunk_aggregator_vk_hash": "0x00d6e32a34f68ea643362b96615591c94ee0bf99ee871740ab2337966a4f77af",
   "sp1_user_proofs_aggregator_vk_hash": "0x00a0fe3e73d4dd5f66369c60629213c8a037da04f8f68724c8a15ed1d20a0d5e",
   "sp1_user_proofs_aggregator_vk_hash_words": "[1350508345, 1966561241, 1188269068, 690044042, 29282343, 1675238547, 289586595, 1376390494]"
 }