Log address on lack of funds error (#2119)

Author: MauroToscano

crates/batcher/src/lib.rs

@@ -1820,8 +1820,9 @@ impl Batcher {
             // decide if i want to flush the queue:
             match e {
                 BatcherError::TransactionSendError(
-                    TransactionSendError::SubmissionInsufficientBalance,
+                    TransactionSendError::SubmissionInsufficientBalance(address),
                 ) => {
+                    warn!("User {:?} has insufficient balance, flushing entire queue as safety measure", address);
                     // TODO: In the future, we should re-add the failed batch back to the queue
                     // For now, we flush everything as a safety measure
                     self.flush_queue_and_clear_nonce_cache().await;

crates/batcher/src/types/errors.rs

@@ -7,7 +7,7 @@ pub enum TransactionSendError {
     NoProofSubmitters,
     NoFeePerProof,
     InsufficientFeeForAggregator,
-    SubmissionInsufficientBalance,
+    SubmissionInsufficientBalance(Address),
     BatchAlreadySubmitted,
     InsufficientFunds,
     OnlyBatcherAllowed,
@@ -30,8 +30,16 @@ impl From<Bytes> for TransactionSendError {
             "0x3102f10c" => TransactionSendError::BatchAlreadySubmitted, // can happen, don't flush
             "0x5c54305e" => TransactionSendError::InsufficientFunds, // shouldn't happen, don't flush
             "0x152bc288" => TransactionSendError::OnlyBatcherAllowed, // won't happen, don't flush
-            "0x4f779ceb" => TransactionSendError::SubmissionInsufficientBalance, // shouldn't happen,
-            // flush can help if something went wrong
+            "0x4f779ceb" => {
+                // SubmissionInsufficientBalance(address sender, uint256 balance, uint256 required)
+                // Try to decode the address parameter (first parameter after selector)
+                let address = byte_string
+                    .get(34..74) // Skip "0x" + selector (8 chars) + padding (24 chars)
+                    .and_then(|hex_str| hex::decode(hex_str).ok())
+                    .map(|bytes| Address::from_slice(&bytes))
+                    .unwrap_or(Address::zero());
+                TransactionSendError::SubmissionInsufficientBalance(address)
+            }
             _ => {
                 // flush because unkown error
                 TransactionSendError::Generic(format!("Unknown bytestring error: {}", byte_string))
@@ -155,8 +163,12 @@ impl fmt::Display for TransactionSendError {
             TransactionSendError::InsufficientFeeForAggregator => {
                 write!(f, "Insufficient fee for aggregator")
             }
-            TransactionSendError::SubmissionInsufficientBalance => {
-                write!(f, "Submission insufficient balance")
+            TransactionSendError::SubmissionInsufficientBalance(address) => {
+                write!(
+                    f,
+                    "Submission insufficient balance for address: {:?}",
+                    address
+                )
             }
             TransactionSendError::BatchAlreadySubmitted => {
                 write!(f, "Batch already submitted")