1201 make risc0 public input optional (#1204)

Co-authored-by: Mariano Nicolini <[email protected]>

Author: PatStiles

Makefile

@@ -307,6 +307,16 @@ batcher_send_risc0_task:
 		--rpc_url $(RPC_URL) \
 		--network $(NETWORK)
 
+batcher_send_risc0_task_no_pub_input:
+	@echo "Sending Risc0 fibonacci task to Batcher..."
+	@cd batcher/aligned/ && cargo run --release -- submit \
+		--proving_system Risc0 \
+		--proof ../../scripts/test_files/risc_zero/no_public_inputs/risc_zero_no_pub_input.proof \
+        --vm_program ../../scripts/test_files/risc_zero/no_public_inputs/no_pub_input_id.bin \
+		--proof_generator_addr 0x66f9664f97F2b50F62D13eA064982f936dE76657 \
+		--rpc_url $(RPC_URL) \
+		--payment_service_addr $(BATCHER_PAYMENTS_CONTRACT_ADDRESS)
+
 batcher_send_risc0_burst:
 	@echo "Sending Risc0 fibonacci task to Batcher..."
 	@cd batcher/aligned/ && cargo run --release -- submit \
@@ -502,6 +512,11 @@ generate_sp1_fibonacci_proof:
 	@mv scripts/test_files/sp1/fibonacci_proof_generator/script/sp1_fibonacci.proof scripts/test_files/sp1/
 	@echo "Fibonacci proof and ELF generated in scripts/test_files/sp1 folder"
 
+generate_risc_zero_empty_journal_proof:
+	@cd scripts/test_files/risc_zero/no_public_inputs && RUST_LOG=info cargo run --release
+	@echo "Fibonacci proof and ELF with empty journal generated in scripts/test_files/risc_zero/no_public_inputs folder"
+
+
 __RISC_ZERO_FFI__: ##
 build_risc_zero_macos:
 	@cd operator/risc_zero/lib && cargo build $(RELEASE_FLAG)

batcher/aligned-batcher/src/zk_utils/mod.rs

@@ -21,21 +21,23 @@ fn verify_internal(verification_data: &VerificationData) -> bool {
             false
         }
         ProvingSystemId::Risc0 => {
-            if let (Some(image_id_slice), Some(pub_input)) = (
-                &verification_data.vm_program_code,
-                &verification_data.pub_input,
-            ) {
-                let mut image_id = [0u8; 32];
-                image_id.copy_from_slice(image_id_slice.as_slice());
-                return verify_risc_zero_proof(
-                    verification_data.proof.as_slice(),
-                    &image_id,
-                    pub_input,
+            let Some(image_id_slice) = &verification_data.vm_program_code else {
+                warn!(
+                    "Trying to verify Risc0 proof but image id was not provided. Returning false"
                 );
-            }
+                return false;
+            };
 
-            warn!("Trying to verify Risc0 proof but image id or public input was not provided. Returning false");
-            false
+            // Risc0 can have 0 public input. In which case we supply an empty Vec<u8>.
+            let pub_input = verification_data.pub_input.clone().unwrap_or_default();
+
+            let mut image_id = [0u8; 32];
+            image_id.copy_from_slice(image_id_slice.as_slice());
+            return verify_risc_zero_proof(
+                verification_data.proof.as_slice(),
+                &image_id,
+                &pub_input,
+            );
         }
         ProvingSystemId::GnarkPlonkBls12_381
         | ProvingSystemId::GnarkPlonkBn254

batcher/aligned/src/main.rs

@@ -506,10 +506,13 @@ fn verification_data_from_args(args: &SubmitArgs) -> Result<VerificationData, Su
                 "--vm_program",
                 args.vm_program_code_file_name.clone(),
             )?);
-            pub_input = Some(read_file_option(
-                "--public_input",
-                args.pub_input_file_name.clone(),
-            )?);
+
+            // Risc0 and have zero or none public inputs
+            pub_input = args
+                .pub_input_file_name
+                .clone()
+                .map(read_file)
+                .transpose()?;
         }
         ProvingSystemId::GnarkPlonkBls12_381
         | ProvingSystemId::GnarkPlonkBn254

docs/3_guides/0_submitting_proofs.md

@@ -177,6 +177,7 @@ risc0-zkvm = { git = "https://github.com/risc0/risc0", tag = "v1.0.1", default-f
     "prove",
 ] }
 ```
+- Note: In Risc0 verification `--pub_input` contains the bytes of the `receipt.journal.bytes` which contains both the public input (`env::read()`) and public output (`env::commit()`) values of a program executed in the Risc0 VM. If your Risc0 program contains public outputs, but no public inputs you still need to submit the serialized `receipt.journal.bytes` with your proof using the Aligned CLI for your proof to be verified.
 
 **Example**
 

scripts/test_files/risc_zero/no_public_inputs/.gitignore

@@ -0,0 +1,8 @@
+# Cargo build
+**/target
+
+# Cargo config
+.cargo
+
+# MacOS nuisances
+.DS_Store