fix(explorer): count only active operators for weight (#934)

Co-authored-by: Gian <[email protected]>
Co-authored-by: MauroFab <[email protected]>

Author: 3 people

Makefile

@@ -151,7 +151,7 @@ operator_register_with_eigen_layer:
 
 operator_mint_mock_tokens:
 	@echo "Minting tokens"
-	. ./scripts/mint_mock_token.sh $(CONFIG_FILE) 1000
+	. ./scripts/mint_mock_token.sh $(CONFIG_FILE) 100000000000000000
 
 operator_whitelist_devnet:
 	@echo "Whitelisting operator"
@@ -170,7 +170,7 @@ operator_deposit_into_mock_strategy:
 	@go run operator/cmd/main.go deposit-into-strategy \
 		--config $(CONFIG_FILE) \
 		--strategy-address $(STRATEGY_ADDRESS) \
-		--amount 1000
+		--amount 100000000000000000
 
 operator_deposit_into_strategy:
 	@echo "Depositing into strategy"

docs/3_guides/6_setup_aligned.md

@@ -534,6 +534,9 @@ to run it using the following documentation:
 - [Erlang 26](https://github.com/asdf-vm/asdf-erlang)
 - [Elixir 1.16.2](https://elixir-ko.github.io/install.html), compiled with OTP 26
 - [Docker](https://docs.docker.com/get-docker/)
+- [NodeJS](https://nodejs.org/en/download/package-manager)
+  - Tested with node 20 and 22
+- [pnpm](https://pnpm.io/installation)
 
 ### DB Setup
 

explorer/lib/explorer/contract_managers/strategy_interface_manager.ex

@@ -25,8 +25,12 @@ defmodule StrategyInterfaceManager do
     case ERC20InterfaceManager.name(token_address) do
       {:ok, name} -> %{strategy | name: name}
       error ->
-        "Error fetching token name for #{token_address}: #{inspect(error)}" |> Logger.error()
-        error
+        case error do
+          {:error, %{"code" => 3, "data" => "0x", "message" => "execution reverted"}} -> %{strategy | name: "‎"} # token has no Name (empty char), not a common practice but still an ERC20
+          _ ->
+            "Error fetching token name for #{token_address}: #{inspect(error)}" |> Logger.error()
+            error
+        end
     end
   end
   def fetch_token_name({:error, error}) do
@@ -37,8 +41,12 @@ defmodule StrategyInterfaceManager do
     case ERC20InterfaceManager.symbol(token_address) do
       {:ok, symbol} -> %{strategy | symbol: symbol}
       error ->
-        "Error fetching token symbol for #{token_address}: #{inspect(error)}" |> Logger.error()
-        error
+        case error do
+          {:error, %{"code" => 3, "data" => "0x", "message" => "execution reverted"}} -> %{strategy | symbol: "‎"} # token has no Symbol (empty char), not a common practice but still an ERC20
+          _ ->
+            "Error fetching token symbol for #{token_address}: #{inspect(error)}" |> Logger.error()
+            error
+        end
     end
   end
   def fetch_token_symbol({:error, error}) do

explorer/lib/explorer/models/operators.ex

@@ -32,6 +32,15 @@ defmodule Operators do
     Operators.changeset(%Operators{}, Map.from_struct(operator))
   end
 
+  def generate_new_total_stake_changeset(%{operator_address: operator_address}) do
+    new_total_stake = StakeRegistryManager.get_stake_of_quorum_for_operator(%Restakings{operator_address: operator_address})
+
+    query = from(o in Operators, where: o.address == ^operator_address, select: o)
+    operator = Explorer.Repo.one(query)
+
+    Operators.changeset(operator, %{total_stake: new_total_stake})
+  end
+
   def get_operator_by_address(address) do
     query = from(o in Operators, where: o.address == ^address, select: o)
     Explorer.Repo.one(query)
@@ -48,13 +57,23 @@ defmodule Operators do
   end
 
   def get_operators_with_their_weights() do
-    total_stake = Explorer.Repo.one(from(o in Operators, select: sum(o.total_stake)))
+    total_stake = Explorer.Repo.one(
+      from(
+        o in Operators,
+        where: o.is_active == true,
+        select: sum(o.total_stake))
+    )
 
     get_operators() |>
       Enum.map(
         fn operator ->
-          weight = Decimal.div(operator.total_stake, total_stake)
-          Map.from_struct(operator) |> Map.put(:weight, weight)
+          case operator.is_active do
+            false ->
+              Map.from_struct(operator) |> Map.put(:weight, 0)
+            true ->
+              weight = Decimal.div(operator.total_stake, total_stake)
+              Map.from_struct(operator) |> Map.put(:weight, weight)
+          end
         end
       )
   end
@@ -115,7 +134,8 @@ defmodule Operators do
 
   def unregister_operator(%Operators{address: address}) do
     query = from(o in Operators, where: o.address == ^address)
-    Explorer.Repo.update_all(query, set: [is_active: false])
+    Explorer.Repo.update_all(query, set: [is_active: false, total_stake: 0])
+    Restakings.remove_restakes_of_operator(%{operator_address: address})
   end
 
   def get_total_stake(%Operators{} = operator) do

explorer/lib/explorer/models/quorums.ex

@@ -16,7 +16,7 @@ defmodule Quorums do
   def handle_quorum(%Quorums{} = quorum) do
     strategy_addresses = StakeRegistryManager.get_strategies_of_quorum(quorum.id)
 
-    insert_quorum_if_not_present(quorum)
+    insert_quorum_if_not_present(quorum) # Only for new Quorums inserted by running Quorums.handle_quorum(%Quorums{id: 0})
 
     Enum.each(strategy_addresses,
       fn strategy_address ->

explorer/lib/explorer/models/restakings.ex

@@ -29,6 +29,7 @@ defmodule Restakings do
     Operators.get_operators()
       |> Enum.map(fn operator -> StakeRegistryManager.has_operator_changed_staking(%{fromBlock: from_block, operator_id: operator.id, operator_address: operator.address}) end)
       |> Enum.reject(fn {_operator_id, _operator_address, has_changed_stake} -> not has_changed_stake end)
+      |> Enum.reject(fn {operator_id, _operator_address, _has_changed_stake} -> not Operators.get_operator_by_id(operator_id).is_active end)
       |> Enum.map(fn {operator_id, operator_address, _has_changed_stake} -> DelegationManager.get_operator_all_strategies_shares(%Operators{id: operator_id, address: operator_address}) end)
       |> Enum.each(&insert_or_update_restakings/1)
   end
@@ -54,6 +55,9 @@ defmodule Restakings do
           |> Ecto.Multi.update(:update_strategy_total_staked, Strategies.generate_update_total_staked_changeset(%{new_restaking: restaking}))
       end
 
+    multi = multi
+      |> Ecto.Multi.update(:update_operator_total_stake, Operators.generate_new_total_stake_changeset(%{operator_address: restaking.operator_address}))
+
     case Explorer.Repo.transaction(multi) do
       {:ok, _} ->
         "Restaking inserted or updated" |> Logger.debug()
@@ -64,7 +68,16 @@ defmodule Restakings do
     end
   end
 
-   def get_by_operator_and_strategy(%Restakings{operator_address: operator_address, strategy_address: strategy_address}) do
+  def remove_restakes_of_operator(%{operator_address: operator_address}) do
+    Logger.debug("Removing restakes of operator")
+    query = from(r in Restakings, where: r.operator_address == ^operator_address)
+    restakings = Explorer.Repo.all(query)
+
+    Explorer.Repo.delete_all(query)
+    Enum.each(restakings, &Strategies.discount_restaking/1)
+  end
+
+  def get_by_operator_and_strategy(%Restakings{operator_address: operator_address, strategy_address: strategy_address}) do
     query = from(
       r in Restakings,
       where: r.operator_address == ^operator_address and r.strategy_address == ^strategy_address,

explorer/lib/explorer/models/strategies.ex

@@ -99,4 +99,18 @@ defmodule Strategies do
     Strategies.changeset(strategy, %{total_staked: new_stake})
   end
 
+  def discount_restaking(restaking) do
+    query = from(s in Strategies,
+      where: s.strategy_address == ^restaking.strategy_address,
+      select: s)
+    strategy = Explorer.Repo.one(query)
+
+    new_stake =
+      strategy.total_staked
+      |> Decimal.sub(restaking.stake)
+      |> (fn stake -> if Decimal.compare(stake, 0) == :lt, do: Decimal.new(0), else: stake end).()
+      
+    Strategies.changeset(strategy, %{total_staked: new_stake}) |> Explorer.Repo.update()
+
+  end
 end

explorer/lib/explorer_web/live/pages/restakes/index.ex

@@ -59,7 +59,11 @@ defmodule ExplorerWeb.Restakes.Index do
                 alt={asset.name}
                 class="size-5 rounded-full object-scale-down text-xs truncate text-center"
               />
-              <%= asset.name %>
+              <%= if asset.name != "‎" do %>
+                <%= asset.name %>
+              <% else %>
+                <%= asset.strategy_address %>
+              <% end %>
               <p class="text-muted-foreground text-sm">
                 <%= asset.symbol %>
               </p>