adjust db retries params + explanation

Author: MarcosNicolau

aggregation_mode/gateway/src/db.rs

@@ -2,7 +2,27 @@ use crate::types::Receipt;
 use db::{orchestrator::DbOrchestartor, retry::RetryConfig};
 use sqlx::types::{BigDecimal, Uuid};
 
-// Retry parameters for Db queries
+// Retry/backoff behavior summary (see
+// aggregation_mode/db/src/orchestrator.rs:next_back_off_delay for implementation)
+//
+// NOTE: These retry limits are intentionally lower than in other crates.
+// This code runs in an HTTP server; in the worst case the request fails fast
+// and the client can retry the request. Prolonged blocking retries here are
+// less critical than in background or batch processing jobs.
+//
+// 1) Max wait time between failures if all retries fail:
+//    The sleep between retries is capped at 10 seconds (RETRY_MAX_DELAY_SECONDS).
+//
+// 2) Wait before each retry attempt with the current config
+//    (start = 500ms, factor = 2.0, max retries = 4):
+//
+//    retry 1: 0.5s
+//    retry 2: 1.0s
+//    retry 3: 2.0s
+//    retry 4: 4.0s
+//
+//    Worst-case total sleep time across all retries: 7.5 seconds,
+//    plus the execution time of each DB attempt.
 /// Initial delay before first retry attempt (in milliseconds)
 const RETRY_MIN_DELAY_MILLIS: u64 = 500;
 /// Exponential backoff multiplier for retry delays

aggregation_mode/payments_poller/src/db.rs

@@ -1,11 +1,27 @@
 use db::{orchestrator::DbOrchestartor, retry::RetryConfig};
 use sqlx::types::BigDecimal;
 
-// Retry parameters for Db queries
+// Retry/backoff behavior summary for DB queries (see
+// aggregation_mode/db/src/orchestrator.rs:next_back_off_delay for implementation)
+//
+// 1) Max wait time between failures if all retries fail:
+//    The sleep between retries is capped at 30 seconds (RETRY_MAX_DELAY_SECONDS).
+//
+// 2) Wait before each retry attempt with the current config
+//    (start = 500ms, factor = 4.0, max retries = 5):
+//
+//    retry 1: 0.5s
+//    retry 2: 2.0s
+//    retry 3: 8.0s
+//    retry 4: 30s (capped; 32s would have been next)
+//    retry 5: 30s
+//
+//    Worst-case total sleep time across all retries: 70.5 seconds -> 5 blocks of ethereum waiting,
+//    plus the execution time of each DB attempt.
 /// Initial delay before first retry attempt (in milliseconds)
 const RETRY_MIN_DELAY_MILLIS: u64 = 500;
 /// Exponential backoff multiplier for retry delays
-const RETRY_FACTOR: f32 = 2.0;
+const RETRY_FACTOR: f32 = 4.0;
 /// Maximum number of retry attempts
 const RETRY_MAX_TIMES: usize = 5;
 /// Maximum delay between retry attempts (in seconds)

aggregation_mode/proof_aggregator/src/backend/db.rs

@@ -1,13 +1,29 @@
 use db::{orchestrator::DbOrchestartor, retry::RetryConfig, types::Task};
 use sqlx::types::Uuid;
 
-// Retry parameters for Db queries
+// Retry/backoff behavior summary (see
+// aggregation_mode/db/src/orchestrator.rs:next_back_off_delay for implementation)
+//
+// 1) Max wait time between failures if all retries fail:
+//    The sleep between retries is capped at 30 seconds (RETRY_MAX_DELAY_SECONDS).
+//
+// 2) Wait before each retry attempt with the current config
+//    (start = 500ms, factor = 5.0, max retries = 10):
+//
+//    retry 1: 0.5s
+//    retry 2: 2.5s
+//    retry 3: 12.5s
+//    retry 4: 30s (capped)
+//    retry 5–10: 30s each
+//
+//    Worst-case total sleep time across all retries: ~3m 48s,
+//    plus the execution time of each DB attempt.
 /// Initial delay before first retry attempt (in milliseconds)
 const RETRY_MIN_DELAY_MILLIS: u64 = 500;
 /// Exponential backoff multiplier for retry delays
-const RETRY_FACTOR: f32 = 2.0;
+const RETRY_FACTOR: f32 = 5.0;
 /// Maximum number of retry attempts
-const RETRY_MAX_TIMES: usize = 5;
+const RETRY_MAX_TIMES: usize = 10;
 /// Maximum delay between retry attempts (in seconds)
 const RETRY_MAX_DELAY_SECONDS: u64 = 30;