fix: parse error codes from createNewTask ethereum contract function (#1503)

Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Co-authored-by: Urix <[email protected]>

Author: 4 people

batcher/aligned-batcher/src/retry/batcher_retryables.rs

@@ -10,7 +10,7 @@ use crate::{
         utils::get_current_nonce,
     },
     retry::RetryError,
-    types::errors::BatcherError,
+    types::errors::{BatcherError, TransactionSendError},
 };
 
 pub async fn get_user_balance_retryable(
@@ -130,7 +130,7 @@ pub async fn create_new_task_retryable(
             // Since transaction was reverted, we don't want to retry with fallback.
             warn!("Transaction reverted {:?}", err);
             return Err(RetryError::Permanent(BatcherError::TransactionSendError(
-                err.to_string(),
+                TransactionSendError::from(err),
             )));
         }
         _ => {
@@ -149,12 +149,12 @@ pub async fn create_new_task_retryable(
                 Err(ContractError::Revert(err)) => {
                     warn!("Transaction reverted {:?}", err);
                     return Err(RetryError::Permanent(BatcherError::TransactionSendError(
-                        err.to_string(),
+                        TransactionSendError::from(err),
                     )));
                 }
                 Err(err) => {
                     return Err(RetryError::Transient(BatcherError::TransactionSendError(
-                        err.to_string(),
+                        TransactionSendError::Generic(err.to_string()),
                     )))
                 }
             }

batcher/aligned-batcher/src/types/errors.rs

@@ -1,8 +1,44 @@
 use std::fmt;
 
-use ethers::types::{Address, SignatureError};
+use ethers::types::{Address, Bytes, SignatureError};
 use tokio_tungstenite::tungstenite;
 
+pub enum TransactionSendError {
+    NoProofSubmitters,
+    NoFeePerProof,
+    InsufficientFeeForAggregator,
+    SubmissionInsufficientBalance,
+    BatchAlreadySubmitted,
+    InsufficientFunds,
+    OnlyBatcherAllowed,
+    Generic(String),
+}
+
+impl From<Bytes> for TransactionSendError {
+    fn from(e: Bytes) -> Self {
+        let byte_string = e.to_string();
+        let str_code = if byte_string.len() >= 10 {
+            &byte_string[..10] // Extract the error code only
+        } else {
+            "" // Not gonna match
+        };
+        match str_code {
+            "0xc43ac290" => TransactionSendError::NoProofSubmitters, // can't happen, don't flush
+            "0xa3a8658a" => TransactionSendError::NoFeePerProof,     // can't happen, don't flush
+            "0x7899ec71" => TransactionSendError::InsufficientFeeForAggregator, // shouldn't happen, don't flush
+            // returning the proofs and retrying later may help
+            "0x4f779ceb" => TransactionSendError::SubmissionInsufficientBalance, // shouldn't happen,
+            // flush can help if something went wrong
+            "0x3102f10c" => TransactionSendError::BatchAlreadySubmitted, // can happen, don't flush
+            "0x5c54305e" => TransactionSendError::InsufficientFunds, // shouldn't happen, don't flush
+            "0x152bc288" => TransactionSendError::OnlyBatcherAllowed, // won't happen, don't flush
+            _ => {
+                TransactionSendError::Generic(format!("Unknown bytestring error: {}", byte_string))
+            }
+        }
+    }
+}
+
 pub enum BatcherError {
     TcpListenerError(String),
     ConnectionError(tungstenite::Error),
@@ -12,7 +48,7 @@ pub enum BatcherError {
     BatchUploadError(String),
     TaskCreationError(String),
     ReceiptNotFoundError,
-    TransactionSendError(String),
+    TransactionSendError(TransactionSendError),
     MaxRetriesReachedError,
     SerializationError(String),
     GasPriceError,
@@ -101,3 +137,34 @@ impl fmt::Debug for BatcherError {
         }
     }
 }
+
+impl fmt::Display for TransactionSendError {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        match self {
+            TransactionSendError::NoProofSubmitters => {
+                write!(f, "No proof submitter error")
+            }
+            TransactionSendError::NoFeePerProof => {
+                write!(f, "No fee per proof")
+            }
+            TransactionSendError::InsufficientFeeForAggregator => {
+                write!(f, "Insufficient fee for aggregator")
+            }
+            TransactionSendError::SubmissionInsufficientBalance => {
+                write!(f, "Submission insufficient balance")
+            }
+            TransactionSendError::BatchAlreadySubmitted => {
+                write!(f, "Batch already submitted")
+            }
+            TransactionSendError::InsufficientFunds => {
+                write!(f, "Insufficient funds")
+            }
+            TransactionSendError::OnlyBatcherAllowed => {
+                write!(f, "Only batcher allowed")
+            }
+            TransactionSendError::Generic(e) => {
+                write!(f, "Generic error: {}", e)
+            }
+        }
+    }
+}