docs: improve propose_upgrade and approve_upgrade

Author: JuArce

docs/0_internal/3_b_2_propose_upgrade.md

@@ -6,78 +6,72 @@ After deploying a new implementation candidate for the upgrade, you need to prop
 
 To propose the upgrade transaction you can follow the steps below:
 
-1. If you want to upgrade the ```alignedLayerServiceManager``` get the ```alignedLayerServiceManager``` and ```alignedServiceManagerImplementation``` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```.
-    
-    If you want to upgrade the ```batcherPaymentService``` get the ```batcherPaymentServiceImplementation``` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```.
+1. Go to [Safe](https://app.safe.global/home)
 
-2. If you want to upgrade the ```alignedLayerServiceManager``` generate the `calldata` for the upgrade transaction by running:
-
-    ```bash
-    cast calldata "upgrade(address, address)" <alignedLayerServiceManager> <alignedLayerServiceManagerImplementation>
-    ```
-   
-    If you want to upgrade the ```batcherPaymentService``` generate the `calldata` for the upgrade transaction by running:
-
-    ```bash
-   cast calldata "upgradeTo(address)" <batcherPaymentServiceImplementation>
-   ```
-
-3. Verify the contract bytecode running the following command:
-
-   ```
-   TODO
-   ```
-   
-4. Once the proposed upgrade is validated, you can create the upgrade transaction on [Safe](https://app.safe.global/home)
-
-5. Click on `New transaction` -> `Transaction Builder`
+2. Click on `New transaction` -> `Transaction Builder`
 
    ![New transaction](./images/3_b_2_multisig_1.png)
 
    ![Transaction Builder](./images/3_b_2_multisig_2.png)
 
-6. Enable `Custom data`
+3. Enable `Custom data`
 
-7. Get the `ProxyAdmin` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```, and paste it on `Enter Address or ENS Name`
+4. Get the `alignedLayerProxyAdmin` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```, and paste it on `Enter Address or ENS Name`
 
-8. Once you paste the `ProxyAdmin` address, the ABI should be automatically filled.
+5. Once you paste the `alignedLayerProxyAdmin` address, the ABI should be automatically filled.
 
       ![Enter Address or ENS Name](./images/3_b_2_multisig_3.png)
 
       ![Enter ABI](./images/3_b_2_multisig_4.png)
 
-9. Set the `ETH Value` as 0
+6. Set the `ETH Value` as 0
 
       ![ETH Value](./images/3_b_2_multisig_5.png)
 
-10. Paste the calldata obtained from the deployment of the new implementation on the `Data` box and click on `+ Add new transaction`.
+7. If you want to upgrade the ```alignedLayerServiceManager``` get the ```alignedLayerServiceManager``` and ```alignedServiceManagerImplementation``` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```.
+
+   If you want to upgrade the ```batcherPaymentService``` get the ```batcherPaymentServiceImplementation``` address from ```contracts/script/output/mainnet/alignedlayer_deployment_output.json``` or ```contracts/script/output/holesky/alignedlayer_deployment_output.json``` or ```contracts/script/output/sepolia/alignedlayer_deployment_output.json```.
+
+8. If you want to upgrade the ```alignedLayerServiceManager``` generate the `calldata` for the upgrade transaction by running:
+
+    ```bash
+    cast calldata "upgrade(address, address)" <alignedLayerServiceManager> <alignedLayerServiceManagerImplementation>
+    ```
+
+   If you want to upgrade the ```batcherPaymentService``` generate the `calldata` for the upgrade transaction by running:
+
+    ```bash
+   cast calldata "upgradeTo(address)" <batcherPaymentServiceImplementation>
+   ```
+
+9. Paste the calldata obtained from the deployment of the new implementation on the `Data` box and click on `+ Add new transaction`.
 
-      ![Data](./images/3_b_2_multisig_6.png)
+     ![Data](./images/3_b_2_multisig_6.png)
 
-      You should see the new transaction to be executed on the right side.
+     You should see the new transaction to be executed on the right side.
 
-11. Click on `Create batch` to create the transaction.
+10. Click on `Create batch` to create the transaction.
 
       ![Create batch](./images/3_b_2_multisig_7.png)
 
-12. Review and confirm the transaction.
+11. Review and confirm the transaction.
 
       To make sure everything is fine, simulate the transaction by clicking on `Simulate batch`
 
       Once the simulation is successful, click on `Send Batch` to send the transaction.
 
       ![Simulate batch](./images/3_b_2_multisig_8.png)
 
-13. Confirm the transaction checking the function being called is correct and the contract address is the one you deployed.
+12. Confirm the transaction checking the function being called is correct and the contract address is the one you deployed.
 
       If everything is correct, click on `Sign` to send the transaction.
 
       ![Confirm transaction](./images/3_b_2_multisig_9.png)
 
-14. Now in your transactions, you should be able to see the newly created transaction.
+13. Now in your transactions, you should be able to see the newly created transaction.
 
       ![New transaction](./images/3_b_2_multisig_10.png)
 
-15. If the transaction is correctly created, you have to wait until the required Multisig member signs the transaction to send it.
+14. If the transaction is correctly created, you have to wait until the required Multisig member signs the transaction to send it.
 
 A guide on how to sign the transaction can be found [here](./3_b_3_approve_upgrade.md)

docs/0_internal/3_b_3_approve_upgrade.md

@@ -2,9 +2,6 @@
 
 Once the transaction is proposed, the multisig owners must approve the transaction.
 
-## Prerequisites
-
-- One of the multisig owners must have proposed the upgrade transaction using the `calldata` obtained from the deployment of the new implementation.
 
 ## Approve the Upgrade
 
@@ -16,11 +13,11 @@ To approve the upgrade transaction, you can follow the steps below:
 
 3. Click on the transaction and validate the data is correct. 
 
-   If you are upgrading the AlignedLayerServiceManager or the RegistryCoordinator, the called function must be `upgrade(address, address)`.
+   If you are upgrading the AlignedLayerServiceManager, the called function must be `upgrade(address, address)`.
 
    Else, if you are upgrading the BatcherPaymentService, the called function must be `upgradeTo(address)`.
 
-   Also check contract addresses are the ones you received from the deployment.
+   Verify the contracts addresses are correct.
 
    ![Check details](images/3_b_3_approve_1.png)