Skip to content

Commit a3ac9cb

Browse files
JulianVenturaJulian Ventura
andauthored
fix: replace error type logs to warn type logs on telemetry (#1500)
Co-authored-by: Julian Ventura <[email protected]>
1 parent c962068 commit a3ac9cb

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

aggregator/pkg/telemetry.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func (t *Telemetry) InitNewTrace(batchMerkleRoot [32]byte) {
6868
MerkleRoot: fmt.Sprintf("0x%s", hex.EncodeToString(batchMerkleRoot[:])),
6969
}
7070
if err := t.sendTelemetryMessage("/api/initTaskTrace", body); err != nil {
71-
t.logger.Error("[Telemetry] Error in InitNewTrace", "error", err)
71+
t.logger.Warn("[Telemetry] Error in InitNewTrace", "error", err)
7272
}
7373
}
7474

@@ -78,7 +78,7 @@ func (t *Telemetry) LogOperatorResponse(batchMerkleRoot [32]byte, operatorId [32
7878
OperatorId: fmt.Sprintf("0x%s", hex.EncodeToString(operatorId[:])),
7979
}
8080
if err := t.sendTelemetryMessage("/api/operatorResponse", body); err != nil {
81-
t.logger.Error("[Telemetry] Error in LogOperatorResponse", "error", err)
81+
t.logger.Warn("[Telemetry] Error in LogOperatorResponse", "error", err)
8282
}
8383
}
8484

@@ -87,7 +87,7 @@ func (t *Telemetry) LogQuorumReached(batchMerkleRoot [32]byte) {
8787
MerkleRoot: fmt.Sprintf("0x%s", hex.EncodeToString(batchMerkleRoot[:])),
8888
}
8989
if err := t.sendTelemetryMessage("/api/quorumReached", body); err != nil {
90-
t.logger.Error("[Telemetry] Error in LogQuorumReached", "error", err)
90+
t.logger.Warn("[Telemetry] Error in LogQuorumReached", "error", err)
9191
}
9292
}
9393

@@ -97,7 +97,7 @@ func (t *Telemetry) LogTaskError(batchMerkleRoot [32]byte, taskError error) {
9797
TaskError: taskError.Error(),
9898
}
9999
if err := t.sendTelemetryMessage("/api/taskError", body); err != nil {
100-
t.logger.Error("[Telemetry] Error in LogTaskError", "error", err)
100+
t.logger.Warn("[Telemetry] Error in LogTaskError", "error", err)
101101
}
102102
}
103103

@@ -107,7 +107,7 @@ func (t *Telemetry) BumpedTaskGasPrice(batchMerkleRoot [32]byte, bumpedGasPrice
107107
BumpedGasPrice: bumpedGasPrice,
108108
}
109109
if err := t.sendTelemetryMessage("/api/aggregatorTaskGasPriceBump", body); err != nil {
110-
t.logger.Error("[Telemetry] Error in LogOperatorResponse", "error", err)
110+
t.logger.Warn("[Telemetry] Error in LogOperatorResponse", "error", err)
111111
}
112112
}
113113

@@ -117,7 +117,7 @@ func (t *Telemetry) TaskSentToEthereum(batchMerkleRoot [32]byte, txHash string)
117117
TxHash: txHash,
118118
}
119119
if err := t.sendTelemetryMessage("/api/aggregatorTaskSent", body); err != nil {
120-
t.logger.Error("[Telemetry] Error in TaskSentToEthereum", "error", err)
120+
t.logger.Warn("[Telemetry] Error in TaskSentToEthereum", "error", err)
121121
}
122122
}
123123

@@ -129,15 +129,15 @@ func (t *Telemetry) FinishTrace(batchMerkleRoot [32]byte) {
129129
MerkleRoot: fmt.Sprintf("0x%s", hex.EncodeToString(batchMerkleRoot[:])),
130130
}
131131
if err := t.sendTelemetryMessage("/api/finishTaskTrace", body); err != nil {
132-
t.logger.Error("[Telemetry] Error in FinishTrace", "error", err)
132+
t.logger.Warn("[Telemetry] Error in FinishTrace", "error", err)
133133
}
134134
}()
135135
}
136136

137137
func (t *Telemetry) sendTelemetryMessage(endpoint string, message interface{}) error {
138138
encodedBody, err := json.Marshal(message)
139139
if err != nil {
140-
t.logger.Error("[Telemetry] Error marshalling JSON", "error", err)
140+
t.logger.Warn("[Telemetry] Error marshalling JSON", "error", err)
141141
return fmt.Errorf("error marshalling JSON: %w", err)
142142
}
143143

@@ -147,14 +147,14 @@ func (t *Telemetry) sendTelemetryMessage(endpoint string, message interface{}) e
147147

148148
resp, err := t.client.Post(fullURL.String(), "application/json", bytes.NewBuffer(encodedBody))
149149
if err != nil {
150-
t.logger.Error("[Telemetry] Error sending POST request", "error", err)
150+
t.logger.Warn("[Telemetry] Error sending POST request", "error", err)
151151
return fmt.Errorf("error making POST request: %w", err)
152152
}
153153
defer resp.Body.Close()
154154

155155
respBody, err := io.ReadAll(resp.Body)
156156
if err != nil {
157-
t.logger.Error("[Telemetry] Error reading response body", "error", err)
157+
t.logger.Warn("[Telemetry] Error reading response body", "error", err)
158158
return fmt.Errorf("error reading response body: %w", err)
159159
}
160160

batcher/aligned-batcher/src/lib.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,7 +1253,7 @@ impl Batcher {
12531253
.init_task_trace(&hex::encode(batch_merkle_tree.root))
12541254
.await
12551255
{
1256-
error!("Failed to initialize task trace on telemetry: {:?}", e);
1256+
warn!("Failed to initialize task trace on telemetry: {:?}", e);
12571257
}
12581258

12591259
if let Err(e) = self
@@ -1272,7 +1272,7 @@ impl Batcher {
12721272
.task_creation_failed(&hex::encode(batch_merkle_tree.root), &reason)
12731273
.await
12741274
{
1275-
error!("Failed to send task status to telemetry: {:?}", e);
1275+
warn!("Failed to send task status to telemetry: {:?}", e);
12761276
}
12771277
for entry in finalized_batch.into_iter() {
12781278
if let Some(ws_sink) = entry.messaging_sink {
@@ -1396,7 +1396,7 @@ impl Batcher {
13961396
.task_uploaded_to_s3(&batch_merkle_root_hex)
13971397
.await
13981398
{
1399-
error!("Failed to send task status to telemetry: {:?}", e);
1399+
warn!("Failed to send task status to telemetry: {:?}", e);
14001400
};
14011401
info!("Batch sent to S3 with name: {}", file_name);
14021402

@@ -1439,7 +1439,7 @@ impl Batcher {
14391439
)
14401440
.await
14411441
{
1442-
error!("Failed to send task status to telemetry: {:?}", e);
1442+
warn!("Failed to send task status to telemetry: {:?}", e);
14431443
};
14441444

14451445
match self
@@ -1504,7 +1504,7 @@ impl Batcher {
15041504
.task_sent(&hex::encode(batch_merkle_root), receipt.transaction_hash)
15051505
.await
15061506
{
1507-
error!("Failed to send task status to telemetry: {:?}", e);
1507+
warn!("Failed to send task status to telemetry: {:?}", e);
15081508
}
15091509
Ok(receipt)
15101510
}

0 commit comments

Comments
 (0)