refactor: centralize proving system id constant

Author: MarcosNicolau

aggregation_mode/aggregation_programs/risc0/src/lib.rs

@@ -2,6 +2,8 @@ use lambdaworks_crypto::merkle_tree::traits::IsMerkleTreeBackend;
 use serde::{Deserialize, Serialize};
 use tiny_keccak::{Hasher, Keccak};
 
+const RISC0_PROVING_SYSTEM_ID: u8 = 1;
+
 #[derive(Serialize, Deserialize)]
 pub struct Risc0ImageIdAndPubInputs {
     pub image_id: [u8; 32],
@@ -11,7 +13,7 @@ pub struct Risc0ImageIdAndPubInputs {
 impl Risc0ImageIdAndPubInputs {
     pub fn commitment(&self) -> [u8; 32] {
         let mut hasher = Keccak::v256();
-        hasher.update(&[1u8]);
+        hasher.update(&[RISC0_PROVING_SYSTEM_ID]);
         for &word in &self.image_id {
             hasher.update(&word.to_be_bytes());
         }

aggregation_mode/aggregation_programs/sp1/src/lib.rs

@@ -2,6 +2,8 @@ use lambdaworks_crypto::merkle_tree::traits::IsMerkleTreeBackend;
 use serde::{Deserialize, Serialize};
 use sha3::{Digest, Keccak256};
 
+const SP1_PROVING_SYSTEM_ID: u8 = 0;
+
 #[derive(Serialize, Deserialize)]
 pub struct SP1VkAndPubInputs {
     pub vk: [u32; 8],
@@ -11,7 +13,7 @@ pub struct SP1VkAndPubInputs {
 impl SP1VkAndPubInputs {
     pub fn commitment(&self) -> [u8; 32] {
         let mut hasher = Keccak256::new();
-        hasher.update(&[0u8]);
+        hasher.update(&[SP1_PROVING_SYSTEM_ID]);
         for &word in &self.vk {
             hasher.update(word.to_be_bytes());
         }

aggregation_mode/src/aggregators/risc0_aggregator.rs

@@ -1,5 +1,6 @@
 include!(concat!(env!("OUT_DIR"), "/methods.rs"));
 
+use aligned_sdk::aggregation_layer::RISC0_PROVING_SYSTEM_ID;
 use risc0_zkvm::{default_prover, ExecutorEnv, ProverOpts, Receipt};
 use sha3::{Digest, Keccak256};
 
@@ -80,7 +81,7 @@ pub const RISC0_CHUNK_AGGREGATOR_PROGRAM_ID_BYTES: [u8; 32] = {
 impl Risc0ProofReceiptAndImageId {
     pub fn hash_image_id_and_public_inputs(&self) -> [u8; 32] {
         let mut hasher = Keccak256::new();
-        hasher.update(&[1u8]);
+        hasher.update(&[RISC0_PROVING_SYSTEM_ID]);
         hasher.update(self.image_id);
         hasher.update(self.public_inputs());
         hasher.finalize().into()

aggregation_mode/src/aggregators/sp1_aggregator.rs

@@ -1,5 +1,6 @@
 use std::sync::LazyLock;
 
+use aligned_sdk::aggregation_layer::SP1_PROVING_SYSTEM_ID;
 use alloy::primitives::Keccak256;
 use sp1_aggregation_program::SP1VkAndPubInputs;
 #[cfg(feature = "prove")]
@@ -63,7 +64,7 @@ impl SP1ProofWithPubValuesAndElf {
 
     pub fn hash_vk_and_pub_inputs(&self) -> [u8; 32] {
         let mut hasher = Keccak256::new();
-        hasher.update(&[0u8]);
+        hasher.update(&[SP1_PROVING_SYSTEM_ID]);
         let vk_bytes = &self.vk.hash_bytes();
         hasher.update(vk_bytes);
         hasher.update(self.proof_with_pub_values.public_values.as_slice());

crates/sdk/src/aggregation_layer/mod.rs

@@ -3,7 +3,10 @@ mod helpers;
 mod types;
 
 // Makes only the two types on this use public
-pub use types::{AggregationModeVerificationData, ProofVerificationAggModeError};
+pub use types::{
+    AggregationModeVerificationData, ProofVerificationAggModeError, RISC0_PROVING_SYSTEM_ID,
+    SP1_PROVING_SYSTEM_ID,
+};
 
 use crate::{
     common::types::Network, eth::aligned_proof_agg_service::aligned_proof_aggregation_service,

crates/sdk/src/aggregation_layer/types.rs

@@ -3,6 +3,9 @@ use sha3::{Digest, Keccak256};
 
 use crate::beacon::BeaconClientError;
 
+pub const SP1_PROVING_SYSTEM_ID: u8 = 0;
+pub const RISC0_PROVING_SYSTEM_ID: u8 = 1;
+
 #[derive(Debug)]
 pub enum AggregationModeVerificationData {
     SP1 {
@@ -32,8 +35,8 @@ impl AggregationModeVerificationData {
 
     pub fn proving_system_id(&self) -> u8 {
         match self {
-            Self::SP1 { .. } => 0u8,
-            Self::Risc0 { .. } => 1u8,
+            Self::SP1 { .. } => SP1_PROVING_SYSTEM_ID,
+            Self::Risc0 { .. } => RISC0_PROVING_SYSTEM_ID,
         }
     }