julian's comments

Author: PatStiles

batcher/aligned-batcher/src/lib.rs

@@ -628,7 +628,6 @@ impl Batcher {
                 return Ok(());
             }
 
-            // If there is one invalid proof we send message with one out of batch and send rejected one.
             if !zk_utils::verify(verification_data).await {
                 error!("Invalid proof detected. Verification failed");
                 send_message(
@@ -661,7 +660,7 @@ impl Batcher {
                 // last_valid_nonce = client_msg.verification_data.nonce - 1.
                 SubmitProofResponseMessage::InsufficientBalance(
                     addr,
-                    nonced_verification_data.nonce,
+                    nonced_verification_data.nonce - 1,
                 ),
             )
             .await;

batcher/aligned-sdk/src/communication/messaging.rs

@@ -127,17 +127,8 @@ pub async fn receive(
             Ok(data) => data,
             Err(e) => {
                 warn!("Error while handling batcher response: {:?}", e);
-                // In the case of submitting multiple proofs we can have an multiple proofs be submitted but there
-                // insufficient balance we still want to read and return the `batch_inclusion_data` of the proofs that were approved.
-                // `last_valid_nonce` corresponds to the nonce of the proof that triggered InsufficientBalance.
-                // Therefore the other proofs are in order and we set the last_proof_nonce to the nonce of the InsufficientBalance.
                 if let SubmitError::InsufficientBalance(_, last_valid_nonce) = e {
                     aligned_submitted_data.push(Err(e));
-                    // last_valid_nonce = last_nonce - 1. In the case
-                    info!("last_proof_nonce: {}", last_proof_nonce);
-                    info!("last_valid_nonce: {}", last_valid_nonce);
-                    // In the case all proofs are insufficient balance we go over them.
-                    //last_proof_nonce -= U256::from(1);
                     if last_valid_nonce < last_proof_nonce {
                         last_proof_nonce = last_valid_nonce;
                     }