fix: accumulated aggregator cost panels (#1669)

Co-authored-by: Marcos Nicolau <[email protected]>

Author: avilagaston9

Makefile

@@ -557,7 +557,13 @@ generate_groth16_ineq_proof: ## Run the gnark_plonk_bn254_script
 	@go run scripts/test_files/gnark_groth16_bn254_infinite_script/cmd/main.go 1
 
 __METRICS__:
-# Prometheus and graphana
+# Prometheus and Grafana
+metrics_remove_containers:
+	@docker stop prometheus grafana
+	@docker rm prometheus grafana
+metrics_clean_db: metrics_remove_containers
+	@docker volume rm aligned_layer_grafana_data aligned_layer_prometheus_data
+
 run_metrics: ## Run metrics using metrics-docker-compose.yaml
 	@echo "Running metrics..."
 	@docker compose -f metrics-docker-compose.yaml up

core/chainio/avs_writer.go

@@ -150,7 +150,7 @@ func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMe
 				if receipt == nil {
 					receipt, _ = w.ClientFallback.TransactionReceipt(context.Background(), tx.Hash())
 					if receipt != nil {
-						w.updateAggregatorGasCostMetrics(tx, batchIdentifierHash)
+						w.updateAggregatorGasCostMetrics(receipt, batchIdentifierHash)
 						return receipt, nil
 					}
 				}
@@ -185,7 +185,7 @@ func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMe
 		w.logger.Infof("Transaction sent, waiting for receipt", "merkle root", batchMerkleRootHashString)
 		receipt, err := utils.WaitForTransactionReceiptRetryable(w.Client, w.ClientFallback, realTx.Hash(), retry.WaitForTxRetryParams(timeToWaitBeforeBump))
 		if receipt != nil {
-			w.updateAggregatorGasCostMetrics(realTx, batchIdentifierHash)
+			w.updateAggregatorGasCostMetrics(receipt, batchIdentifierHash)
 			return receipt, nil
 		}
 
@@ -209,15 +209,14 @@ func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMe
 // Calculates the transaction cost from the receipt and updates the total amount paid by the aggregator metric
 // Then, it compares that tx cost with the batcher respondToTaskFeeLimit.
 // If the tx cost was higher, it means the aggregator has paid the difference for the batcher (txCost - respondToTaskFeeLimit) and so metrics are updated accordingly.
-func (w *AvsWriter) updateAggregatorGasCostMetrics(tx *types.Transaction, batchIdentifierHash [32]byte) {
+func (w *AvsWriter) updateAggregatorGasCostMetrics(receipt *types.Receipt, batchIdentifierHash [32]byte) {
 	batchState, err := w.BatchesStateRetryable(&bind.CallOpts{}, batchIdentifierHash, retry.NetworkRetryParams())
 	if err != nil {
 		return
 	}
 	respondToTaskFeeLimit := batchState.RespondToTaskFeeLimit
 
-	// NOTE we are not using tx.Cost() because tx.Cost() includes tx.Value()
-	txCost := new(big.Int).Mul(big.NewInt(int64(tx.Gas())), tx.GasPrice())
+	txCost := new(big.Int).Mul(big.NewInt(int64(receipt.GasUsed)), receipt.EffectiveGasPrice)
 
 	txCostInEth := utils.WeiToEth(txCost)
 	w.metrics.AddAggregatorGasCostPaidTotal(txCostInEth)