fix: unrecoverable errs

Author: MarcosNicolau

core/chainio/avs_writer.go

@@ -15,6 +15,7 @@ import (
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/types"
 	servicemanager "github.com/yetanotherco/aligned_layer/contracts/bindings/AlignedLayerServiceManager"
+	connection "github.com/yetanotherco/aligned_layer/core"
 	"github.com/yetanotherco/aligned_layer/core/config"
 	"github.com/yetanotherco/aligned_layer/core/utils"
 )
@@ -100,16 +101,19 @@ func (w *AvsWriter) SendAggregatedResponse(batchIdentifierHash [32]byte, batchMe
 		err = w.checkRespondToTaskFeeLimit(tx, txOpts, batchIdentifierHash, senderAddress)
 
 		if err != nil {
-			return nil, err
+			return nil, connection.PermanentError{Inner: err}
 		}
 
 		tx, err = w.AvsContractBindings.ServiceManager.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature)
 		if err != nil {
 			// Retry with fallback
 			tx, err = w.AvsContractBindings.ServiceManagerFallback.RespondToTaskV2(&txOpts, batchMerkleRoot, senderAddress, nonSignerStakesAndSignature)
-			return tx, err
+			if err != nil {
+				return nil, connection.PermanentError{Inner: err}
+			}
+			return tx, nil
 		}
-		return tx, err
+		return tx, nil
 	}
 
 	return utils.SendTransactionWithInfiniteRetryAndBumpingGasPrice(executeTransaction, w.Client, tx.GasPrice())

core/utils/eth_client_utils.go

@@ -61,7 +61,7 @@ func CalculateGasPriceBumpBasedOnRetry(currentGasPrice *big.Int, iteration int)
 
 // Sends a transaction and waits for the receipt for three blocks, if not received
 // it will try again bumping the gas price based on `CalculateGasPriceBumpBasedOnRetry`
-// and pass it to beforeTransaction and executeTransaction (make sure you update the txOpts with the new price)
+// and pass it to executeTransaction (make sure you update the txOpts with the new gasPrice)
 // This process happens indefinitely until we get the receipt or the receipt status is an err.
 func SendTransactionWithInfiniteRetryAndBumpingGasPrice(executeTransaction func(*big.Int) (*types.Transaction, error), client eth.InstrumentedClient, baseGasPrice *big.Int) (*types.Receipt, error) {
 	i := 0