refactor: wei to eth conversion

Author: MarcosNicolau

core/chainio/avs_writer.go

@@ -134,10 +134,10 @@ func (w *AvsWriter) checkRespondToTaskFeeLimit(tx *types.Transaction, txOpts bin
 
 	if respondToTaskFeeLimit.Cmp(simulatedCost) < 0 {
 		aggregatorDifferenceToPay := new(big.Int).Sub(simulatedCost, respondToTaskFeeLimit)
-		aggregatorDifferenceToPayInEth, _ := utils.WeiToEth(aggregatorDifferenceToPay).Float64()
+		aggregatorDifferenceToPayInEth := utils.WeiToEth(aggregatorDifferenceToPay)
 		w.metrics.AddAggregatorGasPaidForBatcher(aggregatorDifferenceToPayInEth)
 		w.metrics.IncAggregatorPaidForBatcher()
-		w.logger.Warn("cost of transaction is higher than Batch.RespondToTaskFeeLimit, aggregator will pay the for the difference, aprox: %v", aggregatorDifferenceToPay)
+		w.logger.Warnf("cost of transaction is higher than Batch.RespondToTaskFeeLimit, aggregator will pay the for the difference, aprox: %vethers", aggregatorDifferenceToPayInEth)
 	}
 
 	return w.compareBalances(respondToTaskFeeLimit, aggregatorAddress, senderAddress)

core/utils/eth_client_utils.go

@@ -44,8 +44,12 @@ func BytesToQuorumThresholdPercentages(quorumThresholdPercentagesBytes []byte) e
 	return quorumThresholdPercentages
 }
 
-func WeiToEth(wei *big.Int) *big.Int {
-	weiToEth := new(big.Int).SetInt64(1e18)
+func WeiToEth(wei *big.Int) float64 {
+	weiToEth := new(big.Float).SetFloat64(1e18)
+	weiFloat := new(big.Float).SetInt(wei)
 
-	return new(big.Int).Quo(wei, weiToEth)
+	result := new(big.Float).Quo(weiFloat, weiToEth)
+	eth, _ := result.Float64()
+
+	return eth
 }