refactor: provess_batcher_response() and verify_proof_inclusion()

Author: uri-99

batcher/aligned-sdk/src/communication/batch.rs

@@ -4,8 +4,7 @@ use crate::{
     core::{
         errors,
         types::{
-            AlignedVerificationData, BatchInclusionData, Network, VerificationCommitmentBatch,
-            VerificationDataCommitment,
+            AlignedVerificationData, BatchInclusionData, Network, VerificationCommitmentBatch, VerificationDataCommitment
         },
     },
     sdk::is_proof_verified,
@@ -14,26 +13,27 @@ use crate::{
 const RETRIES: u64 = 10;
 const TIME_BETWEEN_RETRIES: u64 = 10;
 
-pub fn handle_batch_inclusion_data(
+pub fn process_batcher_response(
     batch_inclusion_data: BatchInclusionData,
-    aligned_verification_data: &mut Vec<AlignedVerificationData>,
     verification_data_commitment: VerificationDataCommitment,
-) -> Result<(), errors::SubmitError> {
+) -> Result<AlignedVerificationData, errors::SubmitError> {
     debug!("Received response from batcher");
     debug!(
         "Batch merkle root: {}",
         hex::encode(batch_inclusion_data.batch_merkle_root)
     );
     debug!("Index in batch: {}", batch_inclusion_data.index_in_batch);
 
-    if verify_response(&verification_data_commitment, &batch_inclusion_data) {
-        aligned_verification_data.push(AlignedVerificationData::new(
-            &verification_data_commitment,
-            &batch_inclusion_data,
-        ));
+    if verify_proof_inclusion(&verification_data_commitment, &batch_inclusion_data) {
+        Ok(
+            AlignedVerificationData::new(
+                &verification_data_commitment,
+                &batch_inclusion_data,
+            )
+        )
+    } else {
+        Err(errors::SubmitError::InvalidProofInclusionData)
     }
-
-    Ok(())
 }
 
 pub async fn await_batch_verification(
@@ -60,7 +60,7 @@ pub async fn await_batch_verification(
     })
 }
 
-fn verify_response(
+fn verify_proof_inclusion(
     verification_data_commitment: &VerificationDataCommitment,
     batch_inclusion_data: &BatchInclusionData,
 ) -> bool {