feat(aggregation): have constant costs proof sending (#2179)

Co-authored-by: Marcos Nicolau <[email protected]>

Author: maximopalopoli

Makefile

@@ -252,6 +252,9 @@ proof_aggregator_start_dev: is_aggregator_set reset_last_aggregated_block ./aggr
 proof_aggregator_start_dev_ethereum_package: is_aggregator_set reset_last_aggregated_block ./aggregation_mode/target/release/proof_aggregator_dev ## Starts proof aggregator with mock proofs (DEV mode) in ethereum package. Parameters: AGGREGATOR=<sp1|risc0>
 	AGGREGATOR=$(AGGREGATOR) RISC0_DEV_MODE=1 ./aggregation_mode/target/release/proof_aggregator_dev config-files/config-proof-aggregator-mock-ethereum-package.yaml
 
+proof_aggregator_test_without_compiling_agg_programs:
+	cd aggregation_mode && SKIP_AGG_PROGRAMS_BUILD=1 cargo test -p proof_aggregator --tests -- --nocapture
+
 ### All CPU proof aggregator receipts
 ./aggregation_mode/target/release/proof_aggregator_cpu: $(AGGREGATION_MODE_SOURCES)
 	AGGREGATOR=$(AGGREGATOR) cargo build --features prove --manifest-path ./aggregation_mode/Cargo.toml --release --bin proof_aggregator_cpu

aggregation_mode/proof_aggregator/build.rs

@@ -1,8 +1,32 @@
 use risc0_build::{DockerOptionsBuilder, GuestOptionsBuilder};
 use std::collections::HashMap;
+use std::path::PathBuf;
+
+// This allows us to skip the guest build in CI or local environments where it's not needed (reducing the build time)
+// Note: To use this flag, the aggregation programs should be already compiled, otherwise the compilation will be done anyway.
+fn should_skip_build() -> bool {
+    if std::env::var("SKIP_AGG_PROGRAMS_BUILD")
+        .map(|v| v == "1")
+        .unwrap_or(false)
+    {
+        let out_dir = std::env::var("OUT_DIR").unwrap();
+        let methods_path = PathBuf::from(out_dir).join("methods.rs");
+
+        methods_path.exists()
+    } else {
+        false
+    }
+}
 
 // Reference: https://docs.succinct.xyz/docs/sp1/writing-programs/compiling#advanced-build-options-1
 fn main() {
+    if should_skip_build() {
+        println!("cargo:warning=SKIP_AGG_PROGRAMS_BUILD=1: methods.rs already exists, skipping aggregation programs build");
+        return;
+    } else {
+        println!("cargo:warning=SKIP_AGG_PROGRAMS_BUILD=1 set, but path does not exist, running full build");
+    }
+
     sp1_build::build_program_with_args("./aggregation_programs/sp1", {
         sp1_build::BuildArgs {
             output_directory: Some("./aggregation_programs/sp1/elf".to_string()),

aggregation_mode/proof_aggregator/src/backend/config.rs

@@ -23,8 +23,9 @@ pub struct Config {
     pub ecdsa: ECDSAConfig,
     pub proofs_per_chunk: u16,
     pub total_proofs_limit: u16,
-    pub sp1_chunk_aggregator_vk_hash: String,
     pub risc0_chunk_aggregator_image_id: String,
+    pub sp1_chunk_aggregator_vk_hash: String,
+    pub monthly_budget_eth: f64,
 }
 
 impl Config {

aggregation_mode/proof_aggregator/src/backend/fetcher.rs

@@ -33,6 +33,25 @@ pub struct ProofsFetcher {
 }
 
 impl ProofsFetcher {
+    #[cfg(test)]
+    pub fn new_for_testing(config: &Config) -> Self {
+        let rpc_url = config.eth_rpc_url.parse().expect("RPC URL should be valid");
+        let rpc_provider = ProviderBuilder::new().connect_http(rpc_url);
+        let aligned_service_manager = AlignedLayerServiceManager::new(
+            Address::from_str(&config.aligned_service_manager_address)
+                .expect("AlignedProofAggregationService address should be valid"),
+            rpc_provider.clone(),
+        );
+
+        let last_aggregated_block = 0;
+
+        Self {
+            rpc_provider,
+            aligned_service_manager,
+            last_aggregated_block,
+        }
+    }
+
     pub fn new(config: &Config) -> Self {
         let rpc_url = config.eth_rpc_url.parse().expect("RPC URL should be valid");
         let rpc_provider = ProviderBuilder::new().connect_http(rpc_url);