feat(contract): withdraw_from_service_manager in BatcherPaymentService.sol (#1772)

Co-authored-by: JuArce <[email protected]>
Co-authored-by: MauroFab <[email protected]>

Author: 3 people

contracts/script/output/devnet/batcher_deployment_output.json

@@ -0,0 +1,6 @@
+{
+  "addresses": {
+    "batcherPaymentService": "0x7bc06c482DEAd17c0e297aFbC32f6e63d3846650",
+    "batcherPaymentServiceImplementation": "0x7969c5eD335650692Bc04293B07F5BF2e7A673C0"
+  }
+}

contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json

@@ -75,12 +75,23 @@ contract BatcherPaymentService is
         alignedLayerServiceManager = _alignedLayerServiceManager;
         batcherWallet = _batcherWallet;
     }
-
+    
     // PAYABLE FUNCTIONS
+    /**
+     * @notice Fallback function to receive ETH payments
+     * @dev This function handles two scenarios:
+     *      1. Direct user deposits: Updates the user's balance and emits an event
+     *      2. Batcher withdrawals from ServiceManager: Ignores balance updates since they don't apply
+     */
+
     receive() external payable {
-        userData[msg.sender].balance += msg.value;
-        userData[msg.sender].unlockBlockTime = 0;
-        emit PaymentReceived(msg.sender, msg.value);
+        // Skip balance updates when receiving funds from ServiceManager withdrawals
+        if (msg.sender != address(alignedLayerServiceManager)) { 
+            // Only update balances for direct user deposits
+            userData[msg.sender].balance += msg.value;
+            userData[msg.sender].unlockBlockTime = 0;
+            emit PaymentReceived(msg.sender, msg.value);
+        }
     }
 
     // PUBLIC FUNCTIONS
@@ -178,6 +189,17 @@ contract BatcherPaymentService is
         emit FundsWithdrawn(msg.sender, amount);
     }
 
+
+    function withdrawFromServiceManager(
+        uint256 amount,
+        address withdrawAddress
+    ) public payable onlyOwner {
+        alignedLayerServiceManager.withdraw(amount); // reverts if InsufficientBalance
+        // money is now in this contract
+        // we transfer it to the withdraw address
+        payable(withdrawAddress).transfer(amount); // non-reentrant since .transfer() has low gas limit.
+    }
+
     function pause() public onlyOwner {
         _pause();
     }