Check if the verifier type matches the one received by param on deleteProgramId

Author: maximopalopoli

contracts/src/core/AlignedProofAggregationService.sol

@@ -194,8 +194,12 @@ contract AlignedProofAggregationService is
     function deleteProgramId(bytes32 programId, IAlignedProofAggregationService.VerifierType verifierType) external onlyOwner validVerifierType(verifierType) {
         // Preserve the verifier type so we can emit it with the event
         uint8 verifierTypeRaw = programIds[programId];
+        uint8 rawReceivedVerifierType = uint8(verifierType);
 
-        // TODO: Check if the verifier type matches the one received by param
+        // Check if the obtained verifier type matches the one received by param
+        if (verifierTypeRaw != rawReceivedVerifierType) {
+            revert IAlignedProofAggregationService.VerifierTypeMismatch(verifierTypeRaw, rawReceivedVerifierType);
+        }
 
         delete programIds[programId];
         emit ProgramIdDeleted(programId, IAlignedProofAggregationService.VerifierType(verifierTypeRaw));

contracts/src/core/IAlignedProofAggregationService.sol

@@ -59,6 +59,8 @@ interface IAlignedProofAggregationService {
 
     error InvalidVerifierType(uint8 actual);
 
+    error VerifierTypeMismatch(uint8 expected, uint8 received);
+
     enum VerifierType {
         INVALID,  // If a given program does not exist in the `programId` map, it defaults to 0. This prevents non-existing keys to be considered valid in case SP1 or RISC0 were in this position
         SP1,