Merge pull request #1948 from dmitry-sinina/cdr_processor_http_auth_fix

cdr_processors: fix http basic auth support

Author: dmitry-sinina

app/lib/cdr_processor/processors/cdr_http_base.rb

@@ -81,7 +81,11 @@ def send_http_request(payload)
         else
           kwargs[:body] = http_body(payload)
         end
-        response = HTTPX.public_send(http_method, http_url, **kwargs)
+        client = HTTPX
+        if @params['auth_user'].present?
+          client = client.plugin(:basic_auth).basic_auth(@params['auth_user'], @params['auth_password'].to_s)
+        end
+        response = client.public_send(http_method, http_url, **kwargs)
         response.raise_for_status
         response
       end

config/cdr_processors.yml.distr

@@ -25,6 +25,8 @@ cdr_http:
   mail_subject: "Exception happened in CDR http"
   url: "http://example.com/api/cdrs"
   method: POST
+  # auth_user: user
+  # auth_password: password
   # may be an array:
   #  cdr_fields: [
   #                 'id', 'src_prefix_in', 'src_prefix_out', 'dst_prefix_in', 'dst_prefix_out', 'time_start',
@@ -64,6 +66,8 @@ cdr_clickhouse:
   mail_from: "yeti-cdr-billing@example.com"
   mail_subject: "Exception happened in CDR http"
   url: "http://clickhouse.example.com"
+  # auth_user: user
+  # auth_password: password
   clickhouse_db: main
   clickhouse_table: cdrs
   # may be an array:

spec/lib/cdr_processor/processors/cdr_clickhouse_spec.rb

@@ -83,6 +83,25 @@
     end
   end
 
+  context 'with basic auth credentials' do
+    let(:config) { super().merge(auth_user: 'yeti', auth_password: 'secret') }
+
+    let!(:stub_clickhouse_request) do
+      WebMock.stub_request(:post, config[:url])
+             .with(
+               query: expected_query,
+               body: expected_body,
+               headers: { 'Authorization' => "Basic #{Base64.strict_encode64('yeti:secret')}" }
+             )
+             .and_return(status: response_status, body: nil)
+    end
+
+    it 'sends request with basic auth header' do
+      subject
+      expect(stub_clickhouse_request).to have_been_requested
+    end
+  end
+
   context 'permit array attribute' do
     let(:config) { super().merge cdr_fields: %w[id local_tag] }
     let(:expected_body) do

spec/lib/cdr_processor/processors/cdr_http_batch_spec.rb

@@ -95,6 +95,16 @@
     end
   end
 
+  context 'with basic auth credentials' do
+    let(:config) { super().merge('auth_user' => 'yeti', 'auth_password' => 'secret') }
+
+    it 'sends request with basic auth header' do
+      subject
+      expect(WebMock).to have_requested(:post, config['url']).once
+                                                             .with(headers: { 'Authorization' => "Basic #{Base64.strict_encode64('yeti:secret')}" })
+    end
+  end
+
   context 'permit array attribute' do
     let(:cdr_fields) { ['id'] }
 

spec/lib/cdr_processor/processors/cdr_http_spec.rb

@@ -83,6 +83,16 @@
     end
   end
 
+  context 'with basic auth credentials' do
+    let(:config) { super().merge('auth_user' => 'yeti', 'auth_password' => 'secret') }
+
+    it 'sends requests with basic auth header' do
+      subject
+      expect(WebMock).to have_requested(:post, config['url']).times(2)
+                                                             .with(headers: { 'Authorization' => "Basic #{Base64.strict_encode64('yeti:secret')}" })
+    end
+  end
+
   context 'permit array attribute' do
     let(:cdr_fields) { ['id'] }