Skip to content

Commit 5d16cc0

Browse files
Merge pull request #1945 from dmitry-sinina/default_filter_by_date_fixes
fix default filter by date. refs #1630
2 parents 4114ed7 + 755214e commit 5d16cc0

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

app/admin/cdr/auth_logs.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@
77
config.batch_actions = false
88
config.sort_order = 'request_time_desc'
99

10-
with_default_params do
11-
params[:q] = { request_time_gteq_datetime_picker: 0.days.ago.beginning_of_day }
10+
with_default_params if: proc { |q: nil, **_| q.blank? || q[:request_time_gteq_datetime_picker].blank? } do
11+
params[:q] = params[:q]&.to_unsafe_h&.symbolize_keys || {}
12+
params[:q][:request_time_gteq_datetime_picker] = 0.days.ago.beginning_of_day
1213
'Only records from beginning of the day showed by default'
1314
end
1415

app/admin/cdr/cdrs.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@
1010

1111
decorate_with CdrDecorator
1212

13-
with_default_params do
14-
params[:q] = { time_start_gteq_datetime_picker: 0.days.ago.beginning_of_day }
13+
with_default_params if: proc { |q: nil, **_| q.blank? || q[:time_start_gteq_datetime_picker].blank? } do
14+
params[:q] = params[:q]&.to_unsafe_h&.symbolize_keys || {}
15+
params[:q][:time_start_gteq_datetime_picker] = 0.days.ago.beginning_of_day
1516
'Only CDRs started from beginning of the day showed by default'
1617
end
1718

app/admin/logs/api_logs.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
scope :all, default: true
1010
scope :failed, show_count: false
1111

12-
with_default_params do
13-
params[:q] = { created_at_gteq_datetime_picker: 0.days.ago.beginning_of_day } # only 1 last days by default
12+
with_default_params if: proc { |q: nil, **_| q.blank? || q[:created_at_gteq_datetime_picker].blank? } do
13+
params[:q] = params[:q]&.to_unsafe_h&.symbolize_keys || {}
14+
params[:q][:created_at_gteq_datetime_picker] = 0.days.ago.beginning_of_day
1415
'Only records from beginning of the day showed by default'
1516
end
1617

app/admin/logs/audit_log_items.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
filter :ip
1515
filter :txid
1616

17-
with_default_params do
18-
params[:q] = { created_at_gteq_datetime_picker: 0.days.ago.beginning_of_day } # only 1 last days by default
17+
with_default_params if: proc { |q: nil, **_| q.blank? || q[:created_at_gteq_datetime_picker].blank? } do
18+
params[:q] = params[:q]&.to_unsafe_h&.symbolize_keys || {}
19+
params[:q][:created_at_gteq_datetime_picker] = 0.days.ago.beginning_of_day
1920
'Only records from beginning of the day showed by default'
2021
end
2122

app/views/routing_simulation/_form.html.erb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<%= semantic_form_for dc, :url => '/routing_simulation', :method => :get do |form| %>
22
<%= form.semantic_errors *form.object.errors.attribute_names %>
33
<%= form.inputs do %>
4-
<%= form.input :auth_id, label:"Authorized gateway", collection: Gateway.where("incoming_auth_password is not null and allow_origination"), as: :select, include_blank: 'None', input_html: { class: 'tom-select' } %>
4+
<% auth_gw_collection = form.object.auth_id ? Gateway.where(id: form.object.auth_id) : [] %>
5+
<%= form.input :auth_id, label: "Authorized gateway", collection: auth_gw_collection, as: :select, include_blank: 'None', input_html: { class: 'tom-select-ajax', 'data-path': '/gateways/search?q[allow_origination_eq]=true&q[incoming_auth_password_not_null]=1' } %>
56
<%= form.input :transport_protocol_id, collection: Equipment::TransportProtocol.all, as: :select, include_blank: false %>
67
<%= form.input :interface, input_html: { value: form.object.interface || YetiConfig.routing_simulation_default_interface } %>
78
<%= form.input :remote_ip %>

0 commit comments

Comments
 (0)