Upgrade bincode from 1.x to 2.0.0-rc.3 (#3899)

- Updated bincode dependency to 2.0.0-rc.3 in yew and yew-agent packages
- Migrated from bincode::serialize/deserialize to bincode::serde::encode_to_vec/decode_from_slice
- Updated test expectations for changed base64 encoding format
- Used 2.0.0-rc.3 to maintain MSRV compatibility with Rust 1.78.0

Author: Madoshakalaka

Cargo.lock

@@ -17,7 +17,7 @@ wasm-bindgen = "0.2"
 js-sys = "0.3"
 pinned = "0.1.0"
 thiserror = "1.0.37"
-bincode = { version = "1.3.3" }
+bincode = { version = "2.0.0-rc.3", features = ["serde"] }
 wasm-bindgen-futures = "0.4"
 serde = { version = "1", features = ["derive"] }
 futures = "0.3"

packages/yew-agent/Cargo.toml

@@ -26,7 +26,8 @@ impl Codec for Bincode {
     where
         I: Serialize,
     {
-        let buf = bincode::serialize(&input).expect("can't serialize an worker message");
+        let buf = bincode::serde::encode_to_vec(&input, bincode::config::standard())
+            .expect("can't serialize an worker message");
         Uint8Array::from(buf.as_slice()).into()
     }
 
@@ -35,6 +36,8 @@ impl Codec for Bincode {
         O: for<'de> Deserialize<'de>,
     {
         let data = Uint8Array::from(input).to_vec();
-        bincode::deserialize(&data).expect("can't deserialize an worker message")
+        let (result, _) = bincode::serde::decode_from_slice(&data, bincode::config::standard())
+            .expect("can't deserialize an worker message");
+        result
     }
 }

packages/yew-agent/src/codec.rs

@@ -29,7 +29,7 @@ futures = { version = "0.3", default-features = false, features = ["std"] }
 html-escape = { version = "0.2.13", optional = true }
 implicit-clone = { version = "0.5", features = ["map"] }
 base64ct = { version = "1.6.0", features = ["std"], optional = true }
-bincode = { version = "1.3.3", optional = true }
+bincode = { version = "2.0.0-rc.3", optional = true, features = ["serde"] }
 serde = { version = "1", features = ["derive"] }
 tracing = "0.1.40"
 tokise = "0.2.0"

packages/yew/Cargo.toml

@@ -90,10 +90,15 @@ where
                                 .await
                                 .expect("failed to deserialize state");
 
-                            let (state, deps) =
-                                bincode::deserialize::<(Option<T>, Option<D>)>(&buf)
-                                    .map(|(state, deps)| (state.map(Rc::new), deps.map(Rc::new)))
-                                    .expect("failed to deserialize state");
+                            let ((state, deps), _) =
+                                bincode::serde::decode_from_slice::<(Option<T>, Option<D>), _>(
+                                    &buf,
+                                    bincode::config::standard(),
+                                )
+                                .map(|((state, deps), consumed)| {
+                                    ((state.map(Rc::new), deps.map(Rc::new)), consumed)
+                                })
+                                .expect("failed to deserialize state");
 
                             data.set((Ok((state, deps)), None));
                         });

packages/yew/src/functional/hooks/use_prepared_state/feat_hydration.rs

@@ -129,8 +129,11 @@ mod feat_any_hydration_ssr {
         fn prepare(&self) -> String {
             use base64ct::{Base64, Encoding};
 
-            let state = bincode::serialize(&(self.state.as_deref(), self.deps.as_deref()))
-                .expect("failed to prepare state");
+            let state = bincode::serde::encode_to_vec(
+                (self.state.as_deref(), self.deps.as_deref()),
+                bincode::config::standard(),
+            )
+            .expect("failed to prepare state");
 
             Base64::encode_string(&state)
         }

packages/yew/src/functional/hooks/use_prepared_state/mod.rs

@@ -30,8 +30,11 @@ where
         let f = self.state_fn.borrow_mut().take().unwrap();
         let state = f(self.deps.clone());
 
-        let state = bincode::serialize(&(Some(&state), Some(&*self.deps)))
-            .expect("failed to prepare state");
+        let state = bincode::serde::encode_to_vec(
+            (Some(&state), Some(&*self.deps)),
+            bincode::config::standard(),
+        )
+        .expect("failed to prepare state");
 
         Base64::encode_string(&state)
     }

packages/yew/src/functional/hooks/use_transitive_state/feat_ssr.rs

@@ -42,7 +42,7 @@ async fn use_prepared_state_works() {
 
     assert_eq!(
         s,
-        r#"<!--<[use_prepared_state::use_prepared_state_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_prepared_state::use_prepared_state_works::{{closure}}::Comp]>--><div>12345</div><script type="application/x-yew-comp-state">ATkwAAAB</script><!--</[use_prepared_state::use_prepared_state_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_prepared_state::use_prepared_state_works::{{closure}}::App]>-->"#
+        r#"<!--<[use_prepared_state::use_prepared_state_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_prepared_state::use_prepared_state_works::{{closure}}::Comp]>--><div>12345</div><script type="application/x-yew-comp-state">Afs5MAE=</script><!--</[use_prepared_state::use_prepared_state_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_prepared_state::use_prepared_state_works::{{closure}}::App]>-->"#
     );
 
     gloo::utils::document()
@@ -92,7 +92,7 @@ async fn use_prepared_state_with_suspension_works() {
 
     assert_eq!(
         s,
-        r#"<!--<[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::Comp]>--><div>12345</div><script type="application/x-yew-comp-state">ATkwAAAB</script><!--</[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::App]>-->"#
+        r#"<!--<[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::Comp]>--><div>12345</div><script type="application/x-yew-comp-state">Afs5MAE=</script><!--</[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_prepared_state::use_prepared_state_with_suspension_works::{{closure}}::App]>-->"#
     );
 
     gloo::utils::document()

packages/yew/tests/use_prepared_state.rs

@@ -42,7 +42,7 @@ async fn use_transitive_state_works() {
     assert_eq!(
         s,
         // div text content should be 0 but state should be 12345.
-        r#"<!--<[use_transitive_state::use_transitive_state_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_transitive_state::use_transitive_state_works::{{closure}}::Comp]>--><div>0</div><script type="application/x-yew-comp-state">ATkwAAAB</script><!--</[use_transitive_state::use_transitive_state_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_transitive_state::use_transitive_state_works::{{closure}}::App]>-->"#
+        r#"<!--<[use_transitive_state::use_transitive_state_works::{{closure}}::App]>--><!--<[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--<[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--<?>--><div><!--<[use_transitive_state::use_transitive_state_works::{{closure}}::Comp]>--><div>0</div><script type="application/x-yew-comp-state">Afs5MAE=</script><!--</[use_transitive_state::use_transitive_state_works::{{closure}}::Comp]>--></div><!--</?>--><!--</[yew::suspense::component::feat_csr_ssr::BaseSuspense]>--><!--</[yew::suspense::component::feat_csr_ssr::Suspense]>--><!--</[use_transitive_state::use_transitive_state_works::{{closure}}::App]>-->"#
     );
 
     gloo::utils::document()