concise diagnostics for missing props

Author: Madoshakalaka

.github/workflows/main-checks.yml

@@ -69,7 +69,7 @@ jobs:
       fail-fast: false
       matrix:
         toolchain:
-          - 1.76.0
+          - 1.78.0
           - stable
 
     steps:
@@ -120,7 +120,7 @@ jobs:
       fail-fast: false
       matrix:
         toolchain:
-          - 1.76.0
+          - 1.78.0
           - stable
           - nightly
 

packages/yew-agent-macro/Cargo.toml

@@ -2,7 +2,7 @@
 name = "yew-agent-macro"
 version = "0.2.0"
 edition = "2021"
-rust-version = "1.76.0"
+rust-version = "1.78.0"
 authors = ["Kaede Hoshikawa <futursolo@icloud.com>"]
 repository = "https://github.com/yewstack/yew"
 homepage = "https://yew.rs"

packages/yew-agent/Cargo.toml

@@ -9,7 +9,7 @@ edition = "2021"
 readme = "../../README.md"
 description = "Agents for Yew"
 license = "MIT OR Apache-2.0"
-rust-version = "1.76.0"
+rust-version = "1.78.0"
 
 [dependencies]
 yew = { version = "0.21.0", path = "../yew" }

packages/yew-macro/Cargo.toml

@@ -10,7 +10,7 @@ license = "MIT OR Apache-2.0"
 keywords = ["web", "wasm", "frontend", "webasm", "webassembly"]
 categories = ["gui", "web-programming", "wasm"]
 description = "A framework for making client-side single-page apps"
-rust-version = "1.76.0"
+rust-version = "1.78.0"
 
 [lib]
 proc-macro = true

packages/yew-macro/Makefile.toml

@@ -1,6 +1,6 @@
 [tasks.test]
 clear = true
-toolchain = "1.76.0"
+toolchain = "1.78.0"
 command = "cargo"
 # test target can be optionally specified like `cargo make test html_macro`,
 args = ["test", "${@}"]

packages/yew-macro/src/derive_props/builder.rs

@@ -127,6 +127,7 @@ impl PropsBuilder<'_> {
         quote! {
             #[automatically_derived]
             #( #extra_attrs )*
+            #[diagnostic::do_not_recommend]
             impl #builder_impl_generics #builder_name<#generic_args> #builder_where_clause {
                 #( #prop_fns )*
             }
@@ -142,11 +143,13 @@ impl PropsBuilder<'_> {
             #vis struct #check_all_props_name<How>(::std::marker::PhantomData<How>);
 
             #[automatically_derived]
+            #[diagnostic::do_not_recommend]
             impl<B, P, How> ::yew::html::HasProp<P, &dyn ::yew::html::HasProp<P, How>>
                 for #check_all_props_name<B>
                 where B: ::yew::html::HasProp<P, How> {}
 
             #[automatically_derived]
+            #[diagnostic::do_not_recommend]
             impl #check_impl_generics ::yew::html::HasAllProps<
                 #props_name #ty_generics ,
                 ( #( #check_args , )* ),

packages/yew-macro/src/derive_props/field.rs

@@ -245,9 +245,12 @@ impl PropFieldCheck<'_> {
             #vis struct #check_struct<How>(::std::marker::PhantomData<How>);
 
             #[automatically_derived]
+            #[diagnostic::do_not_recommend]
             impl<B> ::yew::html::HasProp< #prop_name_mod :: #prop_check_name, #check_struct<B>>
                 for #check_struct<B> {}
+
             #[automatically_derived]
+            #[diagnostic::do_not_recommend]
             impl<B, P, How> ::yew::html::HasProp<P, &dyn ::yew::html::HasProp<P, How>>
                 for #check_struct<B>
                 where B: ::yew::html::HasProp<P, How> {}

packages/yew-macro/tests/classes_macro/classes-fail.stderr

@@ -14,11 +14,11 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
  --> tests/classes_macro/classes-fail.rs:4:14
   |
 4 |     classes!(42);
-  |              ^^ the trait `From<{integer}>` is not implemented for `Classes`
+  |              ^^ the trait `From<{integer}>` is not implemented for `Classes`, which is required by `{integer}: Into<Classes>`
   |
   = help: the following other types implement trait `From<T>`:
-            <Classes as From<Cow<'static, str>>>
             <Classes as From<implicit_clone::unsync::string::IString>>
+            <Classes as From<Cow<'static, str>>>
             <Classes as From<Vec<T>>>
             <Classes as From<String>>
             <Classes as From<Option<T>>>
@@ -37,11 +37,11 @@ error[E0277]: the trait bound `Classes: From<{float}>` is not satisfied
  --> tests/classes_macro/classes-fail.rs:5:14
   |
 5 |     classes!(42.0);
-  |              ^^^^ the trait `From<{float}>` is not implemented for `Classes`
+  |              ^^^^ the trait `From<{float}>` is not implemented for `Classes`, which is required by `{float}: Into<Classes>`
   |
   = help: the following other types implement trait `From<T>`:
-            <Classes as From<Cow<'static, str>>>
             <Classes as From<implicit_clone::unsync::string::IString>>
+            <Classes as From<Cow<'static, str>>>
             <Classes as From<Vec<T>>>
             <Classes as From<String>>
             <Classes as From<Option<T>>>
@@ -62,12 +62,12 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
 9 |     classes!(vec![42]);
   |              ---^^^^^
   |              |
-  |              the trait `From<{integer}>` is not implemented for `Classes`
+  |              the trait `From<{integer}>` is not implemented for `Classes`, which is required by `Vec<{integer}>: Into<Classes>`
   |              required by a bound introduced by this call
   |
   = help: the following other types implement trait `From<T>`:
-            <Classes as From<Cow<'static, str>>>
             <Classes as From<implicit_clone::unsync::string::IString>>
+            <Classes as From<Cow<'static, str>>>
             <Classes as From<Vec<T>>>
             <Classes as From<String>>
             <Classes as From<Option<T>>>
@@ -89,11 +89,11 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
   --> tests/classes_macro/classes-fail.rs:13:14
    |
 13 |     classes!(some);
-   |              ^^^^ the trait `From<{integer}>` is not implemented for `Classes`
+   |              ^^^^ the trait `From<{integer}>` is not implemented for `Classes`, which is required by `Option<{integer}>: Into<Classes>`
    |
    = help: the following other types implement trait `From<T>`:
-             <Classes as From<Cow<'static, str>>>
              <Classes as From<implicit_clone::unsync::string::IString>>
+             <Classes as From<Cow<'static, str>>>
              <Classes as From<Vec<T>>>
              <Classes as From<String>>
              <Classes as From<Option<T>>>
@@ -115,11 +115,11 @@ error[E0277]: the trait bound `Classes: From<u32>` is not satisfied
   --> tests/classes_macro/classes-fail.rs:14:14
    |
 14 |     classes!(none);
-   |              ^^^^ the trait `From<u32>` is not implemented for `Classes`
+   |              ^^^^ the trait `From<u32>` is not implemented for `Classes`, which is required by `Option<u32>: Into<Classes>`
    |
    = help: the following other types implement trait `From<T>`:
-             <Classes as From<Cow<'static, str>>>
              <Classes as From<implicit_clone::unsync::string::IString>>
+             <Classes as From<Cow<'static, str>>>
              <Classes as From<Vec<T>>>
              <Classes as From<String>>
              <Classes as From<Option<T>>>
@@ -141,11 +141,11 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
   --> tests/classes_macro/classes-fail.rs:16:21
    |
 16 |     classes!("one", 42);
-   |                     ^^ the trait `From<{integer}>` is not implemented for `Classes`
+   |                     ^^ the trait `From<{integer}>` is not implemented for `Classes`, which is required by `{integer}: Into<Classes>`
    |
    = help: the following other types implement trait `From<T>`:
-             <Classes as From<Cow<'static, str>>>
              <Classes as From<implicit_clone::unsync::string::IString>>
+             <Classes as From<Cow<'static, str>>>
              <Classes as From<Vec<T>>>
              <Classes as From<String>>
              <Classes as From<Option<T>>>

packages/yew-macro/tests/classes_macro_test.rs

@@ -1,5 +1,5 @@
 #[allow(dead_code)]
-#[rustversion::attr(stable(1.76), test)]
+#[rustversion::attr(stable(1.78), test)]
 fn classes_macro() {
     let t = trybuild::TestCases::new();
     t.pass("tests/classes_macro/*-pass.rs");

packages/yew-macro/tests/derive_props/fail.stderr

@@ -61,22 +61,14 @@ help: consider annotating `Value` with `#[derive(PartialEq)]`
 9  |     struct Value;
    |
 
-error[E0277]: the trait bound `AssertAllProps: HasProp<t3::_Props::value, _>` is not satisfied
+error[E0277]: not all required properties have been provided
   --> tests/derive_props/fail.rs:35:24
    |
 35 |         ::yew::props!{ Props { } };
-   |                        ^^^^^ the trait `HasProp<t3::_Props::value, _>` is not implemented for `AssertAllProps`
-   |
-   = help: the following other types implement trait `HasProp<P, How>`:
-             <t1::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t2::HasPropsvalue<B> as HasProp<t2::_Props::value, t2::HasPropsvalue<B>>>
-             <t2::HasPropsvalue<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t2::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t3::HasPropsvalue<B> as HasProp<t3::_Props::value, t3::HasPropsvalue<B>>>
-             <t3::HasPropsvalue<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t3::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t4::HasPropsvalue<B> as HasProp<t4::_Props::value, t4::HasPropsvalue<B>>>
-           and $N others
+   |                        ^^^^^ missing required properties for this component
+   |
+   = help: the trait `HasProp<t3::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t3::PropsBuilder, _>`
+   = note: make sure all required properties are set before building the component
 note: required for `t3::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t3::Props, (_,)>`
   --> tests/derive_props/fail.rs:29:21
    |
@@ -93,22 +85,14 @@ note: required by a bound in `html::component::properties::__macro::PreBuild::<T
    |                    ^^^^^^^^^^^^^^^^^^^ required by this bound in `PreBuild::<Token, B>::build`
    = note: this error originates in the derive macro `Properties` (in Nightly builds, run with -Z macro-backtrace for more info)
 
-error[E0277]: the trait bound `AssertAllProps: HasProp<t4::_Props::value, _>` is not satisfied
+error[E0277]: not all required properties have been provided
   --> tests/derive_props/fail.rs:47:24
    |
 47 |         ::yew::props!{ Props { } };
-   |                        ^^^^^ the trait `HasProp<t4::_Props::value, _>` is not implemented for `AssertAllProps`
-   |
-   = help: the following other types implement trait `HasProp<P, How>`:
-             <t1::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t2::HasPropsvalue<B> as HasProp<t2::_Props::value, t2::HasPropsvalue<B>>>
-             <t2::HasPropsvalue<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t2::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t3::HasPropsvalue<B> as HasProp<t3::_Props::value, t3::HasPropsvalue<B>>>
-             <t3::HasPropsvalue<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t3::CheckPropsAll<B> as HasProp<P, &dyn HasProp<P, How>>>
-             <t4::HasPropsvalue<B> as HasProp<t4::_Props::value, t4::HasPropsvalue<B>>>
-           and $N others
+   |                        ^^^^^ missing required properties for this component
+   |
+   = help: the trait `HasProp<t4::_Props::value, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<t4::PropsBuilder, _>`
+   = note: make sure all required properties are set before building the component
 note: required for `t4::CheckPropsAll<AssertAllProps>` to implement `HasAllProps<t4::Props, (_,)>`
   --> tests/derive_props/fail.rs:41:21
    |
@@ -168,3 +152,11 @@ error[E0271]: expected `foo` to be a fn item that returns `String`, but it retur
     |
 note: required by a bound in `Option::<T>::unwrap_or_else`
    --> $RUST/core/src/option.rs
+
+warning: unused variable: `bar`
+   --> tests/derive_props/fail.rs:100:12
+    |
+100 |     fn foo(bar: i32) -> String {
+    |            ^^^ help: if this is intentional, prefix it with an underscore: `_bar`
+    |
+    = note: `#[warn(unused_variables)]` on by default