Merge pull request #15 from tisztamo/master

Fixed float deserialization when TypedArray.byteOffset is nonzero

Author: ygoe

msgpack-tests.js

@@ -12,6 +12,7 @@ function test() {
 	testData(new Date(0xfffffffff * 1000 + 50));
 	testData(new Date(-1));
 	testData(new Uint8Array([1, 2, 3, 200]));
+	testByteOffset()
 	logLine("<b>Expected to fail:</b>");
 	testData(new Uint32Array([1, 2, 3, 200000]));
 }	
@@ -95,6 +96,27 @@ function testData(data) {
 	logLine();
 }
 
+function testByteOffset() {
+	logLine("<span>Testing Typed Array byteOffset handling</span>");
+	const buf = new ArrayBuffer(10);
+	const arr0 = new Uint8Array(buf);
+	const arr1 = new Uint8Array(buf, 1);
+	for (let i = 0; i < arr0.length; i++) {
+		arr0[i] = 255;
+	}
+	for (let i = 0; i < arr1.length; i++) {
+		arr1[i] = 0;
+	}
+	arr1[0] = 0xcb;
+	if (msgpack.deserialize(arr1) === 0) {
+		logLine("<span style='color: green;'>Test passed.</span>");
+	}
+	else {
+		logLine("<span style='color: red;'>Test FAILED.</span>");
+	}
+	logLine();
+}
+
 // Runs several functions in a loop to measure the time spent.
 function benchmark() {
 	// Define the data to test with

msgpack.js

@@ -331,7 +331,7 @@
 		}
 
 		function readFloat(size) {
-			let view = new DataView(array.buffer, pos, size);
+			let view = new DataView(array.buffer, pos + array.byteOffset, size);
 			pos += size;
 			if (size === 4)
 				return view.getFloat32(0, false);