Skip to content

Commit 82e892d

Browse files
committed
Resolved code review comments
1 parent 593199c commit 82e892d

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

test/test.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12697,6 +12697,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) {
1269712697
{
1269812698
std::ofstream ofs(fname);
1269912699
ofs << content;
12700+
ASSERT_TRUE(ofs.good());
1270012701
}
1270112702

1270212703
Server svr;
@@ -12719,6 +12720,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) {
1271912720
EXPECT_EQ('W', etag[0]);
1272012721
EXPECT_EQ('/', etag[1]);
1272112722
EXPECT_EQ('"', etag[2]);
12723+
EXPECT_EQ('"', etag.back());
1272212724

1272312725
// Exact match: expect 304 Not Modified
1272412726
Headers h2 = {{"If-None-Match", etag}};
@@ -12758,6 +12760,7 @@ TEST(ETagTest, LastModifiedAndIfModifiedSince) {
1275812760
{
1275912761
std::ofstream ofs(fname);
1276012762
ofs << content;
12763+
ASSERT_TRUE(ofs.good());
1276112764
}
1276212765

1276312766
Server svr;
@@ -12859,6 +12862,7 @@ TEST(ETagTest, IfRangeWithETag) {
1285912862
{
1286012863
std::ofstream ofs(fname);
1286112864
ofs << content;
12865+
ASSERT_TRUE(ofs.good());
1286212866
}
1286312867

1286412868
Server svr;
@@ -12919,6 +12923,7 @@ TEST(ETagTest, IfRangeWithDate) {
1291912923
{
1292012924
std::ofstream ofs(fname);
1292112925
ofs << content;
12926+
ASSERT_TRUE(ofs.good());
1292212927
}
1292312928

1292412929
Server svr;

0 commit comments

Comments
 (0)