Skip to content

Commit df55652

Browse files
authored
update docs (cosmos#796)
1 parent f6ce772 commit df55652

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/migrations/v0.4.0_to_v0.5.0.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ These options can also be set via CLI flags:
207207

208208
##### Cosmos Mempool Max Transactions
209209

210-
A new flag `--mempool.max-txs` allows limiting the maximum number of transactions in the Cosmos mempool. Set to 0 or -1 for unbounded (default: 0).
210+
The --mempool.max-txs SDK flag is now actually ingested into the Cosmos mempool (`ExtMempool`) config inside `ExperimentalEVMMempool` (this was previously always a zeroed `int` value and could not be overridden). This allows limiting the maximum number of transactions in the Cosmos mempool. Set to -1 (disabled, no-op), 0 (unbounded), or positive integer. The [default value here](https://github.com/cosmos/evm/blob/f6ce772cd8dabfc5804aeb94ee21c63cc3d112fa/server/start.go#L189-L192) is `0`, which differs from the default SDK value of `-1`, since we want the mempool enabled by default.
211211

212212
The function signature for `NewExperimentalEVMMempool` also changed to add a cosmosPoolMaxTx field:
213213

server/start.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ which accepts a path for the resulting pprof file.
185185
cmd.Flags().Uint64(server.FlagMinRetainBlocks, 0, "Minimum block height offset during ABCI commit to prune CometBFT blocks")
186186
cmd.Flags().String(srvflags.AppDBBackend, "", "The type of database for application and snapshots databases")
187187

188-
cmd.Flags().Int32(server.FlagMempoolMaxTxs, 0, "The maximum number of transactions in the mempool")
188+
cmd.Flags().Int(server.FlagMempoolMaxTxs, 0, "The maximum number of transactions in the mempool")
189189
// explicitly override the app.toml default value, as normally config file takes precedence over flag defaults
190190
if err := cmd.Flags().Set(server.FlagMempoolMaxTxs, "0"); err != nil {
191191
panic(err)

0 commit comments

Comments
 (0)