Skip to content

Commit 9502a7f

Browse files
authored
Improve PHP 8.4 support (#221)
1 parent ef94f8e commit 9502a7f

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
method when non-positive value is passed (@vjik)
5151
- Chg #219: Don't check correctness of current page in `PaginatorInterface::isOnLastPage()` method (@vjik)
5252
- Chg #219: Rename `PaginatorException` to `InvalidPageException` (@vjik)
53-
- Chg #211: Change PHP constraint in `composer.json` to `~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0` (@vjik)
53+
- Chg #211, #221: Change PHP constraint in `composer.json` to `8.1 - 8.4` (@vjik)
5454

5555
## 1.0.1 January 25, 2023
5656

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
}
3232
],
3333
"require": {
34-
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
34+
"php": "8.1 - 8.4",
3535
"ext-mbstring": "*",
3636
"yiisoft/arrays": "^3.0"
3737
},
@@ -41,7 +41,7 @@
4141
"rector/rector": "^2.0.9",
4242
"roave/infection-static-analysis-plugin": "^1.35",
4343
"spatie/phpunit-watcher": "^1.24",
44-
"vimeo/psalm": "^5.26.1 || ^6.6"
44+
"vimeo/psalm": "^5.26.1 || ^6.9.1"
4545
},
4646
"autoload": {
4747
"psr-4": {
@@ -55,7 +55,6 @@
5555
},
5656
"config": {
5757
"sort-packages": true,
58-
"bump-after-update": "dev",
5958
"allow-plugins": {
6059
"infection/extension-installer": true,
6160
"composer/package-versions-deprecated": true

psalm.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
errorLevel="1"
44
findUnusedBaselineEntry="true"
55
findUnusedCode="false"
6+
ensureOverrideAttribute="false"
7+
strictBinaryOperands="false"
68
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
79
xmlns="https://getpsalm.org/schema/config"
810
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"

tests/Paginator/KeysetPaginatorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ public function testCustomPageSize(): void
601601
$this->assertCount(2, $paginator->read());
602602
}
603603

604-
private static function getDataSet(array $keys = null): array
604+
private static function getDataSet(?array $keys = null): array
605605
{
606606
if ($keys === null) {
607607
return self::DEFAULT_DATASET;
@@ -705,7 +705,7 @@ private function createObjectWithGetters(int $id, string $name): object
705705
return new class ($id, $name) {
706706
private int $createdAt;
707707

708-
public function __construct(private int $id, private string $name, int $createdAt = null)
708+
public function __construct(private int $id, private string $name, ?int $createdAt = null)
709709
{
710710
$this->createdAt = $createdAt ?: time();
711711
}

0 commit comments

Comments
 (0)