Skip to content

Commit 45375ec

Browse files
committed
Fix
1 parent 4785789 commit 45375ec

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

009-design-decisions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ properties everywhere, thus lack of encapsulation and code fragility.
1414
## Remove the service locator
1515

1616
Service locator both Yii 1 and Yii 2 was convenient but was also abused a lot.
17-
Despite a dependency injection container was available in Yii 2, service locator
17+
Although a dependency injection container was available in Yii 2, service locator
1818
was generally preferred to cause both a dependency on the service locator itself,
1919
high coupling, hard to test code.
2020

012-tests.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ When designing tests, the following guidelines should be taken into account.
88
- The test method name must reflect the purpose of the test.
99
- "should" must not be used in the test method name.
1010
- If necessary, the test method phpdoc may describe the desired behavior.
11-
- The test must be structured as AAA — arrange, act, assert that's first we're preparing what's necessary, then making calls,
12-
then asserting everything is correct.
11+
- The test must follow AAA: first arrange the necessary preconditions, then act, then assert expected results.
1312
- There must be one test case per test method that's a single AAA.
1413
- Test must use public API.
1514
Private properties or methods shouldn't be accessed, assumptions on internals

018-widgets.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ Widgets should:
3131

3232
### Boolean flags
3333

34-
The Method that corresponds to the boolean attribute should be named after the attribute and accept a boolean flag argument.
34+
The method that corresponds to the boolean attribute should be named after the attribute and accept a boolean flag argument.

0 commit comments

Comments
 (0)