Skip to content

Commit 5eff210

Browse files
authored
Transfer HeaderHelper to yiisoft/http (#48)
1 parent ef89eca commit 5eff210

File tree

7 files changed

+10
-497
lines changed

7 files changed

+10
-497
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Yii Error Handler Change Log
22

3-
4-
## 1.0.1 under development
3+
## 2.0.0 under development
54

65
- Enh #45: Improve appearance of solution from friendly exceptions (vjik)
6+
- Chg #48: Transfer `HeaderHelper` to `yiisoft/http` package (devanych)
77

88
## 1.0.0 May 13, 2021
99

composer.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,17 @@
2929
"psr/http-server-middleware": "^1.0",
3030
"psr/log": "^1.1",
3131
"yiisoft/friendly-exception": "^1.0",
32-
"yiisoft/http": "^1.0",
32+
"yiisoft/http": "^1.2",
3333
"yiisoft/injector": "^1.0"
3434
},
3535
"require-dev": {
36-
"httpsoft/http-message": "^1.0.8",
36+
"httpsoft/http-message": "^1.0.9",
3737
"phpunit/phpunit": "^9.5",
3838
"psr/http-server-handler": "^1.0",
39-
"roave/infection-static-analysis-plugin": "^1.6",
39+
"roave/infection-static-analysis-plugin": "^1.10",
4040
"spatie/phpunit-watcher": "^1.23",
41-
"vimeo/psalm": "^4.6",
42-
"yiisoft/test-support": "^1.2"
41+
"vimeo/psalm": "^4.12",
42+
"yiisoft/test-support": "^1.3"
4343
},
4444
"autoload": {
4545
"psr-4": {

psalm.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
<?xml version="1.0"?>
22
<psalm
33
errorLevel="2"
4-
resolveFromConfigFile="true"
54
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
65
xmlns="https://getpsalm.org/schema/config"
76
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
87
>
98
<projectFiles>
109
<directory name="src" />
11-
<ignoreFiles>
12-
<directory name="vendor" />
13-
</ignoreFiles>
1410
</projectFiles>
1511
</psalm>

src/HeaderHelper.php

Lines changed: 0 additions & 265 deletions
This file was deleted.

src/Middleware/ErrorCatcher.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
use Psr\Http\Server\RequestHandlerInterface;
1414
use Throwable;
1515
use Yiisoft\ErrorHandler\ErrorHandler;
16-
use Yiisoft\ErrorHandler\HeaderHelper;
1716
use Yiisoft\ErrorHandler\Renderer\HeaderRenderer;
1817
use Yiisoft\ErrorHandler\Renderer\HtmlRenderer;
1918
use Yiisoft\ErrorHandler\Renderer\JsonRenderer;
2019
use Yiisoft\ErrorHandler\Renderer\PlainTextRenderer;
2120
use Yiisoft\ErrorHandler\Renderer\XmlRenderer;
2221
use Yiisoft\ErrorHandler\ThrowableRendererInterface;
2322
use Yiisoft\Http\Header;
23+
use Yiisoft\Http\HeaderValueHelper;
2424
use Yiisoft\Http\Method;
2525
use Yiisoft\Http\Status;
2626

@@ -183,7 +183,7 @@ private function getRenderer(string $contentType): ?ThrowableRendererInterface
183183
private function getContentType(ServerRequestInterface $request): string
184184
{
185185
try {
186-
foreach (HeaderHelper::getSortedAcceptTypes($request->getHeader(Header::ACCEPT)) as $header) {
186+
foreach (HeaderValueHelper::getSortedAcceptTypes($request->getHeader(Header::ACCEPT)) as $header) {
187187
if (array_key_exists($header, $this->renderers)) {
188188
return $header;
189189
}

src/Renderer/HtmlRenderer.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@ private function renderTemplate(string $path, array $parameters): string
388388

389389
$obInitialLevel = ob_get_level();
390390
ob_start();
391+
/** @psalm-suppress InvalidArgument */
391392
PHP_VERSION_ID >= 80000 ? ob_implicit_flush(false) : ob_implicit_flush(0);
392393

393394
try {

0 commit comments

Comments
 (0)