Skip to content

Commit b80bac0

Browse files
committed
Simplify creating error string
1 parent 7c14311 commit b80bac0

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

src/ErrorHandler.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function handle(
6262
$renderer ??= $this->defaultRenderer;
6363

6464
try {
65-
$this->logger->error((string) (new PlainTextRenderer())->renderVerbose($t, $request), ['throwable' => $t]);
65+
$this->logger->error(PlainTextRenderer::throwableToString($t), ['throwable' => $t]);
6666
return $this->debug ? $renderer->renderVerbose($t, $request) : $renderer->render($t, $request);
6767
} catch (Throwable $t) {
6868
return new ErrorData((string) $t);

src/Renderer/PlainTextRenderer.php

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,26 @@ public function render(Throwable $t, ServerRequestInterface $request = null): Er
2222
public function renderVerbose(Throwable $t, ServerRequestInterface $request = null): ErrorData
2323
{
2424
return new ErrorData(
25-
$t::class . " with message '{$t->getMessage()}' \n\nin "
26-
. $t->getFile() . ':' . $t->getLine() . "\n\n"
27-
. "Stack trace:\n" . $t->getTraceAsString()
25+
$this->throwableToString($t)
26+
);
27+
}
28+
29+
public static function throwableToString(Throwable $t): string
30+
{
31+
return sprintf(
32+
<<<TEXT
33+
%s with message "%s"
34+
35+
in %s:%s
36+
37+
Stack trace:
38+
%s
39+
TEXT,
40+
$t::class,
41+
$t->getMessage(),
42+
$t->getFile(),
43+
$t->getLine(),
44+
$t->getTraceAsString()
2845
);
2946
}
3047
}

0 commit comments

Comments
 (0)