Fix #50: Fix JSON rendering on JSON recursion exception

Author: thenotsoft

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## 2.0.2 under development
 
-- no changes in this release.
+- Bug #50: Fix JSON rendering on JSON recursion exception (thenotsoft)
 
 ## 2.0.1 January 26, 2022
 

src/Renderer/JsonRenderer.php

@@ -19,20 +19,30 @@ final class JsonRenderer implements ThrowableRendererInterface
 {
     public function render(Throwable $t, ServerRequestInterface $request = null): ErrorData
     {
-        return new ErrorData(json_encode([
-            'message' => self::DEFAULT_ERROR_MESSAGE,
-        ], JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES));
+        return new ErrorData(
+            json_encode(
+                [
+                    'message' => self::DEFAULT_ERROR_MESSAGE,
+                ],
+                JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES
+            )
+        );
     }
 
     public function renderVerbose(Throwable $t, ServerRequestInterface $request = null): ErrorData
     {
-        return new ErrorData(json_encode([
-            'type' => get_class($t),
-            'message' => $t->getMessage(),
-            'code' => $t->getCode(),
-            'file' => $t->getFile(),
-            'line' => $t->getLine(),
-            'trace' => $t->getTrace(),
-        ], JSON_THROW_ON_ERROR | JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_INVALID_UTF8_SUBSTITUTE));
+        return new ErrorData(
+            json_encode(
+                [
+                    'type' => get_class($t),
+                    'message' => $t->getMessage(),
+                    'code' => $t->getCode(),
+                    'file' => $t->getFile(),
+                    'line' => $t->getLine(),
+                    'trace' => $t->getTrace(),
+                ],
+                JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_INVALID_UTF8_SUBSTITUTE | JSON_PARTIAL_OUTPUT_ON_ERROR
+            )
+        );
     }
 }

tests/Renderer/JsonRendererTest.php

@@ -19,7 +19,7 @@ public function testRender(): void
         $renderer = new JsonRenderer();
         $data = $renderer->render(new RuntimeException());
 
-        $this->assertSame(json_encode(['message' => JsonRenderer::DEFAULT_ERROR_MESSAGE]), (string) $data);
+        $this->assertSame(json_encode(['message' => JsonRenderer::DEFAULT_ERROR_MESSAGE]), (string)$data);
     }
 
     public function testRenderVerbose(): void
@@ -36,7 +36,7 @@ public function testRenderVerbose(): void
             'trace' => $throwable->getTrace(),
         ], JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
 
-        $this->assertSame($content, (string) $data);
+        $this->assertSame($content, (string)$data);
     }
 
     public function testRenderVerboseWithNotUtf8String(): void
@@ -53,6 +53,40 @@ public function testRenderVerboseWithNotUtf8String(): void
             'trace' => $throwable->getTrace(),
         ], JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_INVALID_UTF8_SUBSTITUTE);
 
-        $this->assertSame($content, (string) $data);
+        $this->assertSame($content, (string)$data);
+    }
+
+    public function testRenderVerboseWithJsonRecursion(): void
+    {
+        $renderer = new JsonRenderer();
+
+        try {
+            json_encode(
+                new class () {
+                    public self $self;
+
+                    public function __construct()
+                    {
+                        $this->self = $this;
+                    }
+                },
+                JSON_THROW_ON_ERROR
+            );
+        } catch (\Throwable $throwable) {
+            $data = $renderer->renderVerbose($throwable);
+            $content = json_encode(
+                [
+                    'type' => \JsonException::class,
+                    'message' => $throwable->getMessage(),
+                    'code' => $throwable->getCode(),
+                    'file' => $throwable->getFile(),
+                    'line' => $throwable->getLine(),
+                    'trace' => $throwable->getTrace(),
+                ],
+                JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_INVALID_UTF8_SUBSTITUTE | JSON_PARTIAL_OUTPUT_ON_ERROR
+            );
+        }
+
+        $this->assertSame($content, (string)$data);
     }
 }