Skip to content

Commit 71ea462

Browse files
authored
Explicitly mark nullable parameters in UrlGeneratorInterface (#263)
1 parent fad6e6b commit 71ea462

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- Chg #256: Bump minimum PHP version to 8.1 (@vjik)
1010
- Enh #256: Mark readonly properties (@vjik)
1111
- Chg #257: Change PHP constraint in `composer.json` to `~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0` (@vjik)
12-
- Bug #257: Explicitly mark nullable parameters (@vjik)
12+
- Bug #257, #263: Explicitly mark nullable parameters (@vjik)
1313
- Сhg #247: Change `UrlGeneratorInterface` contract: on URL generation all unused arguments must be moved to query
1414
parameters, if query parameter with such name doesn't exist (@vjik)
1515
- New #262: Add `$hash` parameter to `UrlGeneratorInterface` methods: `generate()`, `generateAbsolute()` and

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"rector/rector": "^2.0.9",
4747
"roave/infection-static-analysis-plugin": "^1.35",
4848
"spatie/phpunit-watcher": "^1.24",
49-
"vimeo/psalm": "^5.26.1 || ^6.8.4",
49+
"vimeo/psalm": "^5.26.1 || ^6.8.6",
5050
"yiisoft/di": "^1.3",
5151
"yiisoft/dummy-provider": "^1.0.1",
5252
"yiisoft/hydrator": "^1.5",

src/UrlGeneratorInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ public function generateAbsolute(
5757
array $arguments = [],
5858
array $queryParameters = [],
5959
?string $hash = null,
60-
string $scheme = null,
61-
string $host = null
60+
?string $scheme = null,
61+
?string $host = null
6262
): string;
6363

6464
/**

0 commit comments

Comments
 (0)