Fix parameters leak in context validation (#720)

Author: vjik

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## 1.4.1 under development
 
-- no changes in this release.
+- Bug #719: Fix parameters leak in context validation (@vjik)
 
 ## 1.4.0 May 22, 2024
 

composer.json

@@ -42,7 +42,7 @@
         "maglnet/composer-require-checker": "^4.3",
         "phpbench/phpbench": "^1.2",
         "phpunit/phpunit": "^9.5",
-        "rector/rector": "^1.0",
+        "rector/rector": "1.0.*",
         "roave/infection-static-analysis-plugin": "^1.25",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.30|^5.22",

src/ValidationContext.php

@@ -146,6 +146,7 @@ public function validate(mixed $data, callable|iterable|object|string|null $rule
         $currentDataSet = $this->dataSet;
         $currentAttribute = $this->attribute;
         $isCurrentDataSetMissing = $this->isDataSetMissing;
+        $currentParameters = $this->parameters;
 
         // The lack of an attribute means that in the context of further validation there is no data set at all.
         $this->isDataSetMissing = $this->isAttributeMissing();
@@ -154,6 +155,7 @@ public function validate(mixed $data, callable|iterable|object|string|null $rule
         $this->dataSet = $currentDataSet;
         $this->attribute = $currentAttribute;
         $this->isDataSetMissing = $isCurrentDataSetMissing;
+        $this->parameters = $currentParameters;
 
         return $result;
     }

tests/Rule/EachTest.php

@@ -6,6 +6,7 @@
 
 use Generator;
 use Yiisoft\Validator\Result;
+use Yiisoft\Validator\Rule\Callback;
 use Yiisoft\Validator\Rule\Each;
 use Yiisoft\Validator\Rule\EachHandler;
 use Yiisoft\Validator\Rule\Length;
@@ -170,10 +171,31 @@ public function testGetOptionsWithNotRule(): void
     public function dataValidationPassed(): array
     {
         return [
-            [
+            'base' => [
                 [10, 11],
                 [new Each([new Number(max: 20)])],
             ],
+            'double-each-with-arrays' => [
+                [
+                    'items' => [
+                        ['variantId' => 123, 'quantity' => 1],
+                    ],
+                ],
+                [
+                    'items' => [
+                        new Each([
+                            new Callback(callback: function (array $item) {
+                                return new Result();
+                            }),
+                        ]),
+                        new Each([
+                            new Callback(callback: function (array $item) {
+                                return new Result();
+                            }),
+                        ]),
+                    ],
+                ],
+            ],
         ];
     }