PHP 8.1 Return type support

csears123 · web-flow · commit 24c88744908b · 2022-12-12T14:01:12.000-07:00
The return type for lastInsertId() method needs to be compatible with PDO::lastInsertId().  Adding the return type for stiring|false resolves the compatibility issue encountered in PHP 8.1
diff --git a/framework/db/schema/mssql/CMssqlSqlsrvPdoAdapter.php b/framework/db/schema/mssql/CMssqlSqlsrvPdoAdapter.php
@@ -30,7 +30,7 @@ class CMssqlSqlsrvPdoAdapter extends PDO
 	 * @param string|null $sequence the sequence/table name. Defaults to null.
 	 * @return integer last inserted ID value.
 	 */
-	public function lastInsertId($sequence=null)
+	public function lastInsertId($sequence=null): string|false
 	{
 		$parts = explode('.', phpversion('pdo_sqlsrv'));
 		$sqlsrvVer = phpversion('pdo_sqlsrv') ? intval(array_shift($parts)) : 0;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class CMssqlSqlsrvPdoAdapter extends PDO`
`30`	`30`	`* @param string\|null $sequence the sequence/table name. Defaults to null.`
`31`	`31`	`* @return integer last inserted ID value.`
`32`	`32`	`*/`
`33`		`- public function lastInsertId($sequence=null)`
	`33`	`+ public function lastInsertId($sequence=null): string\|false`
`34`	`34`	`{`
`35`	`35`	`$parts = explode('.', phpversion('pdo_sqlsrv'));`
`36`	`36`	`$sqlsrvVer = phpversion('pdo_sqlsrv') ? intval(array_shift($parts)) : 0;`