Do not duplicate log messages in memory

lubosdz · lubosdz · commit 764926a877f6 · 2023-09-29T09:49:05.000+02:00
diff --git a/framework/CHANGELOG.md b/framework/CHANGELOG.md
@@ -4,6 +4,7 @@ Yii Framework 2 Change Log
 2.0.50 under development
 ------------------------
 
+- Bug #19984: Do not duplicate log messages in memory (lubosdz)
 - Bug #19925: Improved PHP version check when handling MIME types (schmunk42)
 - Bug #19940: File Log writer without newline (terabytesoftw)
 - Bug #19951: Removed unneeded MIME file tests (schmunk42)
diff --git a/framework/log/FileTarget.php b/framework/log/FileTarget.php
@@ -107,9 +107,8 @@ public function init()
     public function export()
     {
         $text = implode("\n", array_map([$this, 'formatMessage'], $this->messages)) . "\n";
-        $trimmedText = trim($text);
 
-        if (empty($trimmedText)) {
+        if (!trim($text)) {
             return; // No messages to export, so we exit the function early
         }
 

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,8 @@ public function init()`
`107`	`107`	`public function export()`
`108`	`108`	`{`
`109`	`109`	`$text = implode("\n", array_map([$this, 'formatMessage'], $this->messages)) . "\n";`
`110`		`- $trimmedText = trim($text);`
`111`	`110`
`112`		`- if (empty($trimmedText)) {`
	`111`	`+ if (!trim($text)) {`
`113`	`112`	`return; // No messages to export, so we exit the function early`
`114`	`113`	`}`
`115`	`114`