Add generics.

[terabytesoftw]

@mspirkov It would be great to add a generic in yii\base\Controller::$module.

Example:

<?php
/**
 * @template T of Module
 * @phpstan-property T $module
 * @psalm-property T $module
 */
class Controller extends Component implements ViewContextInterface
{
    public $module;
}

<?php
/**
 * @extends Controller<DebugModule>
 */
class DefaultController extends Controller
{
    public function actionIndex()
    {
        $dataPath = $this->module->dataPath;
    }
}

This would be useful for extensions that use their own Module::class like yii2-debug, i also think we should add generics where necessary, so that static analysis works.

[mspirkov]

Great idea! I will do it

[mspirkov]

Done. Is there anything else we'd like to discuss here?

[terabytesoftw]

Thks 👍

[terabytesoftw]

yii2/framework/BaseYii.php

Line 79 in 976eac5

public static $app;

I think a generic rule is missing here, like how to know when it's a console or when it's a web, or a custom app. I opened this problem on PHPStan.

phpstan/phpstan#13145

[mspirkov]

Yes, such a problem exists.
Can we really solve this with generics? Any ideas on this?