Skip to content

Commit 2d2746b

Browse files
code-asheryiliang114
authored andcommitted
Fix dangling links in standalone release
The fix will now run both to the GitHub and npm release instead of only for the npm releases. Closes coder#5157.
1 parent 6e6366c commit 2d2746b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

ci/build/build-packages.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,6 @@ release_nfpm() {
5050

5151
export NFPM_ARCH
5252

53-
# Code deletes some files from the extension node_modules directory which
54-
# leaves broken symlinks in the corresponding .bin directory. nfpm will fail
55-
# on these broken symlinks so clean them up.
56-
rm -fr "./release-standalone/lib/vscode/extensions/node_modules/.bin"
57-
5853
PKG_FORMAT="deb"
5954
NFPM_ARCH="$(get_nfpm_arch $PKG_FORMAT "$ARCH")"
6055
nfpm_config="$(envsubst < ./ci/build/nfpm.yaml)"

ci/build/build-standalone-release.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ main() {
2424

2525
pushd "$RELEASE_PATH"
2626
npm install --unsafe-perm --omit=dev
27+
# Code deletes some files from the extension node_modules directory which
28+
# leaves broken symlinks in the corresponding .bin directory. nfpm will fail
29+
# on these broken symlinks so clean them up.
30+
rm -fr "./lib/vscode/extensions/node_modules/.bin"
2731
popd
2832
}
2933

0 commit comments

Comments
 (0)