Skip to content

Commit ec646a4

Browse files
authored
PHP 8.4 testing (#58)
* Upgrade for PHP 8.4 * Fix test
1 parent cd1533c commit ec646a4

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
os: [ubuntu-latest]
17-
php: [8.3, 8.2]
17+
php: [8.4, 8.3, 8.2]
1818
laravel: ['11.*', '10.*']
1919
stability: [prefer-lowest, prefer-stable]
2020
include:

tests/MailSubscriberTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace YlsIdeas\SubscribableNotifications\Tests;
44

55
use Illuminate\Support\Facades\Route;
6+
use Illuminate\Support\Facades\URL;
67
use Orchestra\Testbench\TestCase;
78
use YlsIdeas\SubscribableNotifications\Facades\Subscriber;
89
use YlsIdeas\SubscribableNotifications\SubscribableServiceProvider;
@@ -45,8 +46,9 @@ public function it_generates_a_signed_url_for_users_to_unsubscribe()
4546

4647
$url = $user->unsubscribeLink();
4748

49+
4850
$this->assertEquals(
49-
'http://localhost/unsubscribe/1?signature=bcc7b9f9909fb5f427f1b55022ee44eafee3d655a449f48d2e751748e1a9bcdf',
51+
URL::signedRoute('unsubscribe', ['subscriber' => 1]),
5052
$url
5153
);
5254
}
@@ -68,7 +70,7 @@ public function it_generates_a_signed_url_for_users_to_unsubscribe_from_a_mailin
6870
$url = $user->unsubscribeLink('test');
6971

7072
$this->assertEquals(
71-
'http://localhost/unsubscribe/1/test?signature=edaf5bee199875521054535be04273c5006e4d6d834c98a83a3aa16a92223814',
73+
URL::signedRoute('unsubscribe', ['subscriber' => 1, 'mailingList' => 'test']),
7274
$url
7375
);
7476
}

0 commit comments

Comments
 (0)