Negative test for Snowflake

Author: yoavcloud

src/dialect/mod.rs

@@ -49,7 +49,7 @@ pub use self::postgresql::PostgreSqlDialect;
 pub use self::redshift::RedshiftSqlDialect;
 pub use self::snowflake::SnowflakeDialect;
 pub use self::sqlite::SQLiteDialect;
-use crate::ast::{ColumnOption, Expr, GranteesType, Ident, Statement};
+use crate::ast::{ColumnOption, Expr, GranteesType, Ident, ObjectNamePart, Statement};
 pub use crate::keywords;
 use crate::keywords::Keyword;
 use crate::parser::{Parser, ParserError};
@@ -1082,7 +1082,11 @@ pub trait Dialect: Debug + Any {
     /// programmatically.
     ///
     /// - [Snowflake](https://docs.snowflake.com/en/sql-reference/identifier-literal)
-    fn is_identifier_generating_function_name(&self, _ident: &Ident) -> bool {
+    fn is_identifier_generating_function_name(
+        &self,
+        _ident: &Ident,
+        _name_parts: &[ObjectNamePart],
+    ) -> bool {
         false
     }
 }

src/dialect/snowflake.rs

@@ -25,8 +25,8 @@ use crate::ast::helpers::stmt_data_loading::{
 use crate::ast::{
     ColumnOption, ColumnPolicy, ColumnPolicyProperty, CopyIntoSnowflakeKind, Ident,
     IdentityParameters, IdentityProperty, IdentityPropertyFormatKind, IdentityPropertyKind,
-    IdentityPropertyOrder, ObjectName, RowAccessPolicy, ShowObjects, SqlOption, Statement,
-    TagsColumnOption, WrappedCollection,
+    IdentityPropertyOrder, ObjectName, ObjectNamePart, RowAccessPolicy, ShowObjects, SqlOption,
+    Statement, TagsColumnOption, WrappedCollection,
 };
 use crate::dialect::{Dialect, Precedence};
 use crate::keywords::Keyword;
@@ -368,8 +368,16 @@ impl Dialect for SnowflakeDialect {
         true
     }
 
-    fn is_identifier_generating_function_name(&self, ident: &Ident) -> bool {
-        ident.quote_style.is_none() && ident.value.to_lowercase() == "identifier"
+    fn is_identifier_generating_function_name(
+        &self,
+        ident: &Ident,
+        name_parts: &[ObjectNamePart],
+    ) -> bool {
+        ident.quote_style.is_none()
+            && ident.value.to_lowercase() == "identifier"
+            && !name_parts
+                .iter()
+                .any(|p| matches!(p, ObjectNamePart::Function(_)))
     }
 
     // For example: `SELECT IDENTIFIER('alias1').* FROM tbl AS alias1`

src/parser/mod.rs

@@ -10409,7 +10409,10 @@ impl<'a> Parser<'a> {
                     parts.push(ObjectNamePart::Identifier(Ident::new("")));
                 } else {
                     let ident = self.parse_identifier()?;
-                    let part = if self.dialect.is_identifier_generating_function_name(&ident) {
+                    let part = if self
+                        .dialect
+                        .is_identifier_generating_function_name(&ident, &parts)
+                    {
                         self.expect_token(&Token::LParen)?;
                         let args: Vec<FunctionArg> =
                             self.parse_comma_separated0(Self::parse_function_args, Token::RParen)?;

tests/sqlparser_snowflake.rs

@@ -4350,4 +4350,20 @@ fn test_snowflake_identifier_function() {
         }
         _ => unreachable!(),
     }
+
+    // Cannot have more than one IDENTIFIER part in an object name
+    assert_eq!(
+        snowflake()
+            .parse_sql_statements(
+                "CREATE TABLE IDENTIFIER('db1').IDENTIFIER('sc1').IDENTIFIER('tbl') (id INT)"
+            )
+            .is_err(),
+        true
+    );
+    assert_eq!(
+        snowflake()
+            .parse_sql_statements("CREATE TABLE IDENTIFIER('db1')..IDENTIFIER('tbl') (id INT)")
+            .is_err(),
+        true
+    );
 }