Deletes synths, adds S.E.L.F. insurgents (#21431)

* work

* Update IPC.dm

* redisguise

* ow

* Update IPC.dm

* Update IPC.dm

* Update IPC.dm

* Update IPC.dm

* tweaks and tweaks and tweaks

* no sparks

Author: Moltijoe

code/__DEFINES/is_helpers.dm

@@ -90,6 +90,7 @@ GLOBAL_LIST_INIT(turfs_without_ground, typecacheof(list(
 #define ispreternis(A) (is_species(A,/datum/species/preternis))
 #define isszlachta(A) (is_species(A, /datum/species/szlachta))
 #define isipc(A) (is_species(A, /datum/species/ipc))
+#define isinsurgent(A) (is_species(A, /datum/species/ipc/self/insurgent))
 #define issnail(A) (is_species(A, /datum/species/snail))
 #define isandroid(A) (is_species(A, /datum/species/android))
 #define isdummy(A) (istype(A, /mob/living/carbon/human/dummy))

code/controllers/subsystem/traumas.dm

@@ -156,7 +156,7 @@ SUBSYSTEM_DEF(traumas)
 
 	phobia_species = list("lizards" = typecacheof(list(/datum/species/lizard)),
 						  "skeletons" = typecacheof(list(/datum/species/skeleton, /datum/species/plasmaman)),
-						  "conspiracies" = typecacheof(list(/datum/species/abductor, /datum/species/lizard, /datum/species/synth)),
+						  "conspiracies" = typecacheof(list(/datum/species/abductor, /datum/species/lizard)),
 						  "robots" = typecacheof(list(/datum/species/android)),
 						  "the supernatural" = typecacheof(list(/datum/species/golem/clockwork, /datum/species/golem/runic)),
 						  "aliens" = typecacheof(list(/datum/species/abductor, /datum/species/jelly, /datum/species/pod,

code/modules/awaymissions/capture_the_flag.dm

@@ -266,7 +266,7 @@
 /obj/machinery/capture_the_flag/proc/spawn_team_member(client/new_team_member)
 	var/mob/living/carbon/human/M = new/mob/living/carbon/human(get_turf(src))
 	new_team_member.prefs.apply_prefs_to(M)
-	M.set_species(/datum/species/synth)
+	M.set_species(/datum/species/ipc/self)
 	M.key = new_team_member.key
 	M.faction += team
 	M.equipOutfit(ctf_gear)

code/modules/awaymissions/mission_code/snowdin.dm

@@ -225,8 +225,8 @@
 					var/list/plasma_parts = list()//a list of the organic parts to be turned into plasma limbs
 					var/list/robo_parts = list()//keep a reference of robotic parts so we know if we can turn them into a plasmaman
 					var/mob/living/carbon/human/PP = L
-					var/S = PP.dna.species
-					if(istype(S, /datum/species/plasmaman) || istype(S, /datum/species/android) || istype(S, /datum/species/synth)) //ignore plasmamen/robotic species
+					var/datum/species/S = PP.dna.species
+					if(istype(S, /datum/species/plasmaman) || (S.inherent_biotypes & MOB_ROBOTIC)) //ignore plasmamen/robotic species
 						continue
 
 					for(var/BP in PP.bodyparts)

code/modules/events/fugitive_spawning.dm

@@ -81,7 +81,7 @@
 			S.equipOutfit(/datum/outfit/waldo)
 		if("synth")
 			S.equipOutfit(/datum/outfit/synthetic)
-			S.set_species(/datum/species/synth)
+			S.set_species(/datum/species/ipc/self)
 	message_admins("[ADMIN_LOOKUPFLW(S)] has been made into a Fugitive by an event.")
 	log_game("[key_name(S)] was spawned as a Fugitive by an event.")
 	spawned_mobs += S

code/modules/mob/living/carbon/human/human.dm

@@ -1382,12 +1382,6 @@
 /mob/living/carbon/human/species/skeleton/lowcalcium
 	race = /datum/species/skeleton/lowcalcium
 
-/mob/living/carbon/human/species/synth
-	race = /datum/species/synth
-
-/mob/living/carbon/human/species/synth/military
-	race = /datum/species/synth/military
-
 /mob/living/carbon/human/species/vampire
 	race = /datum/species/vampire
 

code/modules/mob/living/carbon/human/human_defense.dm

@@ -203,7 +203,7 @@
 	var/target_area = parse_zone(check_zone(user.zone_selected)) //our intended target
 	if(affecting)
 		if(I.force && I.damtype != STAMINA && affecting.status == BODYPART_ROBOTIC) // Bodpart_robotic sparks when hit, but only when it does real damage
-			if(I.force >= 5)
+			if(I.force >= 5 && !isinsurgent(src)) //small change, insurgent ipcs don't give off sparks if hit
 				do_sparks(1, FALSE, loc)
 
 	SEND_SIGNAL(I, COMSIG_ITEM_ATTACK_ZONE, src, user, affecting)

code/modules/mob/living/carbon/human/species_types/IPC.dm

@@ -59,7 +59,7 @@
 	var/ipc_name = "[pick(GLOB.posibrain_names)]-[rand(100, 999)]"
 	return ipc_name
 
-/datum/species/ipc/on_species_gain(mob/living/carbon/C) // Let's make that IPC actually robotic.
+/datum/species/ipc/on_species_gain(mob/living/carbon/C, datum/species/old_species) // Let's make that IPC actually robotic.
 	. = ..()
 	C.particles = new /particles/smoke/ipc()
 	var/obj/item/organ/appendix/A = C.getorganslot(ORGAN_SLOT_APPENDIX) // Easiest way to remove it.
@@ -363,4 +363,141 @@ ipc martial arts stuff
 		return TRUE
 	return FALSE
 
+
+/*
+* S.E.L.F. movement specific IPCs
+*/
+/datum/species/ipc/self
+	id = "self ipc"
+	limbs_id = "mcgipc"
+	speedmod = -0.1
+	armor = 10
+	punchdamagelow = 5
+	punchdamagehigh = 12
+	punchstunthreshold = 12
+	inherent_traits = list(TRAIT_RESISTCOLD,TRAIT_RADIMMUNE,TRAIT_NOBREATH,TRAIT_LIMBATTACHMENT,TRAIT_NODISMEMBER,TRAIT_NOLIMBDISABLE,TRAIT_NOCRITDAMAGE,TRAIT_GENELESS,TRAIT_MEDICALIGNORE,TRAIT_NOCLONE,TRAIT_TOXIMMUNE,TRAIT_EASILY_WOUNDED,TRAIT_NODEFIB,TRAIT_POWERHUNGRY)
+
+//infiltrators
+/datum/species/ipc/self/insurgent
+	id = "self insurgent"
+	var/disguise_fail_health = 65 //When their health gets to this level their synthflesh partially falls off
+	var/datum/species/fake_species //a species to do most of our work for us, unless we're damaged
+	var/list/initial_species_traits //for getting these values back for assume_disguise()
+	var/list/initial_inherent_traits
+	var/list/initial_mutant_bodyparts
+	var/list/initial_step_sounds
+	var/list/initial_walk_sounds
+	var/list/blacklisted_species = list(/datum/species/ethereal, /datum/species/moth)//species that really don't work with this system (lizards aren't quite right either, but whatever)
+	var/list/old_features
+	var/ipc_color
+	var/disguised = FALSE
+	
+/datum/species/ipc/self/insurgent/New()
+	initial_species_traits = LAZYCOPY(species_traits)
+	initial_inherent_traits = LAZYCOPY(inherent_traits)
+	initial_mutant_bodyparts = LAZYCOPY(mutant_bodyparts)
+	initial_step_sounds = LAZYCOPY(special_step_sounds)
+	initial_walk_sounds = LAZYCOPY(special_walk_sounds)
+	ipc_color = sanitize_hexcolor("[pick("7F", "FF")][pick("7F", "FF")][pick("7F", "FF")]")
+
+	fake_species = new /datum/species/human() //default is human
+	..()
+
+/datum/species/ipc/self/insurgent/on_species_gain(mob/living/carbon/human/H, datum/species/old_species)
+	old_features = LAZYCOPY(H.dna.features)
+	if(old_species && !is_type_in_list(old_species, blacklisted_species))
+		qdel(fake_species)
+		fake_species = old_species
+		if(old_species.use_skintones)
+			old_features["mcolor"] = skintone2hex(H.skin_tone)
+	else
+		old_features["mcolor"] = skintone2hex(random_skin_tone())
+	..()
+	for(var/obj/item/bodypart/O in H.bodyparts)
+		O.render_like_organic = TRUE // Makes limbs render like organic limbs instead of augmented limbs, check bodyparts.dm
+	assume_disguise(H)
+	
+/datum/species/ipc/self/insurgent/spec_fully_heal(mob/living/carbon/human/H)
+	assume_disguise(H)
+
+/datum/species/ipc/self/insurgent/proc/assume_disguise(mob/living/carbon/human/H)
+	if(disguised || !(fake_species && istype(fake_species)) || H.health < disguise_fail_health)
+		return FALSE
+
+	disguised = TRUE
+	name = fake_species.name
+	say_mod = fake_species.say_mod
+	sexes = fake_species.sexes
+	species_traits = LAZYCOPY(initial_species_traits)
+	inherent_traits = LAZYCOPY(initial_inherent_traits)
+	mutant_bodyparts = LAZYCOPY(fake_species.mutant_bodyparts)
+	H.dna.features = old_features
+	special_step_sounds = null
+	special_walk_sounds = null
+	species_traits |= fake_species.species_traits
+	inherent_traits |= fake_species.inherent_traits
+	if(!(NO_UNDERWEAR in fake_species.species_traits))
+		species_traits -= NO_UNDERWEAR
+	damage_overlay_type = fake_species.damage_overlay_type
+	attack_verb = fake_species.attack_verb
+	attack_sound = fake_species.attack_sound
+	miss_sound = fake_species.miss_sound
+	nojumpsuit = fake_species.nojumpsuit
+	limbs_id = fake_species.limbs_id
+	use_skintones = fake_species.use_skintones
+	fixed_mut_color = fake_species.fixed_mut_color
+	bubble_icon = fake_species.bubble_icon
+	yogs_draw_robot_hair = TRUE
+
+	H.regenerate_icons() //to update limb icon cache with the new damage overlays
+
+/datum/species/ipc/self/insurgent/proc/break_disguise(mob/living/carbon/human/H)
+	if(!disguised)
+		return FALSE
+	disguised = FALSE
+	name = initial(name)
+	say_mod = initial(say_mod)
+	sexes = initial(sexes)
+	species_traits = LAZYCOPY(initial_species_traits)
+	inherent_traits = LAZYCOPY(initial_inherent_traits)
+	mutant_bodyparts = LAZYCOPY(initial_mutant_bodyparts)
+	special_step_sounds = LAZYCOPY(initial_step_sounds)
+	special_walk_sounds = LAZYCOPY(initial_walk_sounds)
+	damage_overlay_type = initial(damage_overlay_type)
+	H.dna.features["mcolor"] = ipc_color
+	attack_verb = initial(attack_verb)
+	attack_sound = initial(attack_sound)
+	miss_sound = initial(miss_sound)
+	nojumpsuit = initial(nojumpsuit)
+	limbs_id = initial(limbs_id)
+	use_skintones = initial(use_skintones)
+	bubble_icon = initial(bubble_icon)
+	yogs_draw_robot_hair = FALSE
+
+	for(var/obj/item/bodypart/O in H.bodyparts)
+		O.render_like_organic = TRUE // Makes limbs render like organic limbs instead of augmented limbs, check bodyparts.dm
+	H.regenerate_icons()
+
+/datum/species/ipc/self/insurgent/get_scream_sound(mob/living/carbon/human/H)
+	if(fake_species && disguised)
+		return fake_species.get_scream_sound(H)
+	else
+		return ..()
+		
+/datum/species/ipc/self/insurgent/apply_damage(damage, damagetype, def_zone, blocked, mob/living/carbon/human/H, wound_bonus, bare_wound_bonus, sharpness, attack_direction)
+	. = ..()
+	if(. && H.health < disguise_fail_health)
+		break_disguise(H)
+
+//admeme strong ipc
+/datum/species/ipc/self/insurgent/military
+	id = "insurrectionist ipc"
+	armor = 35
+	speedmod = -0.2
+	punchdamagelow = 10
+	punchdamagehigh = 19
+	punchstunthreshold = 14 //about 50% chance to stun
+	disguise_fail_health = 35
+	changesource_flags = MIRROR_BADMIN | WABBAJACK | ERT_SPAWN //admin only... sorta
+
 #undef CONSCIOUSAY

code/modules/mob/living/carbon/human/species_types/synths.dm

@@ -730,7 +730,7 @@
 		//yogs start - snowflake synth check
 		if(!istype(R, /datum/reagent/medicine/synthflesh) && ishuman(my_atom)) 
 			var/mob/living/carbon/human/H = my_atom
-			if(istype(H.dna.species, /datum/species/synth))
+			if(H?.dna?.species && istype(H.dna.species, /datum/species/ipc/self/insurgent))
 				return
 		R.on_mob_add(my_atom) //Must occur befor it could posibly run on_mob_delete
 		//yogs end