runtimes (#22525)

Author: ToasterBiome

code/_onclick/hud/hud.dm

@@ -632,9 +632,9 @@ GLOBAL_LIST_INIT(available_ui_styles, list(
 	src.owner = owner
 
 /datum/action_group/Destroy()
-	owner = null
 	QDEL_NULL(landing)
 	QDEL_LIST(actions)
+	owner = null
 	return ..()
 
 /datum/action_group/proc/insert_action(atom/movable/screen/action, index)

code/_onclick/hud/parallax.dm

@@ -368,6 +368,8 @@ INITIALIZE_IMMEDIATE(/atom/movable/screen/parallax_layer)
 /atom/movable/screen/parallax_layer/planet/proc/on_z_change(mob/source)
 	SIGNAL_HANDLER
 	var/client/boss = source.client
+	if(!boss) //since we call this when the mob logs out, we might not have an actually source.client to use.
+		boss = source.canon_client 
 	var/turf/posobj = get_turf(boss?.eye)
 	if(!posobj)
 		return

code/_onclick/other_mobs.dm

@@ -37,7 +37,7 @@
 	if(override)
 		return
 
-	SEND_SIGNAL(src, COMSIG_HUMAN_MELEE_UNARMED_ATTACK, A)
+	SEND_SIGNAL(src, COMSIG_HUMAN_MELEE_UNARMED_ATTACK, A, modifiers)
 	if(modifiers[RIGHT_CLICK])
 		var/secondary_result = A.attack_hand_secondary(src, modifiers)
 		if(secondary_result == SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN || secondary_result == SECONDARY_ATTACK_CONTINUE_CHAIN)

code/game/machinery/doors/door.dm

@@ -203,8 +203,6 @@
 	add_fingerprint(user)
 	if(operating || (obj_flags & EMAGGED))
 		return
-	if(!requiresID())
-		user = null //so allowed(user) always succeeds
 	if(obj_flags & CMAGGED)
 		if(ishuman(user))
 			var/mob/living/carbon/human/H = user
@@ -225,7 +223,7 @@
 		else
 			open()
 		return TRUE
-	if(!allowed(user))
+	if(requiresID() && !allowed(user))
 		if(density)
 			do_animate("deny")
 		return FALSE

code/modules/client/client_procs.dm

@@ -306,7 +306,7 @@ GLOBAL_LIST_INIT(blacklisted_builds, list(
 		src.add_donator_verbs()
 	else
 		if(prefs.read_preference(/datum/preference/toggle/quiet_mode))
-			prefs.write_preference(/datum/preference/toggle/quiet_mode, FALSE)
+			prefs.write_preference(GLOB.preference_entries[/datum/preference/toggle/quiet_mode], FALSE)
 
 	. = ..()	//calls mob.Login()
 

code/modules/client/preferences/gender.dm

@@ -11,11 +11,14 @@
 
 	var/datum/species/species_type = preferences.read_preference(/datum/preference/choiced/species)
 
-	var/list/possible_genders = initial(species_type.possible_genders)
+	var/datum/species/species = new species_type
+
+	var/list/possible_genders = species.possible_genders
 	if(possible_genders.len < 1)
 		stack_trace("[species_type.type] has no possible genders!")
+		qdel(species)
 		return list(PLURAL)
-
+	qdel(species)
 	return pick(possible_genders)
 
 /datum/preference/choiced/gender/apply_to_human(mob/living/carbon/human/target, value)

code/modules/mob/living/carbon/carbon.dm

@@ -263,7 +263,7 @@
 			if(src && buckled)
 				to_chat(src, span_warning("You fail to unbuckle yourself!"))
 	else
-		buckled.user_unbuckle_mob(src,src)
+		buckled?.user_unbuckle_mob(src,src) //if we mash it after we get unbuckled before the alert dissapears we'll resist and runtime
 
 /mob/living/carbon/resist_fire()
 	adjust_fire_stacks(-5)

yogstation/code/modules/mob/living/silicon/silicon.dm

@@ -2,6 +2,8 @@
 	var/list/list/law_history = list() //its a list of lists
 
 /mob/living/silicon/proc/update_law_history(mob/uploader = null)
+	if(!laws) //sometimes we just don't have laws (staff of change)
+		return
 	var/ai_law_sync = "UNKNOWN/Innate laws"
 	if(!uploader && iscyborg(src))
 		var/mob/living/silicon/robot/R = src