Adds a fullscreen visual effect to standing outside in rain or acid rain (#22551)

Author: Moltijoe

code/datums/status_effects/debuffs/fire_stacks.dm

@@ -2,6 +2,7 @@
 #define MOB_BIG_FIRE_STACK_THRESHOLD 3
 
 /datum/status_effect/fire_handler
+	id = "fire_handler"
 	duration = -1
 	alert_type = null
 	status_type = STATUS_EFFECT_REFRESH //Custom code

code/datums/weather/weather_types/acid_rain.dm

@@ -28,7 +28,7 @@
 
 	immunity_type = WEATHER_RAIN
 
-	probability = 20
+	probability = 40
 
 	barometer_predictable = TRUE
 
@@ -65,6 +65,7 @@
 
 /datum/weather/rain/weather_act(mob/living/L)
 	if(L.mind || L.client) //could be pretty intensive, so only do this to things with players in them
+		L.apply_status_effect(/datum/status_effect/raindrops)
 		L.adjust_wet_stacks(3*log(2, (50*L.get_permeability(null, TRUE) + 10) / 10))
 		L.extinguish_mob() // permeability affects the negative fire stacks but not the extinguishing
 
@@ -93,7 +94,7 @@
 	 * So people can be immune to acid but not wet or immune to wet but not acid
 	 */
 
-	probability = 80
+	probability = 60
 
 	barometer_predictable = TRUE
 
@@ -127,3 +128,71 @@
 				return TRUE
 		L = L.loc //Check parent items immunities (recurses up to the turf)
 	return FALSE //RIP you
+
+
+/**
+ * I am squeezing every last drop of brain power to make this
+ */
+
+/**
+ * this keeps track of the overlay and all raindrops
+ */
+/datum/status_effect/raindrops
+	id = "raindrops"
+	duration = 3 SECONDS
+	status_type = STATUS_EFFECT_REFRESH
+	/// Fullscreen effect used to provide the visual to that player and only that player
+	var/atom/movable/screen/fullscreen/raindrops/holder
+
+/datum/status_effect/raindrops/on_creation(mob/living/new_owner, ...)
+	. = ..()
+	holder = new_owner.overlay_fullscreen("raindrops", /atom/movable/screen/fullscreen/raindrops)
+	
+/datum/status_effect/raindrops/tick(delta_time, times_fired) //happening here for now
+	. = ..()
+	tick_interval = rand(0, 5) //next drop happens in a random amount of time
+	for(var/i in rand(1,2))
+		droplet()
+
+/datum/status_effect/raindrops/proc/droplet()
+	var/obj/effect/temp_visual/raindrops/onedrop = new(owner) //put it inside the mob so it follows the player as they move
+	onedrop.pixel_x += rand(-80, 480)
+	onedrop.pixel_y += rand(-80, 480) //get put somewhere randomly on the screen
+	//because it's a downscaled large image, it starts out in the bottom left corner by default
+	holder.vis_contents += onedrop
+
+/datum/status_effect/raindrops/refresh(effect, ...) //also spawn a droplet every time we're refreshed, makes the rain look far more dense if we're standing outside
+	for(var/i in rand(1,2))
+		droplet()
+	return ..()
+
+/datum/status_effect/raindrops/on_remove()
+	owner.clear_fullscreen("raindrops")
+	if(holder && !QDELETED(holder))
+		qdel(holder)
+	return ..()
+	
+/**
+ * This provides the images to only the person with it
+ */
+/atom/movable/screen/fullscreen/raindrops
+	icon_state = "raindrops"
+	appearance_flags = PIXEL_SCALE | RESET_TRANSFORM
+	plane = GRAVITY_PULSE_PLANE 
+	
+/**
+ * this is an individual raindrop, multiple of these are spawned and added to the fullscreen to emulate random raindrops
+ */
+/obj/effect/temp_visual/raindrops
+	plane = GRAVITY_PULSE_PLANE
+	icon = 'yogstation/icons/effects/160x160.dmi' //massive picture for smoother edges
+	icon_state = "raindrop"
+	appearance_flags = PIXEL_SCALE | RESET_TRANSFORM
+	mouse_opacity = MOUSE_OPACITY_TRANSPARENT
+	duration = (0.8 SECONDS) //fades out over this time, not too long, not too slow
+
+/obj/effect/temp_visual/raindrops/Initialize(mapload)
+	. = ..()
+	transform = matrix()/5 //we do this so it can larger if needed
+	animate(src, alpha = 0, time = duration)
+