Who thought it was a good idea to name those fields that?

Author: Oblisk234

code/modules/mob/living/silicon/pai/pai.dm

@@ -41,19 +41,6 @@
 
 // Various software-specific vars
 
-	var/temp				// General error reporting text contained here will typically be shown once and cleared
-	var/screen				// Which screen our main window displays
-	var/subscreen			// Which specific function of the main screen is being displayed
-
-	var/secHUD = 0			// Toggles whether the Security HUD is active or not
-	var/medHUD = 0			// Toggles whether the Medical  HUD is active or not
-
-	var/datum/data/record/medicalActive1		// Datacore record declarations for record software
-	var/datum/data/record/medicalActive2
-
-	var/datum/data/record/securityActive1		// Could probably just combine all these into one
-	var/datum/data/record/securityActive2
-
 	var/obj/machinery/door/hackdoor		// The airlock being hacked
 	var/hackprogress = 0				// Possible values: 0 - 100, >= 100 means the hack is complete and will be reset upon next check
 
@@ -64,10 +51,14 @@
 	var/obj/machinery/newscaster			//pAI Newscaster
 	var/obj/item/healthanalyzer/hostscan				//pAI healthanalyzer
 
+	//Whether the pAI has bought the encryption slot module or not
 	var/encryptmod = FALSE
 	var/holoform = FALSE
+	//Can pAI use their holoprojector?
 	var/canholo = TRUE
+	//Can pAI transmit radio messages?
 	var/can_transmit = TRUE
+	//Can pAI receive radio messages?
 	var/can_receive = TRUE
 	var/obj/item/card/id/access_card = null
 	var/chassis = "repairbot"
@@ -153,7 +144,6 @@
 	if(cable && cable.machine && istype(cable.machine, /obj/machinery/door) && cable.machine == hackdoor && get_dist(src, hackdoor) <= 1)
 		hackprogress = clamp(hackprogress + 20, 0, 100)
 	else
-		temp = "Door Jack: Connection to airlock has been lost. Hack aborted."
 		hackprogress = 0
 		hacking = FALSE
 		hackdoor = null
@@ -283,6 +273,10 @@
 /mob/living/silicon/pai/examine(mob/user)
 	. = ..()
 	. += "A personal AI in holochassis mode. Its master ID string seems to be [master]."
+	if(software && isobserver(user))
+		. += "<b>[src] has the following modules:"
+		for(var/list/module in software)
+			. += "[module["module_name"]]"
 
 /mob/living/silicon/pai/Life(seconds_per_tick = SSMOBS_DT, times_fired)
 	if(stat == DEAD)
@@ -307,7 +301,7 @@
 	emitterhealth = clamp((emitterhealth + (emitter_regen_per_second * delta_time)), -50, emittermaxhealth)
 
 /obj/item/computer_hardware/paicard/attackby(obj/item/W, mob/user, params)
-	..()
+	. = ..()
 	user.set_machine(src)
 	if(pai.encryptmod == TRUE)
 		if(W.tool_behaviour == TOOL_SCREWDRIVER)

code/modules/mob/living/silicon/pai/software.dm

@@ -15,8 +15,8 @@
 															list("module_name" = "atmosphere sensor", "tab"=TRUE, "title"="Atmospheric sensor", "cost" = 5),
 															list("module_name" = "photography module", "tab"=FALSE, "cost" = 5),
 															list("module_name" = "remote signaller", "tab"=TRUE, "title"="Remote signaller", "cost" = 10),
-															//list("module_name" = "medical records", "tab"=TRUE, "title"="Medical records", "cost" = 10),
-															//list("module_name" = "security records", "tab"=TRUE, "title"="Security records", "cost" = 10),
+															list("module_name" = "medical records", "tab"=TRUE, "title"="Medical records", "cost" = 10),
+															list("module_name" = "security records", "tab"=TRUE, "title"="Security records", "cost" = 10),
 															list("module_name" = "camera zoom", "tab"=FALSE, "cost" = 10),
 															list("module_name" = "host scan", "tab"=TRUE, "title"="Host Bioscan settings", "cost" = 10),
 															//"camera jack" = 10,
@@ -41,6 +41,9 @@
 
 /mob/living/silicon/pai/var/cable_status = "Retracted"
 
+/mob/living/silicon/pai/var/med_record = list()
+/mob/living/silicon/pai/var/sec_record = list()
+
 /mob/living/silicon/pai/ui_interact(mob/user, datum/tgui/ui)
 	ui = SStgui.try_update_ui(user, src, ui)
 	if(!ui)
@@ -78,6 +81,30 @@
 	data["minFrequency"] = MIN_FREE_FREQ
 	data["maxFrequency"] = MAX_FREE_FREQ
 	data["color"] = signaler.label_color
+	if(GLOB.data_core.general && GLOB.data_core.medical)
+		for(var/datum/data/record/M in sortRecord(GLOB.data_core.medical))
+			for(var/datum/data/record/R in sortRecord(GLOB.data_core.general))
+				if(R.fields["name"] == M.fields["name"])
+					var/new_record = list("name" = R.fields["name"], "id" = R.fields["id"], "gender" = R.fields["gender"], "age" = R.fields["age"], "fingerprint" = R.fields["fingerprint"], "p_state" = R.fields["p_state"], "m_state" = R.fields["m_state"], "blood_type" = M.fields["blood_type"], "dna" = M.fields["b_dna"], "minor_disabilities" = M.fields["mi_dis"], "minor_disabilities_details" = M.fields["mi_dis_d"], "major_disabilities" = M.fields["ma_dis"], "major_disabilities_details" = M.fields["ma_dis_d"], "allergies" = M.fields["alg"], "allergies_details" = M.fields["alg_d"], "current_diseases" = M.fields["cdi"], "current_diseases_details" = M.fields["cdi_d"], "important_notes" = M.fields["notes"])
+					med_record += list(new_record)
+					qdel(new_record)
+					break
+	if(GLOB.data_core.general && GLOB.data_core.security)
+		for(var/datum/data/record/S in sortRecord(GLOB.data_core.security))
+			for(var/datum/data/record/R in sortRecord(GLOB.data_core.general))
+				if(R.fields["name"] == S.fields["name"])
+					var/list/crimes = list()
+					for(var/datum/data/crime/crime in S.fields["crimes"])
+						crimes += list("[crime.crimeName]: [crime.crimeDetails]")
+					var/list/comments = list()
+					for(var/datum/data/comment/comment in S.fields["comments"])
+						comments += list("[comment.commentText] - [comment.author] [comment.time]")
+					var/new_record = list("name" = R.fields["name"], "id" = R.fields["id"], "gender" = R.fields["gender"], "age" = R.fields["age"], "rank" = R.fields["rank"], "fingerprint" = R.fields["fingerprint"], "p_state" = R.fields["p_state"], "criminal_status" = S.fields["criminal"], "crimes" = crimes, "important_notes" = S.fields["notes"], "comments" = comments)
+					sec_record += list(new_record)
+					qdel(new_record)
+					break
+	data["med_records"] = med_record
+	data["sec_records"] = sec_record
 	return data
 
 /mob/living/silicon/pai/ui_act(action, params)

code/modules/modular_computers/hardware/paicard.dm

@@ -88,6 +88,7 @@
 		if("wipe")
 			var/confirm = tgui_alert(usr, "Are you CERTAIN you wish to delete the current personality? This action cannot be undone.", "Personality Wipe", list("Yes", "No"))
 			if(confirm == "Yes")
+				candidates_ready = null
 				if(pai)
 					to_chat(pai, span_warning("You feel yourself slipping away from reality."))
 					to_chat(pai, span_danger("Byte by byte you lose your sense of self."))
@@ -117,8 +118,9 @@
 				pai.key = candidate.key
 
 				card.setPersonality(pai)
+				candidates.Remove(candidate)
 				candidate = list("name" = candidate.name, "description"=candidate.description, "prefrole"=candidate.role, "ooccomments"=candidate.comments)
-				candidates.Remove(list(candidate))
+				SSpai.candidates.Remove(candidate)
 		if("setlaws")
 			var/newlaw = stripped_multiline_input(usr, "Enter any additional directives you would like your pAI personality to follow. Note that these directives will not override the personality's allegiance to its imprinted master. Conflicting directives will be ignored.", "pAI Directive Configuration", pai.laws.supplied[1], MAX_MESSAGE_LEN)
 			if(newlaw && pai)

tgui/packages/tgui/interfaces/PaiInterface.tsx

@@ -10,6 +10,43 @@ type Module = {
   cost: number;
 }
 
+type MedRecord = { /* This should probably be cut down, but it's all valid medical record information */
+  name: string;
+  id: string;
+  gender: string;
+  age: number;
+  fingerprint: string;
+  p_state: string;
+  m_state: string;
+  blood_type: string;
+  dna: string;
+  minor_disabilities: string;
+  minor_disabilities_details: string;
+  major_disabilities: string;
+  major_disabilities_details: string;
+  allergies: string;
+  allergies_details: string;
+  current_diseases: string;
+  current_diseases_details: string;
+  important_notes: string;
+  comments: string[];
+}
+
+type SecRecord = {
+  name: string;
+  id: string;
+  gender: string;
+  age: number;
+  rank: string;
+  fingerprint: string;
+  p_state: string;
+  m_state: string;
+  criminal_status: string;
+  crimes: string[];
+  important_notes: string;
+  comments: string[];
+}
+
 type Data = {
   modules: Data[];
   modules_list: Module[];
@@ -31,6 +68,8 @@ type Data = {
   minFrequency: number;
   maxFrequency: number;
   color: string;
+  med_records: MedRecord[];
+  sec_records: SecRecord[];
 }
 
 export const AirlockJackTextSwitch = params => {