fix + rebalancing

Author: SapphicOverload

code/_onclick/hud/screen_objects.dm

@@ -124,13 +124,13 @@
 	icon_state = "skill_menu"
 	screen_loc = ui_skill_menu
 	var/list/allocated_skills = list(
-		SKILL_PHYSIOLOGY = 0,
-		SKILL_MECHANICAL = 0,
-		SKILL_TECHNICAL = 0,
-		SKILL_SCIENCE = 0,
-		SKILL_FITNESS = 0,
+		SKILL_PHYSIOLOGY = EXP_NONE,
+		SKILL_MECHANICAL = EXP_NONE,
+		SKILL_TECHNICAL = EXP_NONE,
+		SKILL_SCIENCE = EXP_NONE,
+		SKILL_FITNESS = EXP_NONE,
 	)
-	var/allocated_points = 0
+	var/allocated_points = EXP_NONE
 
 /atom/movable/screen/skill_menu/Click()
 	ui_interact(usr)
@@ -164,15 +164,30 @@
 		CRASH("User ([user]) without a mind attempted to allocate skill points!")
 	switch(action)
 		if("confirm")
+			if(allocated_points > user.mind.skill_points)
+				stack_trace("[user] attempted to allocate [allocated_points] skill points when they only had [user.mind.skill_points] available!")
+				message_admins("[key_name_admin(user)] may have attempted an exploit to gain more skill points than intended!")
+				qdel(allocated_skills)
+				allocated_skills = list(
+					SKILL_PHYSIOLOGY = EXP_NONE,
+					SKILL_MECHANICAL = EXP_NONE,
+					SKILL_TECHNICAL = EXP_NONE,
+					SKILL_SCIENCE = EXP_NONE,
+					SKILL_FITNESS = EXP_NONE,
+				)
+				allocated_points = EXP_NONE
+				return TRUE
 			for(var/skill in user.mind.skills)
 				user.adjust_skill(skill, allocated_skills[skill], max_skill = EXP_GENIUS)
-				allocated_skills[skill] = 0
+				allocated_skills[skill] = EXP_NONE
 			user.mind.skill_points -= allocated_points
-			allocated_points = 0
+			allocated_points = EXP_NONE
 			if(!user.mind.skill_points)
 				user.clear_alert("skill points")
 			return TRUE
 		if("allocate")
+			if(allocated_points + params["amount"] > user.mind.skill_points)
+				return TRUE
 			allocated_skills[params["skill"]] += params["amount"]
 			allocated_points += params["amount"]
 			return TRUE

code/game/mecha/mecha_wreckage.dm

@@ -30,7 +30,12 @@
 
 /obj/structure/mecha_wreckage/examine(mob/user)
 	. = ..()
-	. += span_danger("There was no capacitor to save this poor mecha from its doomed fate! It cannot be repaired!")
+	var/damage_msg = "There was no capacitor to save this poor mecha from its doomed fate"
+	if(user.skill_check(SKILL_MECHANICAL, EXP_GENIUS) || user.skill_check(SKILL_MECHANICAL, EXP_GENIUS))
+		damage_msg = ", but you think you could get it working again..."
+	else
+		damage_msg = "! It cannot be repaired!"
+	. += span_warning(damage_msg)
 
 /obj/structure/mecha_wreckage/gygax
 	name = "\improper Gygax wreckage"

code/modules/jobs/job_types/botanist.dm

@@ -26,7 +26,7 @@
 		SKILL_SCIENCE = EXP_MID,
 		SKILL_FITNESS = EXP_LOW,
 	)
-	skill_points = 2
+	skill_points = 3
 
 	departments_list = list(
 		/datum/job_department/service,

code/modules/jobs/job_types/chemist.dm

@@ -28,10 +28,10 @@
 		SKILL_PHYSIOLOGY = EXP_LOW,
 		SKILL_MECHANICAL = EXP_NONE,
 		SKILL_TECHNICAL = EXP_NONE,
-		SKILL_SCIENCE = EXP_HIGH,
+		SKILL_SCIENCE = EXP_MID,
 		SKILL_FITNESS = EXP_NONE,
 	)
-	skill_points = 2
+	skill_points = 3
 
 	departments_list = list(
 		/datum/job_department/medical,

code/modules/jobs/job_types/head_of_security.dm

@@ -44,7 +44,7 @@
 		SKILL_SCIENCE = EXP_NONE,
 		SKILL_FITNESS = EXP_HIGH,
 	)
-	skill_points = 1 // officers don't really have much to do
+	skill_points = 2 // officers don't really have much to do
 
 	departments_list = list(
 		/datum/job_department/security,

code/modules/jobs/job_types/medical_doctor.dm

@@ -32,9 +32,10 @@
 		SKILL_PHYSIOLOGY = EXP_HIGH,
 		SKILL_MECHANICAL = EXP_NONE,
 		SKILL_TECHNICAL = EXP_NONE,
-		SKILL_SCIENCE = EXP_LOW,
+		SKILL_SCIENCE = EXP_NONE,
 		SKILL_FITNESS = EXP_NONE,
 	)
+	skill_points = 3
 
 	mail_goodies = list(
 		/obj/item/healthanalyzer/advanced = 15,

code/modules/jobs/job_types/roboticist.dm

@@ -26,11 +26,11 @@
 	base_skills = list(
 		SKILL_PHYSIOLOGY = EXP_NONE,
 		SKILL_MECHANICAL = EXP_LOW,
-		SKILL_TECHNICAL = EXP_MID,
+		SKILL_TECHNICAL = EXP_LOW,
 		SKILL_SCIENCE = EXP_LOW,
 		SKILL_FITNESS = EXP_NONE,
 	)
-	skill_points = 2
+	skill_points = 3
 
 	departments_list = list(
 		/datum/job_department/science,

code/modules/jobs/job_types/security_officer.dm

@@ -33,9 +33,9 @@
 		SKILL_MECHANICAL = EXP_NONE,
 		SKILL_TECHNICAL = EXP_NONE,
 		SKILL_SCIENCE = EXP_NONE,
-		SKILL_FITNESS = EXP_HIGH,
+		SKILL_FITNESS = EXP_MID,
 	)
-	skill_points = 1 // officers don't really have much to do
+	skill_points = 2 // officers don't really have much to do
 
 	departments_list = list(
 		/datum/job_department/security,

code/modules/jobs/job_types/warden.dm

@@ -37,7 +37,7 @@
 		SKILL_SCIENCE = EXP_NONE,
 		SKILL_FITNESS = EXP_HIGH,
 	)
-	skill_points = 1 // officers don't really have much to do
+	skill_points = 2 // officers don't really have much to do
 
 	departments_list = list(
 		/datum/job_department/security,