[BUGFIX] Removes depreciated /Crossed and replaces it with /proc/on_entered for most tile-based-crossing things (#21499)

* save this all

yes

* ok

this is mostly all of it

Author: cowbot92

code/game/objects/effects/alien_acid.dm

@@ -23,6 +23,11 @@
 	pixel_x = target.pixel_x + rand(-4,4)
 	pixel_y = target.pixel_y + rand(-4,4)
 
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 	START_PROCESSING(SSobj, src)
 
 
@@ -52,8 +57,8 @@
 		qdel(src)
 		return 0
 
-/obj/effect/acid/Crossed(AM as mob|obj)
-	. = ..()
+/obj/effect/acid/proc/on_entered(datum/source, atom/movable/AM, ...)
+
 	if(isliving(AM))
 		var/mob/living/L = AM
 		if(L.movement_type & FLYING)

code/game/objects/effects/anomalies.dm

@@ -109,6 +109,13 @@
 	density = FALSE
 	var/boing = 0
 
+/obj/effect/anomaly/grav/Initialize(mapload)
+	. = ..()
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/effect/anomaly/grav/anomalyEffect()
 	..()
 	boing = 1
@@ -126,8 +133,7 @@
 			if(target && !target.stat)
 				O.throw_at(target, 5, 10)
 
-/obj/effect/anomaly/grav/Crossed(atom/movable/AM)
-	. = ..()
+/obj/effect/anomaly/grav/proc/on_entered(datum/source, atom/movable/AM, ...)
 	gravShock(AM)
 
 /obj/effect/anomaly/grav/Bump(atom/A)
@@ -171,6 +177,13 @@
 /obj/effect/anomaly/flux/explosion
 	explosive = ANOMALY_FLUX_EXPLOSION
 
+/obj/effect/anomaly/flux/Initialize(mapload)
+	. = ..()
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/effect/anomaly/flux/anomalyEffect(delta_time)
 	..()
 	canshock = 1
@@ -179,8 +192,7 @@
 	if(prob(delta_time * 2)) // shocks everyone nearby
 		tesla_zap(src, 5, shockdamage*500, TESLA_MOB_DAMAGE)
 
-/obj/effect/anomaly/flux/Crossed(atom/movable/AM)
-	. = ..()
+/obj/effect/anomaly/flux/proc/on_entered(datum/source, atom/movable/AM, ...)
 	mobShock(AM)
 
 /obj/effect/anomaly/flux/Bump(atom/A)

code/game/objects/effects/step_triggers.dm

@@ -7,11 +7,17 @@
 	invisibility = INVISIBILITY_ABSTRACT // nope cant see this shit
 	anchored = TRUE
 
+/obj/effect/step_trigger/Initialize(mapload)
+	. = ..()
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/effect/step_trigger/proc/Trigger(atom/movable/A)
 	return 0
 
-/obj/effect/step_trigger/Crossed(H as mob|obj)
-	..()
+/obj/effect/step_trigger/proc/on_entered(datum/source, atom/movable/H, ...)
 	if(!H)
 		return
 	if(isobserver(H) && !affect_ghosts)

code/game/objects/items/devices/transfer_valve.dm

@@ -14,6 +14,13 @@
 	var/valve_open = FALSE
 	var/toggle = TRUE
 
+/obj/item/transfer_valve/Initialize(mapload)
+	. = ..()
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/item/transfer_valve/Destroy()
 	attached_device = null
 	return ..()
@@ -70,8 +77,7 @@
 	if(attached_device)
 		attached_device.on_found(finder)
 
-/obj/item/transfer_valve/Crossed(atom/movable/AM as mob|obj)
-	. = ..()
+/obj/item/transfer_valve/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(attached_device)
 		attached_device.Crossed(AM)
 

code/game/objects/items/grenades/plastic.dm

@@ -25,6 +25,10 @@
 	. = ..()
 	ADD_TRAIT(src, TRAIT_EMPPROOF_CONTENTS, "innate_empproof")
 	plastic_overlay = mutable_appearance(icon, "[item_state]2", ABOVE_ALL_MOB_LAYER)
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
 
 /obj/item/grenade/plastic/Destroy()
 	qdel(nadeassembly)
@@ -80,8 +84,7 @@
 /obj/item/grenade/plastic/receive_signal()
 	prime()
 
-/obj/item/grenade/plastic/Crossed(atom/movable/AM)
-	. = ..()
+/obj/item/grenade/plastic/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(nadeassembly)
 		nadeassembly.Crossed(AM)
 

code/game/objects/items/puzzle_pieces.dm

@@ -137,6 +137,10 @@
 	. = ..()
 	if(undertile_pressureplate)
 		AddElement(/datum/element/undertile, tile_overlay = tile_overlay, use_anchor = FALSE) //we remove use_anchor here, so it ALWAYS stays anchored
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
 
 /obj/item/pressure_plate/hologrid/examine(mob/user)
 	. = ..()
@@ -148,8 +152,7 @@
 	flick("lasergrid_a",src)
 	icon_state = "lasergrid_full"
 
-/obj/item/pressure_plate/hologrid/Crossed(atom/movable/AM)
-	. = ..()
+/obj/item/pressure_plate/hologrid/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(trigger_item && istype(AM, specific_item) && !claimed)
 		claimed = TRUE
 		flick("laserbox_burn", AM)

code/game/objects/items/tanks/tanks.dm

@@ -74,6 +74,11 @@
 	air_contents = new(volume) //liters
 	air_contents.set_temperature(T20C)
 
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 	populate_gas()
 
 	START_PROCESSING(SSobj, src)
@@ -367,8 +372,7 @@
 
 //Assembly / attached device memes
 
-/obj/item/tank/Crossed(atom/movable/AM) //for mousetraps
-	..()
+/obj/item/tank/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(tank_assembly)
 		tank_assembly.Crossed(AM)
 

code/game/objects/structures/shower.dm

@@ -22,6 +22,11 @@
 
 	soundloop = new(list(src), FALSE)
 
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/machinery/shower/Destroy()
 	QDEL_NULL(soundloop)
 	QDEL_NULL(reagents)
@@ -95,8 +100,7 @@
 		qdel(mist)
 
 
-/obj/machinery/shower/Crossed(atom/movable/AM)
-	..()
+/obj/machinery/shower/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(on)
 		wash_atom(AM)
 

code/game/objects/structures/tables_racks.dm

@@ -270,13 +270,16 @@
 	. = ..()
 	debris += new frame
 	debris += new /obj/item/shard
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
 
 /obj/structure/table/glass/Destroy()
 	QDEL_LIST(debris)
 	. = ..()
 
-/obj/structure/table/glass/Crossed(atom/movable/AM)
-	. = ..()
+/obj/structure/table/glass/proc/on_entered(datum/source, atom/movable/AM, ...)
 	if(flags_1 & NODECONSTRUCT_1)
 		return
 	if(!isliving(AM))

code/game/objects/structures/traps.dm

@@ -27,6 +27,12 @@
 			/obj/effect,
 			/mob/dead))
 
+	var/static/list/loc_connections = list(
+		COMSIG_ATOM_ENTERED = PROC_REF(on_entered),
+		COMSIG_ATOM_ENTERED = PROC_REF(on_trap_entered)
+	)
+	AddElement(/datum/element/connect_loc, loc_connections)
+
 /obj/structure/trap/Destroy()
 	qdel(spark_system)
 	spark_system = null
@@ -56,8 +62,7 @@
 	else
 		animate(src, alpha = initial(alpha), time = time_between_triggers)
 
-/obj/structure/trap/Crossed(atom/movable/AM)
-	. = ..()
+/obj/structure/trap/proc/on_trap_entered(datum/source, atom/movable/AM, ...)
 	if(last_trigger + time_between_triggers > world.time)
 		return
 	// Don't want the traps triggered by sparks, ghosts or projectiles.