skill issue

to do:
-chemistry
-virology
-balance stuff
-??? i forgor

Author: SapphicOverload

code/__DEFINES/skills.dm

@@ -0,0 +1,29 @@
+
+/// Medicine and surgery.
+#define SKILL_PHYSIOLOGY "physiology"
+/// Construction and repair of structures and machinery.
+#define SKILL_MECHANICAL "mechanics"
+/// Hacking, piloting, and robotic maintenance.
+#define SKILL_TECHNICAL "technical"
+/// Chemistry, botany, physics, and other sciences.
+#define SKILL_SCIENCE "science"
+/// Strength, endurance, accuracy.
+#define SKILL_FITNESS "fitness"
+
+/// No experience whatsoever.
+#define EXP_NONE 0
+/// Some experience, but not much.
+#define EXP_LOW 1
+/// Enough experience to do a decent job.
+#define EXP_MID 2
+/// Above average skill level.
+#define EXP_HIGH 3
+/// Exceptionally skilled.
+#define EXP_MASTER 4
+/// Uniquely gifted. Not obtainable through normal means.
+#define EXP_GENIUS 5
+
+/// Experience required to increase your skills by one level. Increases exponentially the higher your level already is.
+#define EXPERIENCE_PER_LEVEL 200
+
+#define SKILL_TO_ACTION_SPEED(skill_level) ((12 - skill_level) / 10)

code/__DEFINES/traits/declarations.dm

@@ -109,6 +109,8 @@
 #define TRAIT_IGNOREDAMAGESLOWDOWN "ignoredamageslowdown"
 /// Makes the screen go black and white while illuminating all mobs based on their body temperature
 #define TRAIT_INFRARED_VISION	"infrared_vision"
+/// Punches don't stun. Use this instead of setting punchstunchance to zero.
+#define TRAIT_NO_PUNCH_STUN "no-punch-stun"
 
 ////////////////////////////////////////////////////////////////////////////////////
 //-------------------------Species Specific defines-------------------------------//
@@ -440,6 +442,10 @@
 #define TRAIT_PRESENT_VISION "present-vision"
 #define TRAIT_DISK_VERIFIER "disk-verifier"
 #define TRAIT_NOMOBSWAP "no-mob-swap"
+/// Can allocate 5 points into one skill instead of the usual 4
+#define TRAIT_EXCEPTIONAL_SKILL "exceptional-skill"
+/// Acts as an additional skill point for piloting mechs, up to EXP_MASTER.
+#define TRAIT_SKILLED_PILOT "skilled-pilot"
 /// Can examine IDs to see if they are roundstart.
 #define TRAIT_ID_APPRAISER "id_appraiser"
 /// Gives us turf, mob and object vision through walls

code/__HELPERS/mobs.dm

@@ -319,7 +319,7 @@ GLOBAL_LIST_EMPTY(species_list)
  * given `delay`. Returns `TRUE` on success or `FALSE` on failure.
  * Interaction_key is the assoc key under which the do_after is capped, with max_interact_count being the cap. Interaction key will default to target if not set.
  */
-/proc/do_after(mob/user, delay, atom/target, timed_action_flags = NONE, progress = TRUE, datum/callback/extra_checks, interaction_key, max_interact_count = 1)
+/proc/do_after(mob/user, delay, atom/target, timed_action_flags = NONE, progress = TRUE, datum/callback/extra_checks, interaction_key, max_interact_count = 1, skill_check = null)
 	if(!user)
 		return FALSE
 	if(!isnum(delay))
@@ -344,6 +344,9 @@ GLOBAL_LIST_EMPTY(species_list)
 
 	if(!(timed_action_flags & IGNORE_SLOWDOWNS))
 		delay *= user.action_speed_modifier * user.do_after_coefficent() //yogs: darkspawn
+	
+	if(skill_check && user.mind)
+		delay *= (12 - user.get_skill(skill_check)) / 10
 
 	var/datum/progressbar/progbar
 	if(progress)
@@ -378,6 +381,9 @@ GLOBAL_LIST_EMPTY(species_list)
 			. = FALSE
 			break
 
+	if(skill_check) // get better at things by practicing them
+		user.add_exp(skill_check, delay)
+
 	if(!QDELETED(progbar))
 		progbar.end_progress()
 

code/_onclick/hud/alert.dm

@@ -322,6 +322,74 @@ or shoot a gun to move around via Newton's 3rd Law of Motion."
 	var/mob/living/carbon/C = mob_viewer
 	C.take(giver, receiving)
 
+//SKILLS
+
+/atom/movable/screen/alert/skill_up
+	name = "Allocate Skill Points"
+	desc = "You have unspent skill points! Click here to allocate them."
+	var/list/allocated_skills = list(
+		SKILL_PHYSIOLOGY = 0,
+		SKILL_MECHANICAL = 0,
+		SKILL_TECHNICAL = 0,
+		SKILL_SCIENCE = 0,
+		SKILL_FITNESS = 0,
+	)
+	var/allocated_points = 0
+
+/atom/movable/screen/alert/skill_up/Click(location, control, params)
+	. = ..()
+	ui_interact(mob_viewer)
+
+/atom/movable/screen/alert/skill_up/ui_interact(mob/user, datum/tgui/ui)
+	ui = SStgui.try_update_ui(user, src, ui)
+	if (!ui)
+		ui = new(user, src, "SkillMenu", "Allocate Skill Points")
+		ui.open()
+
+/atom/movable/screen/alert/skill_up/ui_data(mob/user)
+	var/list/data = list()
+	var/list/skill_data = list()
+	for(var/skill in user.mind.skills)
+		skill_data.Add(list(list(
+			"base" = user.get_skill(skill),
+			"allocated" = allocated_skills[skill],
+		)))
+	data["skills"] = skill_data
+	data["skill_points"] = user.mind.skill_points
+	data["allocated_points"] = allocated_points
+	data["exceptional_skill"] = HAS_TRAIT(user, TRAIT_EXCEPTIONAL_SKILL)
+	return data
+
+/atom/movable/screen/alert/skill_up/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
+	. = ..()
+	if(.)
+		return
+	var/mob/user = usr
+	if(!user.mind)
+		CRASH("User ([user]) without a mind attempted to allocate skill points!")
+	switch(action)
+		if("confirm")
+			for(var/skill in user.mind.skills)
+				user.adjust_skill(skill, allocated_skills[skill], max_skill = EXP_GENIUS)
+				allocated_skills[skill] = 0
+			user.mind.skill_points -= allocated_points
+			allocated_points = 0
+			if(!user.mind.skill_points)
+				user.clear_alert("skill points")
+			return TRUE
+		if("allocate")
+			allocated_skills[params["skill"]] += params["amount"]
+			allocated_points += params["amount"]
+			return TRUE
+
+/atom/movable/screen/alert/skill_up/ui_status(mob/user)
+	if(!user.mind)
+		return UI_CLOSE
+	return UI_INTERACTIVE
+
+/atom/movable/screen/alert/skill_up/ui_state(mob/user)
+	return GLOB.always_state
+
 //ALIENS
 
 /atom/movable/screen/alert/alien_tox

code/controllers/subsystem/shuttle.dm

@@ -523,14 +523,14 @@ SUBSYSTEM_DEF(shuttle)
  * * dock_id - The ID of the destination (stationary docking port) to move to
  * * timed - If true, have the shuttle follow normal spool-up, jump, dock process. If false, immediately move to the new location.
  */
-/datum/controller/subsystem/shuttle/proc/moveShuttle(shuttle_id, dock_id, timed)
+/datum/controller/subsystem/shuttle/proc/moveShuttle(shuttle_id, dock_id, timed, skill_multiplier = 1)
 	var/obj/docking_port/mobile/shuttle_port = getShuttle(shuttle_id)
 	var/obj/docking_port/stationary/docking_target = getDock(dock_id)
 
 	if(!shuttle_port)
 		return DOCKING_NULL_SOURCE
 	if(timed)
-		if(shuttle_port.request(docking_target))
+		if(shuttle_port.request(docking_target, skill_multiplier))
 			return DOCKING_IMMOBILIZED
 	else
 		if(shuttle_port.initiate_docking(docking_target) != DOCKING_SUCCESS)

code/datums/components/blocking.dm

@@ -220,6 +220,8 @@
 		if(!blocking_component.can_block(defender, incoming, damage, attack_type))
 			return 0
 		force_returned = blocking_component.block_force
+	if(attack_type & MELEE_ATTACK) // being stronger provides a small increase to melee blocking
+		force_returned += defender.get_skill(SKILL_FITNESS)
 	if(HAS_TRAIT(weapon, TRAIT_PARRYING))
 		force_returned *= PARRY_BONUS
 	return max(force_returned - max(armour_penetration - weapon.armour_penetration, 0) * AP_TO_FORCE, 0)

code/datums/components/mech_pilot.dm

@@ -57,7 +57,7 @@
 				fullpower = TRUE
 				H.physiology.punchdamagehigh_bonus += 4
 				H.physiology.punchdamagelow_bonus += 4
-				H.physiology.punchstunthreshold_bonus += 1				//Makes standard punches 5-14 with higher stun chance (1-10, stun on 10 -> 5-14, stun on 11-14)
+				H.physiology.punchstunchance_bonus += 0.4				//Makes standard punches 5-14 with higher stun chance (1-10, stun on 10 -> 5-14, stun on 11-14)
 				H.physiology.brute_mod *= 0.6
 				H.physiology.burn_mod *= 0.6
 				H.physiology.heat_mod *= 0.6
@@ -103,7 +103,7 @@
 		H.remove_movespeed_modifier(MOVESPEED_ID_NECRO_VIRUS_SLOWDOWN)
 		H.physiology.punchdamagehigh_bonus -= 4
 		H.physiology.punchdamagelow_bonus -= 4
-		H.physiology.punchstunthreshold_bonus -= 1
+		H.physiology.punchstunchance_bonus -= 0.4
 		H.physiology.brute_mod /= 0.6
 		H.physiology.burn_mod /= 0.6
 		H.physiology.heat_mod /= 0.6

code/datums/diseases/advance/symptoms/necropolis.dm

@@ -101,8 +101,8 @@
   * used for basic punch attacks
   */
 /datum/martial_art/proc/basic_hit(mob/living/carbon/human/A,mob/living/carbon/human/D)
-
-	var/damage = rand(A.get_punchdamagelow(), A.get_punchdamagehigh())
+	var/percentile = rand()
+	var/damage = LERP(A.get_punchdamagelow(), A.get_punchdamagehigh(), percentile)
 
 	var/atk_verb = pick(A.dna.species.attack_verbs)
 	var/atk_effect = A.dna.species.attack_effect
@@ -129,7 +129,7 @@
 
 	log_combat(A, D, "punched")
 
-	if((D.stat != DEAD) && damage >= A.get_punchstunthreshold())
+	if((D.stat != DEAD) && percentile > (1 - A.get_punchstunchance()) && !HAS_TRAIT(A, TRAIT_NO_PUNCH_STUN))
 		D.visible_message(span_danger("[A] has knocked [D] down!!"), \
 								span_userdanger("[A] has knocked [D] down!"))
 		D.apply_effect(40, EFFECT_KNOCKDOWN, armor_block)

code/datums/martial.dm

@@ -8,7 +8,7 @@
 	id = MARTIALART_LIGHTNINGFLOW
 	no_guns = TRUE
 	help_verb = /mob/living/carbon/human/proc/lightning_flow_help
-	martial_traits = list(TRAIT_STRONG_GRABBER)
+	martial_traits = list(TRAIT_STRONG_GRABBER, TRAIT_NO_PUNCH_STUN)
 	var/dashing = FALSE
 	COOLDOWN_DECLARE(action_cooldown)
 	var/list/action_modifiers = list()
@@ -147,15 +147,13 @@
 		var/mob/living/carbon/human/user = H
 		user.physiology.punchdamagelow_bonus += 5
 		user.physiology.punchdamagehigh_bonus += 5
-		user.physiology.punchstunthreshold_bonus += 6 //no knockdowns
 
 /datum/martial_art/lightning_flow/on_remove(mob/living/carbon/human/H)
 	UnregisterSignal(H, COMSIG_MOB_CLICKON)
 	if(ishuman(H))//it's already a human, but it won't let me access physiology for some reason
 		var/mob/living/carbon/human/user = H
 		user.physiology.punchdamagelow_bonus -= 5
 		user.physiology.punchdamagehigh_bonus -= 5
-		user.physiology.punchstunthreshold_bonus -= 6
 	return ..()
 
 #undef ACTION_DELAY