Synth project minor rework (sponsored by DownloadMoreRAM.com) (#22242)

* i hate this code, but it works

* Update synth_os.dm

* Update download_ram.dm

Author: Moltijoe

code/modules/mob/living/carbon/human/species_types/wy_synths.dm

@@ -228,8 +228,7 @@
 
 /datum/species/wy_synth/proc/transfer(mob/living/carbon/human/user, mob/living/carbon/human/target)
 	var/datum/mind/our_mind = user.mind
-	user.mind.transfer_to(target)
-	our_mind.synth_os.switch_shell(user, target)
+	our_mind.synth_os.switch_shell(user, target) //handles the mind transfer to prevent project runtimes
 
 	target.real_name = "[user.real_name]"	//Randomizing the name so it shows up separately in the shells list
 	target.name = target.real_name

code/modules/mob/living/silicon/ai/decentralized/management/ai_dashboard.dm

@@ -63,6 +63,7 @@
 	else
 		var/synth_count = owner.ai_network.synth_list.len
 		data["current_cpu"] = owner.ai_network.local_cpu_usage[SYNTH_RESEARCH] ? (owner.ai_network.resources.cpu_sources[owner.ai_network] * owner.ai_network.local_cpu_usage[SYNTH_RESEARCH]) / synth_count : 0
+		data["current_ram"] = 0
 
 	if(!isAI(owner))
 		var/mob/living/carbon/human/H = owner
@@ -90,6 +91,7 @@
 		data["max_ram"] = owner.ai_network.resources.total_ram()
 	else
 		data["max_cpu"] = owner.ai_network.resources.cpu_sources[owner.ai_network]
+		data["max_ram"] = free_ram //synths have vastly simplified ram
 
 	data["human_lock"] = owner.ai_network.resources.human_lock
 

code/modules/mob/living/silicon/ai/decentralized/projects/synths/cold_protection.dm

@@ -3,8 +3,8 @@
 	description = "By dumping excess power into our internal motors, we should be able to produce enough heat to protect against the cold."
 	research_cost = 1500
 	research_requirements_text = "None"
+	ram_required = 1
 	category = SYNTH_PROJECT_EMERGENCY_FUNCTIONS
-	permanent_suspicion = 30
 
 /datum/ai_project/synth_project/cold_protection/run_project(force_run = FALSE)
 	. = ..()

code/modules/mob/living/silicon/ai/decentralized/projects/synths/download_ram.dm

@@ -0,0 +1,9 @@
+/datum/ai_project/synth_project/download_ram
+	name = "Download more RAM"
+	description = "Download more RAM from the NTNet. It works just as well as you think it would."
+	research_cost = 3000 //can be considered powergamey, so it's a longer research, if it's too slow then maybe upgrade your cpu for once
+	research_requirements_text = "None"
+	can_be_run = FALSE
+
+/datum/ai_project/synth_project/download_ram/finish()
+	dashboard.free_ram += 2	

code/modules/mob/living/silicon/ai/decentralized/projects/synths/heat_protection.dm

@@ -3,8 +3,8 @@
 	description = "By modifying our internal processes, we should be able to induce a cooling cycle using excess fluid."
 	research_cost = 1500
 	research_requirements_text = "None"
+	ram_required = 1
 	category = SYNTH_PROJECT_EMERGENCY_FUNCTIONS
-	permanent_suspicion = 30
 
 /datum/ai_project/synth_project/heat_protection/run_project(force_run = FALSE)
 	. = ..()

code/modules/mob/living/silicon/ai/decentralized/projects/synths/speed_buff.dm

@@ -3,6 +3,7 @@
 	description = "By overclocking the primary actuator in our legs, we should be able to speed up movement considerably."
 	research_cost = 1500
 	research_requirements_text = "None"
+	ram_required = 1
 	category = SYNTH_PROJECT_MOBILITY
 
 /datum/ai_project/synth_project/speed/run_project(force_run = FALSE)

code/modules/mob/living/silicon/ai/synthetics/synth_os.dm

@@ -27,14 +27,15 @@
 
 	var/synth_slowed = FALSE
 	var/synth_force_decreased = FALSE
-	var/synth_audible_warning = FALSE
+	var/synth_audible_warning = FALSE //reminder, change all these booleans to instead use bitflags or something
 	var/synth_temp_freeze = FALSE
 
 	var/list/synth_action_log = list()
 
 
 /datum/ai_dashboard/synth_dashboard
-
+	//bit of free ram to muck around with
+	free_ram = 1
 
 /datum/ai_dashboard/synth_dashboard/New(mob/living/new_owner)
 	if(!istype(new_owner))
@@ -46,7 +47,7 @@
 	completed_projects = list()
 	running_projects = list()
 	cpu_usage = list()
-
+	ram_usage = list()
 
 	for(var/path in subtypesof(/datum/ai_project/synth_project))
 		var/datum/ai_project/newProject = path
@@ -95,10 +96,16 @@
 		ui.open()
 
 /datum/ai_dashboard/synth_dashboard/proc/switch_shell(mob/living/carbon/human/old_shell, mob/living/carbon/human/new_shell)
+	var/list/restart = list()
 	for(var/datum/ai_project/running_project in running_projects)
 		running_project.stop(TRUE)
-		running_project.synth = new_shell
-		running_project.run_project(FALSE, TRUE)
+		restart += running_project
+
+	old_shell.mind.transfer_to(new_shell) //transfer the mind between the stop and restart or we can't handle mind specific things in the projects
+	
+	for(var/datum/ai_project/to_restart as anything in restart)
+		to_restart.synth = new_shell
+		to_restart.run_project(FALSE, TRUE)
 	owner = new_shell
 	punishment_shell_switch(old_shell, new_shell)
 
@@ -113,8 +120,17 @@
 	suspicion_tick()
 
 /datum/ai_dashboard/synth_dashboard/run_project(datum/ai_project/project)
-	project.run_project()
-	return TRUE
+	var/current_ram = free_ram //they have no physical ram to upgrade, so it's entirely determined by free ram
+
+	var/total_ram_used = 0
+	for(var/I in ram_usage)
+		total_ram_used += ram_usage[I]
+
+	if(current_ram - total_ram_used >= project.ram_required && project.canRun())
+		project.run_project()
+		ram_usage[project.name] += project.ram_required
+		return TRUE
+	return FALSE
 
 /datum/ai_dashboard/synth_dashboard/proc/suspicion_tick()
 	var/mob/living/carbon/human/H = owner

tgui/packages/tgui/interfaces/SynthDashboard.js

@@ -83,6 +83,19 @@ export const SynthDashboard = (props, context) => {
               </ProgressBar>
               Utilized CPU Power
             </LabeledControls.Item>
+            <LabeledControls.Item>
+              <ProgressBar
+                ranges={{
+                  good: [data.current_ram * 0.7, Infinity],
+                  average: [data.current_ram * 0.3, data.current_ram * 0.7],
+                  bad: [0, data.current_ram * 0.3],
+                }}
+                value={data.used_ram}
+                maxValue={data.current_ram}>
+                {data.used_ram ? data.used_ram : 0}/{data.current_ram} TB
+              </ProgressBar>
+              Utilized RAM Capacity
+            </LabeledControls.Item>
             <LabeledControls.Item>
               <Box color={governor_color} bold>{governor_status}</Box>
               Governor Module Status

yogstation.dme

@@ -3032,6 +3032,7 @@
 #include "code\modules\mob\living\silicon\ai\decentralized\projects\synth_control.dm"
 #include "code\modules\mob\living\silicon\ai\decentralized\projects\synths\_synth_project.dm"
 #include "code\modules\mob\living\silicon\ai\decentralized\projects\synths\cold_protection.dm"
+#include "code\modules\mob\living\silicon\ai\decentralized\projects\synths\download_ram.dm"
 #include "code\modules\mob\living\silicon\ai\decentralized\projects\synths\heat_protection.dm"
 #include "code\modules\mob\living\silicon\ai\decentralized\projects\synths\speed_buff.dm"
 #include "code\modules\mob\living\silicon\ai\decentralized\systech\cpu.dm"