caller

Author: JohnFulpWillard

code/__HELPERS/AStar.dm

@@ -74,33 +74,33 @@ Actual Adjacent procs :
 	return b.f - a.f
 
 //wrapper that returns an empty list if A* failed to find a path
-/proc/get_path_to(caller, end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE, get_best_attempt = FALSE)
-	var/l = SSpathfinder.mobs.getfree(caller)
+/proc/get_path_to(caller_but_not_a_byond_built_in_proc, end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE, get_best_attempt = FALSE)
+	var/l = SSpathfinder.mobs.getfree(caller_but_not_a_byond_built_in_proc)
 	while(!l)
 		stoplag(3)
-		l = SSpathfinder.mobs.getfree(caller)
-	var/list/path = AStar(caller, end, dist, maxnodes, maxnodedepth, mintargetdist, adjacent,id, exclude, simulated_only, get_best_attempt)
+		l = SSpathfinder.mobs.getfree(caller_but_not_a_byond_built_in_proc)
+	var/list/path = AStar(caller_but_not_a_byond_built_in_proc, end, dist, maxnodes, maxnodedepth, mintargetdist, adjacent,id, exclude, simulated_only, get_best_attempt)
 	SSpathfinder.mobs.found(l)
 	if(!path)
 		path = list()
 	return path
 
-/proc/cir_get_path_to(caller, end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE)
-	var/l = SSpathfinder.circuits.getfree(caller)
+/proc/cir_get_path_to(caller_but_not_a_byond_built_in_proc, end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE)
+	var/l = SSpathfinder.circuits.getfree(caller_but_not_a_byond_built_in_proc)
 	while(!l)
 		stoplag(3)
-		l = SSpathfinder.circuits.getfree(caller)
-	var/list/path = AStar(caller, end, dist, maxnodes, maxnodedepth, mintargetdist, adjacent,id, exclude, simulated_only)
+		l = SSpathfinder.circuits.getfree(caller_but_not_a_byond_built_in_proc)
+	var/list/path = AStar(caller_but_not_a_byond_built_in_proc, end, dist, maxnodes, maxnodedepth, mintargetdist, adjacent,id, exclude, simulated_only)
 	SSpathfinder.circuits.found(l)
 	if(!path)
 		path = list()
 	return path
 
 /// Pathfinding for bots
-/proc/AStar(caller, _end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE, get_best_attempt = FALSE)
+/proc/AStar(caller_but_not_a_byond_built_in_proc, _end, dist, maxnodes, maxnodedepth = 30, mintargetdist, adjacent = /turf/proc/reachableTurftest, id=null, turf/exclude=null, simulated_only = TRUE, get_best_attempt = FALSE)
 	//sanitation
 	var/turf/end = get_turf(_end)
-	var/turf/start = get_turf(caller)
+	var/turf/start = get_turf(caller_but_not_a_byond_built_in_proc)
 	if(!start || !end)
 		stack_trace("Invalid A* start or destination")
 		return FALSE
@@ -150,12 +150,12 @@ Actual Adjacent procs :
 						//is already in open list, check if it's a better way from the current turf
 							CN.bf &= 15^r //we have no closed, so just cut off exceed dir.00001111 ^ reverse_dir.We don't need to expand to checked turf.
 							if((newg < CN.g) )
-								if(call(cur.source,adjacent)(caller, T, id, simulated_only))
+								if(call(cur.source,adjacent)(caller_but_not_a_byond_built_in_proc, T, id, simulated_only))
 									CN.setp(cur,newg,CN.h,cur.nt+1)
 									open.ReSort(CN)//reorder the changed element in the list
 						else
 						//is not already in open list, so add it
-							if(call(cur.source,adjacent)(caller, T, id, simulated_only))
+							if(call(cur.source,adjacent)(caller_but_not_a_byond_built_in_proc, T, id, simulated_only))
 								CN = new(T,cur,newg,call(T,dist)(end),cur.nt+1,15^r)
 								open.Insert(CN)
 								openc[T] = CN
@@ -179,8 +179,8 @@ Actual Adjacent procs :
 //Returns adjacent turfs in cardinal directions that are reachable
 //simulated_only controls whether only simulated turfs are considered or not
 
-/// Returns a list the src/caller can cross into
-/turf/proc/reachableAdjacentTurfs(caller, ID, simulated_only)
+/// Returns a list the src/caller_but_not_a_byond_built_in_proc can cross into
+/turf/proc/reachableAdjacentTurfs(caller_but_not_a_byond_built_in_proc, ID, simulated_only)
 	var/list/L = new()
 	var/turf/T
 	var/static/space_type_cache = typecacheof(/turf/open/space)
@@ -189,20 +189,20 @@ Actual Adjacent procs :
 		T = get_step(src,GLOB.cardinals[k])
 		if(!T || (simulated_only && space_type_cache[T.type]))
 			continue
-		if(!T.density && !LinkBlockedWithAccess(T,caller, ID))
+		if(!T.density && !LinkBlockedWithAccess(T,caller_but_not_a_byond_built_in_proc, ID))
 			L.Add(T)
 	return L
 
-/turf/proc/reachableTurftest(caller, turf/T, ID, simulated_only)
-	if(T && !T.density && !(simulated_only && SSpathfinder.space_type_cache[T.type]) && !LinkBlockedWithAccess(T,caller, ID))
+/turf/proc/reachableTurftest(caller_but_not_a_byond_built_in_proc, turf/T, ID, simulated_only)
+	if(T && !T.density && !(simulated_only && SSpathfinder.space_type_cache[T.type]) && !LinkBlockedWithAccess(T,caller_but_not_a_byond_built_in_proc, ID))
 		return TRUE
 
 /// Returns adjacent turfs in cardinal directions that are reachable via atmos
 /turf/proc/reachableAdjacentAtmosTurfs()
 	return atmos_adjacent_turfs
 
 /// Check if there is a door that needs access in its way
-/turf/proc/LinkBlockedWithAccess(turf/T, caller, ID)
+/turf/proc/LinkBlockedWithAccess(turf/T, caller_but_not_a_byond_built_in_proc, ID)
 	var/adir = get_dir(src, T)
 	var/rdir = ((adir & MASK_ODD)<<1)|((adir & MASK_EVEN)>>1)
 	for(var/obj/structure/window/W in src)
@@ -212,29 +212,29 @@ Actual Adjacent procs :
 		if(!W.CanAStarPass(ID, adir))
 			return TRUE
 	for(var/obj/machinery/M in src)
-		if(!M.CanAStarPass(ID, adir, caller))
+		if(!M.CanAStarPass(ID, adir, caller_but_not_a_byond_built_in_proc))
 			return TRUE
 	for(var/obj/machinery/door/firedoor/border_only/W in src)
-		if(!W.CanAStarPass(ID, adir, caller))
+		if(!W.CanAStarPass(ID, adir, caller_but_not_a_byond_built_in_proc))
 			return TRUE
 	for(var/obj/O in T)
-		if(!O.CanAStarPass(ID, rdir, caller))
+		if(!O.CanAStarPass(ID, rdir, caller_but_not_a_byond_built_in_proc))
 			return TRUE
 
 	return FALSE
 
 //yog procs
-/turf/proc/reachableTurftestPlayer(caller, turf/T, ID, simulated_only)
-	if(T && !T.density && !LinkBlockedWithAccess(T, caller, ID) && !(simulated_only && SSpathfinder.space_type_cache[T.type]))
+/turf/proc/reachableTurftestPlayer(caller_but_not_a_byond_built_in_proc, turf/T, ID, simulated_only)
+	if(T && !T.density && !LinkBlockedWithAccess(T, caller_but_not_a_byond_built_in_proc, ID) && !(simulated_only && SSpathfinder.space_type_cache[T.type]))
 		return TRUE
 
-/turf/proc/reachableTurftestdensity(caller, turf/T, ID, simulated_only) //used for the sake of pathfinding while excluding turfs with dense objects
-	if(T && !T.density && !(simulated_only && SSpathfinder.space_type_cache[T.type]) && !LinkBlockedWithAccess(T,caller, ID))
+/turf/proc/reachableTurftestdensity(caller_but_not_a_byond_built_in_proc, turf/T, ID, simulated_only) //used for the sake of pathfinding while excluding turfs with dense objects
+	if(T && !T.density && !(simulated_only && SSpathfinder.space_type_cache[T.type]) && !LinkBlockedWithAccess(T,caller_but_not_a_byond_built_in_proc, ID))
 		for(var/obj/D in T)
 			if(!istype(D, /obj/structure/window) && D.density) //had to do it silly like this so rwindows didn't stop it outright
 				return FALSE
 		return TRUE
 
-/turf/proc/wiringTurfTest(caller, turf/T, ID, simulated_only)
+/turf/proc/wiringTurfTest(caller_but_not_a_byond_built_in_proc, turf/T, ID, simulated_only)
 	if(T && !T.density && !istype(T.loc, /area/space))
 		return TRUE

code/_onclick/hud/parallax.dm

@@ -111,7 +111,7 @@
 	create_parallax(screen_mob)
 	update_parallax(screen_mob)
 
-// This sets which way the current shuttle is moving (returns true if the shuttle has stopped moving so the caller can append their animation)
+// This sets which way the current shuttle is moving (returns true if the shuttle has stopped moving so the caller_but_not_a_byond_built_in_proc can append their animation)
 /datum/hud/proc/set_parallax_movedir(new_parallax_movedir = 0, skip_windups, mob/viewmob)
 	. = FALSE
 	var/mob/screenmob = viewmob || mymob

code/datums/actions/cooldown_action.dm

@@ -224,7 +224,7 @@
 	return PreActivate(user)
 
 /// Intercepts client owner clicks to activate the ability
-/datum/action/cooldown/proc/InterceptClickOn(mob/living/caller, params, atom/target)
+/datum/action/cooldown/proc/InterceptClickOn(mob/living/caller_but_not_a_byond_built_in_proc, params, atom/target)
 	if(!IsAvailable(feedback = TRUE))
 		return FALSE
 	if(!target)
@@ -235,8 +235,8 @@
 
 	// And if we reach here, the action was complete successfully
 	if(unset_after_click)
-		unset_click_ability(caller, refund_cooldown = FALSE)
-	caller.next_click = world.time + click_cd_override
+		unset_click_ability(caller_but_not_a_byond_built_in_proc, refund_cooldown = FALSE)
+	caller_but_not_a_byond_built_in_proc.next_click = world.time + click_cd_override
 
 	return TRUE
 

code/datums/actions/innate_action.dm

@@ -76,17 +76,17 @@
 	on_who.click_intercept = null
 
 /// Handles whenever a mob clicks on something
-/datum/action/innate/proc/InterceptClickOn(mob/living/caller, params, atom/clicked_on)
+/datum/action/innate/proc/InterceptClickOn(mob/living/caller_but_not_a_byond_built_in_proc, params, atom/clicked_on)
 	if(!IsAvailable(feedback = TRUE))
-		unset_ranged_ability(caller)
+		unset_ranged_ability(caller_but_not_a_byond_built_in_proc)
 		return FALSE
 	if(!clicked_on)
 		return FALSE
 
-	return do_ability(caller, params, clicked_on)
+	return do_ability(caller_but_not_a_byond_built_in_proc, params, clicked_on)
 
 /// Actually goes through and does the click ability
-/datum/action/innate/proc/do_ability(mob/living/caller, params, atom/clicked_on)
+/datum/action/innate/proc/do_ability(mob/living/caller_but_not_a_byond_built_in_proc, params, atom/clicked_on)
 	return FALSE
 
 /datum/action/innate/Remove(mob/removed_from)

code/datums/holocall.dm

@@ -37,10 +37,10 @@
 	var/call_start_time
 	var/head_call = FALSE //calls from a head of staff autoconnect, if the recieving pad is not secure.
 
-//creates a holocall made by `caller` from `calling_pad` to `callees`
-/datum/holocall/New(mob/living/caller, obj/machinery/holopad/calling_pad, list/callees, elevated_access = FALSE)
+//creates a holocall made by `caller_but_not_a_byond_built_in_proc` from `calling_pad` to `callees`
+/datum/holocall/New(mob/living/caller_but_not_a_byond_built_in_proc, obj/machinery/holopad/calling_pad, list/callees, elevated_access = FALSE)
 	call_start_time = world.time
-	user = caller
+	user = caller_but_not_a_byond_built_in_proc
 	calling_pad.outgoing_call = src
 	calling_holopad = calling_pad
 	head_call = elevated_access
@@ -302,7 +302,7 @@
 		var/datum/preset_holoimage/H = new preset_image_type
 		record.caller_image = H.build_image()
 
-//These build caller image from outfit and some additional data, for use by mappers for ruin holorecords
+//These build caller_but_not_a_byond_built_in_proc image from outfit and some additional data, for use by mappers for ruin holorecords
 /datum/preset_holoimage
 	var/nonhuman_mobtype //Fill this if you just want something nonhuman
 	var/outfit_type

code/datums/mapgen/dungeon_generators/maintenance_generator/maintenance_generator.dm

@@ -210,7 +210,7 @@
 
 		//We have to rawdog the Astar pathfinding and skip the wrapper proc because that's made specifically for mobs
 		var/list/cable_path = AStar(
-			caller = our_apc,
+			caller_but_not_a_byond_built_in_proc = our_apc,
 			_end = closest_apc,
 			dist = /turf/proc/Distance_cardinal,
 			maxnodes = 0,

code/game/machinery/hologram.dm

@@ -262,7 +262,7 @@ obj/machinery/holopad/secure/Initialize(mapload)
 	for(var/I in holo_calls)
 		var/datum/holocall/HC = I
 		var/list/call_data = list(
-			caller = HC.user,
+			caller_but_not_a_byond_built_in_proc = HC.user,
 			connected = HC.connected_holopad == src ? TRUE : FALSE,
 			ref = REF(HC)
 		)

code/game/machinery/porta_turret/portable_turret.dm

@@ -628,13 +628,13 @@
 	remote_controller = null
 	return TRUE
 
-/obj/machinery/porta_turret/proc/InterceptClickOn(mob/living/caller, params, atom/A)
+/obj/machinery/porta_turret/proc/InterceptClickOn(mob/living/caller_but_not_a_byond_built_in_proc, params, atom/A)
 	if(!manual_control)
 		return FALSE
-	if(!can_interact(caller))
+	if(!can_interact(caller_but_not_a_byond_built_in_proc))
 		remove_control()
 		return FALSE
-	log_combat(caller,A,"fired with manual turret control at")
+	log_combat(caller_but_not_a_byond_built_in_proc,A,"fired with manual turret control at")
 	target(A)
 	return TRUE
 

code/game/machinery/telecomms/machines/message_server.dm

@@ -137,7 +137,7 @@
 		pda_msgs += M
 		signal.logged = TRUE
 		var/datum/signal/subspace/current = signal
-		while (current) // Recursively mark logged so we know in the caller proc that it is logged and sent proper
+		while (current) // Recursively mark logged so we know in the caller_but_not_a_byond_built_in_proc proc that it is logged and sent proper
 			current.data["logged"] = TRUE
 			current = current.original
 	else if(istype(signal, /datum/signal/subspace/messaging/rc))

code/game/objects/items/robot/ai_upgrades.dm

@@ -163,7 +163,7 @@
 	if(owner.stat == DEAD) 
 		return FALSE
 
-/datum/action/innate/ai/ranged/cameragun/do_ability(mob/living/caller, params, atom/target)
+/datum/action/innate/ai/ranged/cameragun/do_ability(mob/living/caller_but_not_a_byond_built_in_proc, params, atom/target)
 	var/turf/loc_target = get_turf(target)
 	var/obj/machinery/camera/chosen_camera
 	for(var/obj/machinery/camera/cam in GLOB.cameranet.cameras)
@@ -191,7 +191,7 @@
 			continue
 	if(!chosen_camera)
 		Deactivate(FALSE)
-		to_chat(caller, span_notice("Unable to find nearby available cameras for this target."))
+		to_chat(caller_but_not_a_byond_built_in_proc, span_notice("Unable to find nearby available cameras for this target."))
 		return FALSE
 	if(!burstmode_activated)
 		toggle_burstmode()
@@ -203,7 +203,7 @@
 		Deactivate(FALSE)
 		CRASH("Camera gun's proj_type was not a projectile.")
 	proj.preparePixelProjectile(target, chosen_camera)
-	proj.firer = caller
+	proj.firer = caller_but_not_a_byond_built_in_proc
 
 	// Fire the shot.
 	var/pointblank = get_dist(chosen_camera, target) <= 1 ? TRUE : FALSE // Same tile or right next.
@@ -214,7 +214,7 @@
 		chosen_camera.visible_message(span_danger("[chosen_camera] fires a laser!"))
 		proj.fire() 
 	Deactivate(FALSE)
-	to_chat(caller, span_danger("Camera overcharged."))
+	to_chat(caller_but_not_a_byond_built_in_proc, span_danger("Camera overcharged."))
 
 	/* 	This EMP prevents burstmode from annihilating a stationary object/person.
 		If someone gives a camera EMP resistance, then they had it coming. */